| Message ID | 1516128664-23634-1-git-send-email-okaya@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
Correcting linux-pci email. On 1/16/2018 1:51 PM, Sinan Kaya wrote: > When ACPI Link object is enabled, the message is printed with a warning > prefix. Some test tools are capturing warning and test error types as > errors. Let's reduce the verbosity of success case. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > drivers/acpi/pci_link.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > index bc3d914..85ad679 100644 > --- a/drivers/acpi/pci_link.c > +++ b/drivers/acpi/pci_link.c > @@ -612,7 +612,7 @@ static int acpi_pci_link_allocate(struct acpi_pci_link *link) > acpi_isa_irq_penalty[link->irq.active] += > PIRQ_PENALTY_PCI_USING; > > - printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n", > + pr_info("%s [%s] enabled at IRQ %d\n", > acpi_device_name(link->device), > acpi_device_bid(link->device), link->irq.active); > } >
On Tue, Jan 16, 2018 at 01:53:00PM -0500, Sinan Kaya wrote: > Correcting linux-pci email. > > On 1/16/2018 1:51 PM, Sinan Kaya wrote: > > When ACPI Link object is enabled, the message is printed with a warning > > prefix. Some test tools are capturing warning and test error types as > > errors. Let's reduce the verbosity of success case. > > > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> Acked-by: Bjorn Helgaas <bhelgaas@google.com> Looks like this was a result of 4d9391557b68 ("ACPI: add missing KERN_* constants to printks"), which I think added the wrong level in this case. > > --- > > drivers/acpi/pci_link.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > > index bc3d914..85ad679 100644 > > --- a/drivers/acpi/pci_link.c > > +++ b/drivers/acpi/pci_link.c > > @@ -612,7 +612,7 @@ static int acpi_pci_link_allocate(struct acpi_pci_link *link) > > acpi_isa_irq_penalty[link->irq.active] += > > PIRQ_PENALTY_PCI_USING; > > > > - printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n", > > + pr_info("%s [%s] enabled at IRQ %d\n", > > acpi_device_name(link->device), > > acpi_device_bid(link->device), link->irq.active); > > } > > > > > -- > Sinan Kaya > Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. > Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Rafael, On 1/16/2018 4:49 PM, Bjorn Helgaas wrote: > On Tue, Jan 16, 2018 at 01:53:00PM -0500, Sinan Kaya wrote: >> Correcting linux-pci email. >> >> On 1/16/2018 1:51 PM, Sinan Kaya wrote: >>> When ACPI Link object is enabled, the message is printed with a warning >>> prefix. Some test tools are capturing warning and test error types as >>> errors. Let's reduce the verbosity of success case. >>> >>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > Acked-by: Bjorn Helgaas <bhelgaas@google.com> > > Looks like this was a result of 4d9391557b68 ("ACPI: add missing KERN_* > constants to printks"), which I think added the wrong level in this case. > Any chance of merging this for 4.16? Sinan
On Mon, Jan 29, 2018 at 8:01 PM, Sinan Kaya <okaya@codeaurora.org> wrote: > Rafael, > > On 1/16/2018 4:49 PM, Bjorn Helgaas wrote: >> On Tue, Jan 16, 2018 at 01:53:00PM -0500, Sinan Kaya wrote: >>> Correcting linux-pci email. >>> >>> On 1/16/2018 1:51 PM, Sinan Kaya wrote: >>>> When ACPI Link object is enabled, the message is printed with a warning >>>> prefix. Some test tools are capturing warning and test error types as >>>> errors. Let's reduce the verbosity of success case. >>>> >>>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> >> Acked-by: Bjorn Helgaas <bhelgaas@google.com> >> >> Looks like this was a result of 4d9391557b68 ("ACPI: add missing KERN_* >> constants to printks"), which I think added the wrong level in this case. >> > > Any chance of merging this for 4.16? There is. I've just got back home from travels and will be looking at patches to pick up for 4.16 shortly. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 1, 2018 at 8:32 AM, Rafael J. Wysocki <rafael@kernel.org> wrote: > On Mon, Jan 29, 2018 at 8:01 PM, Sinan Kaya <okaya@codeaurora.org> wrote: >> Rafael, >> >> On 1/16/2018 4:49 PM, Bjorn Helgaas wrote: >>> On Tue, Jan 16, 2018 at 01:53:00PM -0500, Sinan Kaya wrote: >>>> Correcting linux-pci email. >>>> >>>> On 1/16/2018 1:51 PM, Sinan Kaya wrote: >>>>> When ACPI Link object is enabled, the message is printed with a warning >>>>> prefix. Some test tools are capturing warning and test error types as >>>>> errors. Let's reduce the verbosity of success case. >>>>> >>>>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> >>> Acked-by: Bjorn Helgaas <bhelgaas@google.com> >>> >>> Looks like this was a result of 4d9391557b68 ("ACPI: add missing KERN_* >>> constants to printks"), which I think added the wrong level in this case. >>> >> >> Any chance of merging this for 4.16? > > There is. This one is already there in the Linus' tree AFAICS. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2018-02-04 04:03, Rafael J. Wysocki wrote: > On Thu, Feb 1, 2018 at 8:32 AM, Rafael J. Wysocki <rafael@kernel.org> > wrote: >> On Mon, Jan 29, 2018 at 8:01 PM, Sinan Kaya <okaya@codeaurora.org> >> wrote: >>> Rafael, >>> >>> On 1/16/2018 4:49 PM, Bjorn Helgaas wrote: >>>> On Tue, Jan 16, 2018 at 01:53:00PM -0500, Sinan Kaya wrote: >>>>> Correcting linux-pci email. >>>>> >>>>> On 1/16/2018 1:51 PM, Sinan Kaya wrote: >>>>>> When ACPI Link object is enabled, the message is printed with a >>>>>> warning >>>>>> prefix. Some test tools are capturing warning and test error types >>>>>> as >>>>>> errors. Let's reduce the verbosity of success case. >>>>>> >>>>>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> >>>> Acked-by: Bjorn Helgaas <bhelgaas@google.com> >>>> >>>> Looks like this was a result of 4d9391557b68 ("ACPI: add missing >>>> KERN_* >>>> constants to printks"), which I think added the wrong level in this >>>> case. >>>> >>> >>> Any chance of merging this for 4.16? >> >> There is. > > This one is already there in the Linus' tree AFAICS. You are right. I see it there. I have not seen an applied email. I thought it was still outstanding. > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c index bc3d914..85ad679 100644 --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c @@ -612,7 +612,7 @@ static int acpi_pci_link_allocate(struct acpi_pci_link *link) acpi_isa_irq_penalty[link->irq.active] += PIRQ_PENALTY_PCI_USING; - printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n", + pr_info("%s [%s] enabled at IRQ %d\n", acpi_device_name(link->device), acpi_device_bid(link->device), link->irq.active); }
When ACPI Link object is enabled, the message is printed with a warning prefix. Some test tools are capturing warning and test error types as errors. Let's reduce the verbosity of success case. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- drivers/acpi/pci_link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)