diff mbox

[08/10] ARM: dts: exynos: Use camera label in exynos4412-odroid-common

Message ID 1517586235-16603-9-git-send-email-m.purski@samsung.com (mailing list archive)
State Superseded
Headers show

Commit Message

Maciej Purski Feb. 2, 2018, 3:43 p.m. UTC
Camera label has been defined in exynos4.dtsi. Use it in odroid-common
instead of defining a new node.

Signed-off-by: Maciej Purski <m.purski@samsung.com>
---
 arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Krzysztof Kozlowski Feb. 4, 2018, 5:07 p.m. UTC | #1
On Fri, Feb 02, 2018 at 04:43:53PM +0100, Maciej Purski wrote:
> Camera label has been defined in exynos4.dtsi. Use it in odroid-common
> instead of defining a new node.
> 
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 556ea78..34f4e89 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -61,12 +61,6 @@
>  		reset-gpios = <&gpk1 2 GPIO_ACTIVE_LOW>;
>  	};
>  
> -	camera {
> -		status = "okay";
> -		pinctrl-names = "default";
> -		pinctrl-0 = <>;
> -	};
> -
>  	fixed-rate-clocks {
>  		xxti {
>  			compatible = "samsung,clock-xxti";
> @@ -473,6 +467,12 @@
>  	};
>  };
>  
> +&camera {

Can you put it before &clock_audss? Not all entries are ordered already
but at least this will keep a little bit of consistency.

Best regards,
Krzysztof

> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <>;
> +};
> +
>  &i2c_1 {
>  	status = "okay";
>  	max98090: max98090@10 {
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 556ea78..34f4e89 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -61,12 +61,6 @@ 
 		reset-gpios = <&gpk1 2 GPIO_ACTIVE_LOW>;
 	};
 
-	camera {
-		status = "okay";
-		pinctrl-names = "default";
-		pinctrl-0 = <>;
-	};
-
 	fixed-rate-clocks {
 		xxti {
 			compatible = "samsung,clock-xxti";
@@ -473,6 +467,12 @@ 
 	};
 };
 
+&camera {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <>;
+};
+
 &i2c_1 {
 	status = "okay";
 	max98090: max98090@10 {