Message ID | 0d629a68-a1fa-7297-e371-5abbc2dd5fe7@grimberg.me (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
Hi Sagi/Logan, I've repro it with v4.14.1 (not happens on each connect). Sagi's proposal below fix the issue of the "Failed to write to /dev/nvme-fabrics: Invalid cross-device link". Sagi can you push (with my Tested-by: Max Gurtovoy <maxg@mellanox.com> and Reviewed-by: Max Gurtovoy <maxg@mellanox.com>) it or I will ? The crush after the connection failure is fixed in my patches for NVMe core state machine fixes that are under review in the list. > > So I think this should make the problem go away: > -- > diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h > index a0610427e168..b82c4ae92411 100644 > --- a/include/linux/mlx5/driver.h > +++ b/include/linux/mlx5/driver.h > @@ -1238,7 +1238,7 @@ mlx5_get_vector_affinity(struct mlx5_core_dev > *dev, int vector) > int eqn; > int err; > > - err = mlx5_vector2eqn(dev, vector, &eqn, &irq); > + err = mlx5_vector2eqn(dev, MLX5_EQ_VEC_COMP_BASE + vector, &eqn, > &irq); > if (err) > return NULL; > -- > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Hi Sagi/Logan, > > I've repro it with v4.14.1 (not happens on each connect). > Sagi's proposal below fix the issue of the "Failed to write to > /dev/nvme-fabrics: Invalid cross-device link". > > Sagi can you push (with my Tested-by: Max Gurtovoy <maxg@mellanox.com> > and Reviewed-by: Max Gurtovoy <maxg@mellanox.com>) it or I will ? Thanks, I'll send it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2018-02-05 at 16:18 +0200, Sagi Grimberg wrote: > > Hi Sagi/Logan, > > > > I've repro it with v4.14.1 (not happens on each connect). > > Sagi's proposal below fix the issue of the "Failed to write to > > /dev/nvme-fabrics: Invalid cross-device link". > > > > Sagi can you push (with my Tested-by: Max Gurtovoy <maxg@mellanox.c > > om> > > and Reviewed-by: Max Gurtovoy <maxg@mellanox.com>) it or I will ? > > Thanks, I'll send it. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html This missed me because all my NVME is still using CX3 (mlx4) I will move the NVME devices into the setup with mlx5 so next time I will catch this sort of issue with the testing. Currently the mlx5 is only testing ISER and SRP. Thanks Laurence -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2/5/2018 5:44 PM, Laurence Oberman wrote: > On Mon, 2018-02-05 at 16:18 +0200, Sagi Grimberg wrote: >>> Hi Sagi/Logan, >>> >>> I've repro it with v4.14.1 (not happens on each connect). >>> Sagi's proposal below fix the issue of the "Failed to write to >>> /dev/nvme-fabrics: Invalid cross-device link". >>> >>> Sagi can you push (with my Tested-by: Max Gurtovoy <maxg@mellanox.c >>> om> >>> and Reviewed-by: Max Gurtovoy <maxg@mellanox.com>) it or I will ? >> >> Thanks, I'll send it. >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" >> in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > This missed me because all my NVME is still using CX3 (mlx4) > I will move the NVME devices into the setup with mlx5 so next time I > will catch this sort of issue with the testing. > Currently the mlx5 is only testing ISER and SRP. Thanks Laurence, This is well appreciated :) > > Thanks > Laurence > Cheers, Max -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h index a0610427e168..b82c4ae92411 100644 --- a/include/linux/mlx5/driver.h +++ b/include/linux/mlx5/driver.h @@ -1238,7 +1238,7 @@ mlx5_get_vector_affinity(struct mlx5_core_dev *dev, int vector) int eqn; int err; - err = mlx5_vector2eqn(dev, vector, &eqn, &irq); + err = mlx5_vector2eqn(dev, MLX5_EQ_VEC_COMP_BASE + vector, &eqn, &irq); if (err)