| Message ID | 20180205142230.9755-3-s.nawrocki@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2018년 02월 05일 23:22, Sylwester Nawrocki wrote: > The sclk_ioclk_i2s1_bclk clock is not currently handled by any driver > and disabling this clock by the clk core prevents proper operation > of the I2S1 block. CLK_IGNORE_UNUSED flag is added as a temporary fix. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > drivers/clk/samsung/clk-exynos5433.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index d74361736e64..15177f74e125 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -1680,7 +1680,7 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = { > ENABLE_SCLK_PERIC, 11, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_IOCLK_I2S1_BCLK, "sclk_ioclk_i2s1_bclk", > "ioclk_i2s1_bclk_in", ENABLE_SCLK_PERIC, 10, > - CLK_SET_RATE_PARENT, 0), > + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0), > GATE(CLK_SCLK_SPDIF, "sclk_spdif", "sclk_spdif_peric", > ENABLE_SCLK_PERIC, 8, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", > If any device driver handles the sclk_ioclk_i2s1_bclk on later, CLK_IGNORE_UNUSED will be ignored. Looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
On 02/06/2018 05:08 AM, Chanwoo Choi wrote: > On 2018년 02월 05일 23:22, Sylwester Nawrocki wrote: >> The sclk_ioclk_i2s1_bclk clock is not currently handled by any driver >> and disabling this clock by the clk core prevents proper operation >> of the I2S1 block. CLK_IGNORE_UNUSED flag is added as a temporary fix. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> --- >> drivers/clk/samsung/clk-exynos5433.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c >> index d74361736e64..15177f74e125 100644 >> --- a/drivers/clk/samsung/clk-exynos5433.c >> +++ b/drivers/clk/samsung/clk-exynos5433.c >> @@ -1680,7 +1680,7 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = { >> ENABLE_SCLK_PERIC, 11, CLK_SET_RATE_PARENT, 0), >> GATE(CLK_SCLK_IOCLK_I2S1_BCLK, "sclk_ioclk_i2s1_bclk", >> "ioclk_i2s1_bclk_in", ENABLE_SCLK_PERIC, 10, >> - CLK_SET_RATE_PARENT, 0), >> + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0), >> GATE(CLK_SCLK_SPDIF, "sclk_spdif", "sclk_spdif_peric", >> ENABLE_SCLK_PERIC, 8, CLK_SET_RATE_PARENT, 0), >> GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", >> > If any device driver handles the sclk_ioclk_i2s1_bclk on later, > CLK_IGNORE_UNUSED will be ignored. Looks good to me. > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Thanks, I have applied the patch to clk/samsung tree.
diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index d74361736e64..15177f74e125 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -1680,7 +1680,7 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = { ENABLE_SCLK_PERIC, 11, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_IOCLK_I2S1_BCLK, "sclk_ioclk_i2s1_bclk", "ioclk_i2s1_bclk_in", ENABLE_SCLK_PERIC, 10, - CLK_SET_RATE_PARENT, 0), + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0), GATE(CLK_SCLK_SPDIF, "sclk_spdif", "sclk_spdif_peric", ENABLE_SCLK_PERIC, 8, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric",
The sclk_ioclk_i2s1_bclk clock is not currently handled by any driver and disabling this clock by the clk core prevents proper operation of the I2S1 block. CLK_IGNORE_UNUSED flag is added as a temporary fix. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- drivers/clk/samsung/clk-exynos5433.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)