| Message ID | 20180209005712.29353-1-mka@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fb239c1209bb0f0b4830cc72507cc2f2d63fadbd |
| Delegated to: | Kalle Valo |
| Headers | show |
On 02/08/2018 06:57 PM, Matthias Kaehlcke wrote: > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > is assigned to itself in an if ... else statement, apparently only to > document that the branch condition is handled and that a previously read > value should be returned unmodified. The self-assignment causes clang to > raise the following warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13: > error: explicitly assigning value of variable of type 'u32' > (aka 'unsigned int') to itself [-Werror,-Wself-assign] > writeVal = writeVal; > > Delete the branch with the self-assignment. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > Changes in v2: > - Delete the 'else if' branch entirely > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 --- > 1 file changed, 3 deletions(-) Acked-by: Larry Finger <Larry.Finger@lwfinger.net> > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c > index 9cff6bc4049c..cf551785eb08 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c > @@ -299,9 +299,6 @@ static void _rtl92c_get_txpower_writeval_by_regulatory(struct ieee80211_hw *hw, > writeVal = 0x00000000; > if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1) > writeVal = writeVal - 0x06060606; > - else if (rtlpriv->dm.dynamic_txhighpower_lvl == > - TXHIGHPWRLEVEL_BT2) > - writeVal = writeVal; > *(p_outwriteval + rf) = writeVal; > } > } >
On Thu, Feb 8, 2018 at 4:57 PM, Matthias Kaehlcke <mka@chromium.org> wrote: > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > is assigned to itself in an if ... else statement, apparently only to > document that the branch condition is handled and that a previously read > value should be returned unmodified. The self-assignment causes clang to > raise the following warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13: > error: explicitly assigning value of variable of type 'u32' > (aka 'unsigned int') to itself [-Werror,-Wself-assign] > writeVal = writeVal; > > Delete the branch with the self-assignment. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > Changes in v2: > - Delete the 'else if' branch entirely > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c > index 9cff6bc4049c..cf551785eb08 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c > @@ -299,9 +299,6 @@ static void _rtl92c_get_txpower_writeval_by_regulatory(struct ieee80211_hw *hw, > writeVal = 0x00000000; > if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1) > writeVal = writeVal - 0x06060606; > - else if (rtlpriv->dm.dynamic_txhighpower_lvl == > - TXHIGHPWRLEVEL_BT2) > - writeVal = writeVal; > *(p_outwriteval + rf) = writeVal; > } > } > -- > 2.16.0.rc1.238.g530d649a79-goog >
Matthias Kaehlcke <mka@chromium.org> wrote: > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > is assigned to itself in an if ... else statement, apparently only to > document that the branch condition is handled and that a previously read > value should be returned unmodified. The self-assignment causes clang to > raise the following warning: > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13: > error: explicitly assigning value of variable of type 'u32' > (aka 'unsigned int') to itself [-Werror,-Wself-assign] > writeVal = writeVal; > > Delete the branch with the self-assignment. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > Acked-by: Larry Finger <Larry.Finger@lwfinger.net> > Reviewed-by: Guenter Roeck <groeck@chromium.org> Patch applied to wireless-drivers-next.git, thanks. fb239c1209bb rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c index 9cff6bc4049c..cf551785eb08 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c @@ -299,9 +299,6 @@ static void _rtl92c_get_txpower_writeval_by_regulatory(struct ieee80211_hw *hw, writeVal = 0x00000000; if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1) writeVal = writeVal - 0x06060606; - else if (rtlpriv->dm.dynamic_txhighpower_lvl == - TXHIGHPWRLEVEL_BT2) - writeVal = writeVal; *(p_outwriteval + rf) = writeVal; } }
In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal is assigned to itself in an if ... else statement, apparently only to document that the branch condition is handled and that a previously read value should be returned unmodified. The self-assignment causes clang to raise the following warning: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13: error: explicitly assigning value of variable of type 'u32' (aka 'unsigned int') to itself [-Werror,-Wself-assign] writeVal = writeVal; Delete the branch with the self-assignment. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Changes in v2: - Delete the 'else if' branch entirely drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 --- 1 file changed, 3 deletions(-)