| Message ID | 20180205082445.GA18274@amd (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 05, 2018 at 09:24:45AM +0100, Pavel Machek wrote: > > This adds device tree bindings for tlv320dac33.c. > > Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > Signed-off-by: Pavel Machek <pavel@ucw.cz> Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing.
On Tue 2018-02-06 12:11:22, Mark Brown wrote: > On Mon, Feb 05, 2018 at 09:24:45AM +0100, Pavel Machek wrote: > > > > This adds device tree bindings for tlv320dac33.c. > > > > Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > Please submit patches using subject lines reflecting the style for the > subsystem. This makes it easier for people to identify relevant > patches. Look at what existing commits in the area you're changing are > doing and make sure your subject lines visually resemble what they're > doing. AFAICT this goes to Documentation, not sound. If you have any comments on V1 of this patch, that would be nice, I'd like to get that merged once we are finished with the bindings. Pavel
On Tue, Feb 06, 2018 at 02:49:06PM +0100, Pavel Machek wrote: > On Tue 2018-02-06 12:11:22, Mark Brown wrote: > > Please submit patches using subject lines reflecting the style for the > > subsystem. This makes it easier for people to identify relevant > > patches. Look at what existing commits in the area you're changing are > > doing and make sure your subject lines visually resemble what they're > > doing. > AFAICT this goes to Documentation, not sound. Even if that were the case you're not following the commonly accepted practice there either. > If you have any comments on V1 of this patch, that would be nice, I'd > like to get that merged once we are finished with the bindings. It is the middle of the merge window, please be a bit more patient.
On Mon, Feb 05, 2018 at 09:24:45AM +0100, Pavel Machek wrote: > > This adds device tree bindings for tlv320dac33.c. > > Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > Signed-off-by: Pavel Machek <pavel@ucw.cz> Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt b/Documentation/devicetree/bindings/sound/tlv320dac33.txt new file mode 100644 index 0000000..aee0a87 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/tlv320dac33.txt @@ -0,0 +1,32 @@ +Texas Instruments - tlv320dac33 Codec module + +The tlv320dac33 serial control bus communicates through I2C protocols. + +Required properties: + +- compatible - "ti,tlv320dac33" +- reg - I2C slave address +- ti,burst-bclkdiv - BCLK divider value in burst mode. Valid range is 1..255. + +Optional properties: + +- reset-gpios - gpio pin to power the device, active high. + +- interrupts - The interrupt output from the device. +- interrupt-parent - The parent interrupt controller. + +- ti,keep-bclk - Keep the BCLK running in FIFO modes. + +Example: + +tlv320dac33: audio-codec@19 { + compatible = "ti,tlv320dac33"; + reg = <0x19>; + + interrupt-parent = <&gpio2>; + interrupts = <21 1>; /* gpio_53, IRQF_TRIGGER_RISING */ + reset-gpios = <&gpio2 28 0>; /* gpio_60 */ + + ti,keep-bclk; + ti,burst-bclkdiv = <3>; +};