| Message ID | 20180130215643.11016-1-eric@anholt.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 30, 2018 at 01:56:43PM -0800, Eric Anholt wrote: > When we debug print what ioctl we're calling into, we include the pid. > If you have multiple processes rendering simulataneously, the error > return also needs the pid so you can see which of the ioctl calls was > the one to fail. > > Signed-off-by: Eric Anholt <eric@anholt.net> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/drm_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c > index a9ae6dd2d593..38c302607738 100644 > --- a/drivers/gpu/drm/drm_ioctl.c > +++ b/drivers/gpu/drm/drm_ioctl.c > @@ -842,7 +842,7 @@ long drm_ioctl(struct file *filp, > if (kdata != stack_kdata) > kfree(kdata); > if (retcode) > - DRM_DEBUG("ret = %d\n", retcode); > + DRM_DEBUG("pid=%d, ret = %d\n", task_pid_nr(current), retcode); > return retcode; > } > EXPORT_SYMBOL(drm_ioctl); > -- > 2.15.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter <daniel@ffwll.ch> writes: > On Tue, Jan 30, 2018 at 01:56:43PM -0800, Eric Anholt wrote: >> When we debug print what ioctl we're calling into, we include the pid. >> If you have multiple processes rendering simulataneously, the error >> return also needs the pid so you can see which of the ioctl calls was >> the one to fail. >> >> Signed-off-by: Eric Anholt <eric@anholt.net> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Pushed. Thanks!
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index a9ae6dd2d593..38c302607738 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -842,7 +842,7 @@ long drm_ioctl(struct file *filp, if (kdata != stack_kdata) kfree(kdata); if (retcode) - DRM_DEBUG("ret = %d\n", retcode); + DRM_DEBUG("pid=%d, ret = %d\n", task_pid_nr(current), retcode); return retcode; } EXPORT_SYMBOL(drm_ioctl);
When we debug print what ioctl we're calling into, we include the pid. If you have multiple processes rendering simulataneously, the error return also needs the pid so you can see which of the ioctl calls was the one to fail. Signed-off-by: Eric Anholt <eric@anholt.net> --- drivers/gpu/drm/drm_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)