| Message ID | 20180207163150.16332-2-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Enric, Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra: > From: Chris Zhong <zyw@rock-chips.com> > > Add a node for the cdn DP controller which is embedded in the rk3399 > SoC. > > Signed-off-by: Chris Zhong <zyw@rock-chips.com> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 ++++++++++++++++++++++++++++++++ It looks like there is no binding document at all for cdn-dp? At least I couldn't find one and the original series also didn't seem to include one. And while I don't see anything problematic right with the used properties right now, I'd think we should really have a binding and give dt-maintainers a chance to complain, before adding devicetree nodes based on it. I'd guess a mostly usable binding doc should already sit in the chromeos tree, which you could base a v2 of this series on? Thanks Heiko
Hi Heiko, On 10/02/18 17:16, Heiko Stuebner wrote: > Hi Enric, > > Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra: >> From: Chris Zhong <zyw@rock-chips.com> >> >> Add a node for the cdn DP controller which is embedded in the rk3399 >> SoC. >> >> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >> --- >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 ++++++++++++++++++++++++++++++++ > > It looks like there is no binding document at all for cdn-dp? At least > I couldn't find one and the original series also didn't seem to include one. > > And while I don't see anything problematic right with the used properties > right now, I'd think we should really have a binding and give dt-maintainers > a chance to complain, before adding devicetree nodes based on it. > > I'd guess a mostly usable binding doc should already sit in the chromeos > tree, which you could base a v2 of this series on? > > Sure, I'll send a v2 for this series. Thanks. Enric > Thanks > Heiko >
2018-02-13 11:42 GMT+01:00 Enric Balletbo i Serra <enric.balletbo@collabora.com>: > Hi Heiko, > > On 10/02/18 17:16, Heiko Stuebner wrote: >> Hi Enric, >> >> Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra: >>> From: Chris Zhong <zyw@rock-chips.com> >>> >>> Add a node for the cdn DP controller which is embedded in the rk3399 >>> SoC. >>> >>> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >>> --- >>> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 ++++++++++++++++++++++++++++++++ >> >> It looks like there is no binding document at all for cdn-dp? At least >> I couldn't find one and the original series also didn't seem to include one. >> >> And while I don't see anything problematic right with the used properties >> right now, I'd think we should really have a binding and give dt-maintainers >> a chance to complain, before adding devicetree nodes based on it. >> >> I'd guess a mostly usable binding doc should already sit in the chromeos >> tree, which you could base a v2 of this series on? >> >> > > Sure, I'll send a v2 for this series. Thanks. > > Enric > So seems that the binding was already discussed and accepted here [1] but for some reason never landed. So I think that I'll send v2 just including the binding patch so all can land together. Sounds good? [1] https://patchwork.kernel.org/patch/9278077/ Cheers, Enric >> Thanks >> Heiko >>
Hi Enric, Am Dienstag, 13. Februar 2018, 12:36:47 CET schrieb Enric Balletbo Serra: > 2018-02-13 11:42 GMT+01:00 Enric Balletbo i Serra > > <enric.balletbo@collabora.com>: > > Hi Heiko, > > > > On 10/02/18 17:16, Heiko Stuebner wrote: > >> Hi Enric, > >> > >> Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra: > >>> From: Chris Zhong <zyw@rock-chips.com> > >>> > >>> Add a node for the cdn DP controller which is embedded in the rk3399 > >>> SoC. > >>> > >>> Signed-off-by: Chris Zhong <zyw@rock-chips.com> > >>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > >>> --- > >>> > >>> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 > >>> ++++++++++++++++++++++++++++++++>> > >> It looks like there is no binding document at all for cdn-dp? At least > >> I couldn't find one and the original series also didn't seem to include > >> one. > >> > >> And while I don't see anything problematic right with the used properties > >> right now, I'd think we should really have a binding and give > >> dt-maintainers a chance to complain, before adding devicetree nodes > >> based on it. > >> > >> I'd guess a mostly usable binding doc should already sit in the chromeos > >> tree, which you could base a v2 of this series on? > > > > Sure, I'll send a v2 for this series. Thanks. > > > > Enric > > So seems that the binding was already discussed and accepted here [1] > but for some reason never landed. So I think that I'll send v2 just > including the binding patch so all can land together. Sounds good? > > [1] https://patchwork.kernel.org/patch/9278077/ Nice find and yep, just resending binding + your patches 2+3 is enough then :-) Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index beef28f7309d..2f2dee0e2f3c 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -457,6 +457,46 @@ }; }; + cdn_dp: dp@fec00000 { + compatible = "rockchip,rk3399-cdn-dp"; + reg = <0x0 0xfec00000 0x0 0x100000>; + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru SCLK_DP_CORE>, <&cru PCLK_DP_CTRL>, + <&cru SCLK_SPDIF_REC_DPTX>, <&cru PCLK_VIO_GRF>; + clock-names = "core-clk", "pclk", "spdif", "grf"; + assigned-clocks = <&cru SCLK_DP_CORE>; + assigned-clock-rates = <100000000>; + power-domains = <&power RK3399_PD_HDCP>; + phys = <&tcphy0_dp>, <&tcphy1_dp>; + resets = <&cru SRST_DPTX_SPDIF_REC>, <&cru SRST_P_UPHY0_DPTX>, + <&cru SRST_P_UPHY0_APB>, <&cru SRST_DP_CORE>; + reset-names = "spdif", "dptx", "apb", "core"; + rockchip,grf = <&grf>; + #address-cells = <1>; + #size-cells = <0>; + #sound-dai-cells = <1>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + dp_in: port { + #address-cells = <1>; + #size-cells = <0>; + dp_in_vopb: endpoint@0 { + reg = <0>; + remote-endpoint = <&vopb_out_dp>; + }; + + dp_in_vopl: endpoint@1 { + reg = <1>; + remote-endpoint = <&vopl_out_dp>; + }; + }; + }; + }; + gic: interrupt-controller@fee00000 { compatible = "arm,gic-v3"; #interrupt-cells = <4>; @@ -1549,6 +1589,11 @@ reg = <3>; remote-endpoint = <&mipi1_in_vopl>; }; + + vopl_out_dp: endpoint@4 { + reg = <4>; + remote-endpoint = <&dp_in_vopl>; + }; }; }; @@ -1601,6 +1646,11 @@ reg = <3>; remote-endpoint = <&mipi1_in_vopb>; }; + + vopb_out_dp: endpoint@4 { + reg = <4>; + remote-endpoint = <&dp_in_vopb>; + }; }; };