| Message ID | 1518544819-1173-1-git-send-email-mario.limonciello@dell.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello <mario.limonciello@dell.com> wrote: > Dell uses this string to activate Thunderbolt native mode on supported > machines. > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > --- > Thunderbolt Native mode requires other patches to be applied otherwise > this patch will cause problems. > > This patch should only be applied with: > 1) Acpiphp platches from > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 > and > > 2) Thunderbolt patches from > https://lkml.org/lkml/2018/2/13/685 Thanks for these pointers, they help a lot. > This has also been submited into ACPICA: > https://github.com/acpica/acpica/pull/359 Due to the dependencies outside of upstream ACPICA, I don't think that this patch is suitable for upstream ACPICA at all. > > drivers/acpi/acpica/utosi.c | 1 + > include/acpi/actypes.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/acpi/acpica/utosi.c b/drivers/acpi/acpica/utosi.c > index f6b8dd2..aed77c3 100644 > --- a/drivers/acpi/acpica/utosi.c > +++ b/drivers/acpi/acpica/utosi.c > @@ -103,6 +103,7 @@ static struct acpi_interface_info acpi_default_supported_interfaces[] = { > {"Windows 2015", NULL, 0, ACPI_OSI_WIN_10}, /* Windows 10 - Added 03/2015 */ > {"Windows 2016", NULL, 0, ACPI_OSI_WIN_10_RS1}, /* Windows 10 version 1607 - Added 12/2017 */ > {"Windows 2017", NULL, 0, ACPI_OSI_WIN_10_RS2}, /* Windows 10 version 1703 - Added 12/2017 */ > + {"Windows 2017.2", NULL, 0, ACPI_OSI_WIN_10_RS3}, /* Windows 10 version 1709 - Added 02/2018 */ > > /* Feature Group Strings */ > > diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h > index 31f1be7..3f829cc 100644 > --- a/include/acpi/actypes.h > +++ b/include/acpi/actypes.h > @@ -1303,6 +1303,7 @@ typedef enum { > #define ACPI_OSI_WIN_10 0x0D > #define ACPI_OSI_WIN_10_RS1 0x0E > #define ACPI_OSI_WIN_10_RS2 0x0F > +#define ACPI_OSI_WIN_10_RS3 0x10 > > /* Definitions of getopt */ > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. > Wysocki > Sent: Wednesday, February 14, 2018 2:46 AM > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Len Brown > <lenb@kernel.org>; Rafael J . Wysocki <rjw@rjwysocki.net>; Mika Westerberg > <mika.westerberg@linux.intel.com> > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > > On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello > <mario.limonciello@dell.com> wrote: > > Dell uses this string to activate Thunderbolt native mode on supported > > machines. > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > --- > > Thunderbolt Native mode requires other patches to be applied otherwise > > this patch will cause problems. I should have been clearer - problems with thunderbolt driver in Linux. If you apply this patch without the rest of Mika's series there will be problems with Thunderbolt native mode in Linux. The patches you already reviewed in > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 Are the more important ones, but a few of the fixes that came in the second series help with some of the corner cases (for example cold boot ICM timeout). Mika might have a few more comments to add here from the testing he did to make those patches. > > > > This patch should only be applied with: > > 1) Acpiphp platches from > > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 > > and > > > > 2) Thunderbolt patches from > > https://lkml.org/lkml/2018/2/13/685 > > Thanks for these pointers, they help a lot. > > > This has also been submited into ACPICA: > > https://github.com/acpica/acpica/pull/359 > > Due to the dependencies outside of upstream ACPICA, I don't think that > this patch is suitable for upstream ACPICA at all. Actually ACPICA did merge it already: https://github.com/acpica/acpica/commit/24f7791789c49ec02eb024106c85d23322be5672 > > > > > drivers/acpi/acpica/utosi.c | 1 + > > include/acpi/actypes.h | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/acpi/acpica/utosi.c b/drivers/acpi/acpica/utosi.c > > index f6b8dd2..aed77c3 100644 > > --- a/drivers/acpi/acpica/utosi.c > > +++ b/drivers/acpi/acpica/utosi.c > > @@ -103,6 +103,7 @@ static struct acpi_interface_info > acpi_default_supported_interfaces[] = { > > {"Windows 2015", NULL, 0, ACPI_OSI_WIN_10}, /* Windows 10 - Added > 03/2015 */ > > {"Windows 2016", NULL, 0, ACPI_OSI_WIN_10_RS1}, /* Windows 10 version > 1607 - Added 12/2017 */ > > {"Windows 2017", NULL, 0, ACPI_OSI_WIN_10_RS2}, /* Windows 10 version > 1703 - Added 12/2017 */ > > + {"Windows 2017.2", NULL, 0, ACPI_OSI_WIN_10_RS3}, /* Windows 10 > version 1709 - Added 02/2018 */ > > > > /* Feature Group Strings */ > > > > diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h > > index 31f1be7..3f829cc 100644 > > --- a/include/acpi/actypes.h > > +++ b/include/acpi/actypes.h > > @@ -1303,6 +1303,7 @@ typedef enum { > > #define ACPI_OSI_WIN_10 0x0D > > #define ACPI_OSI_WIN_10_RS1 0x0E > > #define ACPI_OSI_WIN_10_RS2 0x0F > > +#define ACPI_OSI_WIN_10_RS3 0x10 > > > > /* Definitions of getopt */ > > > > --
On Wed, Feb 14, 2018 at 4:39 PM, <Mario.Limonciello@dell.com> wrote: >> -----Original Message----- >> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. >> Wysocki >> Sent: Wednesday, February 14, 2018 2:46 AM >> To: Limonciello, Mario <Mario_Limonciello@Dell.com> >> Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Len Brown >> <lenb@kernel.org>; Rafael J . Wysocki <rjw@rjwysocki.net>; Mika Westerberg >> <mika.westerberg@linux.intel.com> >> Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string >> >> On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello >> <mario.limonciello@dell.com> wrote: >> > Dell uses this string to activate Thunderbolt native mode on supported >> > machines. >> > >> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> >> > --- >> > Thunderbolt Native mode requires other patches to be applied otherwise >> > this patch will cause problems. > > I should have been clearer - problems with thunderbolt driver in Linux. > > If you apply this patch without the rest of Mika's series there will be problems > with Thunderbolt native mode in Linux. Right. > The patches you already reviewed in >> https://marc.info/?l=linux-acpi&m=151853954129169&w=2 > > Are the more important ones, but a few of the fixes that came in the second > series help with some of the corner cases (for example cold boot ICM timeout). OK > Mika might have a few more comments to add here from the testing he did > to make those patches. > >> > >> > This patch should only be applied with: >> > 1) Acpiphp platches from >> > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 >> > and >> > >> > 2) Thunderbolt patches from >> > https://lkml.org/lkml/2018/2/13/685 >> >> Thanks for these pointers, they help a lot. >> >> > This has also been submited into ACPICA: >> > https://github.com/acpica/acpica/pull/359 >> >> Due to the dependencies outside of upstream ACPICA, I don't think that >> this patch is suitable for upstream ACPICA at all. > > Actually ACPICA did merge it already: > https://github.com/acpica/acpica/commit/24f7791789c49ec02eb024106c85d23322be5672 So there appear to be differing opinions. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Rafael, > -----Original Message----- > From: Limonciello, Mario > Sent: Wednesday, February 14, 2018 9:39 AM > To: 'Rafael J. Wysocki' > Cc: ACPI Devel Maling List; Len Brown; Rafael J . Wysocki; Mika Westerberg > Subject: RE: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > > > -----Original Message----- > > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. > > Wysocki > > Sent: Wednesday, February 14, 2018 2:46 AM > > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > > Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Len Brown > > <lenb@kernel.org>; Rafael J . Wysocki <rjw@rjwysocki.net>; Mika Westerberg > > <mika.westerberg@linux.intel.com> > > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > > > > On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello > > <mario.limonciello@dell.com> wrote: > > > Dell uses this string to activate Thunderbolt native mode on supported > > > machines. > > > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > > --- > > > Thunderbolt Native mode requires other patches to be applied otherwise > > > this patch will cause problems. > > I should have been clearer - problems with thunderbolt driver in Linux. > > If you apply this patch without the rest of Mika's series there will be problems > with Thunderbolt native mode in Linux. > > The patches you already reviewed in > > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 > > Are the more important ones, but a few of the fixes that came in the second > series help with some of the corner cases (for example cold boot ICM timeout). > > Mika might have a few more comments to add here from the testing he did > to make those patches. Mika's patch series was merged into 4.18. If you can possibly include this ACPICA change now as well that would be ideal. Thanks, > > > > > > > This patch should only be applied with: > > > 1) Acpiphp platches from > > > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 > > > and > > > > > > 2) Thunderbolt patches from > > > https://lkml.org/lkml/2018/2/13/685 > > > > Thanks for these pointers, they help a lot. > > > > > This has also been submited into ACPICA: > > > https://github.com/acpica/acpica/pull/359 > > > > Due to the dependencies outside of upstream ACPICA, I don't think that > > this patch is suitable for upstream ACPICA at all. > > Actually ACPICA did merge it already: > https://github.com/acpica/acpica/commit/24f7791789c49ec02eb024106c85d233 > 22be5672 > > > > > > > > > drivers/acpi/acpica/utosi.c | 1 + > > > include/acpi/actypes.h | 1 + > > > 2 files changed, 2 insertions(+) > > > > > > diff --git a/drivers/acpi/acpica/utosi.c b/drivers/acpi/acpica/utosi.c > > > index f6b8dd2..aed77c3 100644 > > > --- a/drivers/acpi/acpica/utosi.c > > > +++ b/drivers/acpi/acpica/utosi.c > > > @@ -103,6 +103,7 @@ static struct acpi_interface_info > > acpi_default_supported_interfaces[] = { > > > {"Windows 2015", NULL, 0, ACPI_OSI_WIN_10}, /* Windows 10 - Added > > 03/2015 */ > > > {"Windows 2016", NULL, 0, ACPI_OSI_WIN_10_RS1}, /* Windows 10 version > > 1607 - Added 12/2017 */ > > > {"Windows 2017", NULL, 0, ACPI_OSI_WIN_10_RS2}, /* Windows 10 version > > 1703 - Added 12/2017 */ > > > + {"Windows 2017.2", NULL, 0, ACPI_OSI_WIN_10_RS3}, /* Windows 10 > > version 1709 - Added 02/2018 */ > > > > > > /* Feature Group Strings */ > > > > > > diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h > > > index 31f1be7..3f829cc 100644 > > > --- a/include/acpi/actypes.h > > > +++ b/include/acpi/actypes.h > > > @@ -1303,6 +1303,7 @@ typedef enum { > > > #define ACPI_OSI_WIN_10 0x0D > > > #define ACPI_OSI_WIN_10_RS1 0x0E > > > #define ACPI_OSI_WIN_10_RS2 0x0F > > > +#define ACPI_OSI_WIN_10_RS3 0x10 > > > > > > /* Definitions of getopt */ > > > > > > --
On Mon, Jun 4, 2018 at 10:32 PM, <Mario.Limonciello@dell.com> wrote: > Rafael, > >> -----Original Message----- >> From: Limonciello, Mario >> Sent: Wednesday, February 14, 2018 9:39 AM >> To: 'Rafael J. Wysocki' >> Cc: ACPI Devel Maling List; Len Brown; Rafael J . Wysocki; Mika Westerberg >> Subject: RE: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string >> >> > -----Original Message----- >> > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. >> > Wysocki >> > Sent: Wednesday, February 14, 2018 2:46 AM >> > To: Limonciello, Mario <Mario_Limonciello@Dell.com> >> > Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Len Brown >> > <lenb@kernel.org>; Rafael J . Wysocki <rjw@rjwysocki.net>; Mika Westerberg >> > <mika.westerberg@linux.intel.com> >> > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string >> > >> > On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello >> > <mario.limonciello@dell.com> wrote: >> > > Dell uses this string to activate Thunderbolt native mode on supported >> > > machines. >> > > >> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> >> > > --- >> > > Thunderbolt Native mode requires other patches to be applied otherwise >> > > this patch will cause problems. >> >> I should have been clearer - problems with thunderbolt driver in Linux. >> >> If you apply this patch without the rest of Mika's series there will be problems >> with Thunderbolt native mode in Linux. >> >> The patches you already reviewed in >> > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 >> >> Are the more important ones, but a few of the fixes that came in the second >> series help with some of the corner cases (for example cold boot ICM timeout). >> >> Mika might have a few more comments to add here from the testing he did >> to make those patches. > > Mika's patch series was merged into 4.18. It's not yet in the Linus' tree, though, AFAICS. > If you can possibly include this ACPICA > change now as well that would be ideal. That's my plan. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. > Wysocki > Sent: Tuesday, June 5, 2018 3:28 AM > To: Limonciello, Mario > Cc: Rafael J. Wysocki; ACPI Devel Maling List; Len Brown; Rafael J. Wysocki; Mika > Westerberg > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > > On Mon, Jun 4, 2018 at 10:32 PM, <Mario.Limonciello@dell.com> wrote: > > Rafael, > > > >> -----Original Message----- > >> From: Limonciello, Mario > >> Sent: Wednesday, February 14, 2018 9:39 AM > >> To: 'Rafael J. Wysocki' > >> Cc: ACPI Devel Maling List; Len Brown; Rafael J . Wysocki; Mika Westerberg > >> Subject: RE: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > >> > >> > -----Original Message----- > >> > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of > Rafael J. > >> > Wysocki > >> > Sent: Wednesday, February 14, 2018 2:46 AM > >> > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > >> > Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Len Brown > >> > <lenb@kernel.org>; Rafael J . Wysocki <rjw@rjwysocki.net>; Mika Westerberg > >> > <mika.westerberg@linux.intel.com> > >> > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > >> > > >> > On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello > >> > <mario.limonciello@dell.com> wrote: > >> > > Dell uses this string to activate Thunderbolt native mode on supported > >> > > machines. > >> > > > >> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > >> > > --- > >> > > Thunderbolt Native mode requires other patches to be applied otherwise > >> > > this patch will cause problems. > >> > >> I should have been clearer - problems with thunderbolt driver in Linux. > >> > >> If you apply this patch without the rest of Mika's series there will be problems > >> with Thunderbolt native mode in Linux. > >> > >> The patches you already reviewed in > >> > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 > >> > >> Are the more important ones, but a few of the fixes that came in the second > >> series help with some of the corner cases (for example cold boot ICM timeout). > >> > >> Mika might have a few more comments to add here from the testing he did > >> to make those patches. > > > > Mika's patch series was merged into 4.18. > > It's not yet in the Linus' tree, though, AFAICS. > Jarod just mentioned to me that everything should be there now. Can you check again? > > If you can possibly include this ACPICA > > change now as well that would be ideal. > > That's my plan. > > Thanks, > Rafael
On Sat, Jun 9, 2018 at 12:39 AM, <Mario.Limonciello@dell.com> wrote: >> -----Original Message----- >> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. >> Wysocki >> Sent: Tuesday, June 5, 2018 3:28 AM >> To: Limonciello, Mario >> Cc: Rafael J. Wysocki; ACPI Devel Maling List; Len Brown; Rafael J. Wysocki; Mika >> Westerberg >> Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string >> >> On Mon, Jun 4, 2018 at 10:32 PM, <Mario.Limonciello@dell.com> wrote: >> > Rafael, >> > >> >> -----Original Message----- >> >> From: Limonciello, Mario >> >> Sent: Wednesday, February 14, 2018 9:39 AM >> >> To: 'Rafael J. Wysocki' >> >> Cc: ACPI Devel Maling List; Len Brown; Rafael J . Wysocki; Mika Westerberg >> >> Subject: RE: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string >> >> >> >> > -----Original Message----- >> >> > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of >> Rafael J. >> >> > Wysocki >> >> > Sent: Wednesday, February 14, 2018 2:46 AM >> >> > To: Limonciello, Mario <Mario_Limonciello@Dell.com> >> >> > Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Len Brown >> >> > <lenb@kernel.org>; Rafael J . Wysocki <rjw@rjwysocki.net>; Mika Westerberg >> >> > <mika.westerberg@linux.intel.com> >> >> > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string >> >> > >> >> > On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello >> >> > <mario.limonciello@dell.com> wrote: >> >> > > Dell uses this string to activate Thunderbolt native mode on supported >> >> > > machines. >> >> > > >> >> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> >> >> > > --- >> >> > > Thunderbolt Native mode requires other patches to be applied otherwise >> >> > > this patch will cause problems. >> >> >> >> I should have been clearer - problems with thunderbolt driver in Linux. >> >> >> >> If you apply this patch without the rest of Mika's series there will be problems >> >> with Thunderbolt native mode in Linux. >> >> >> >> The patches you already reviewed in >> >> > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 >> >> >> >> Are the more important ones, but a few of the fixes that came in the second >> >> series help with some of the corner cases (for example cold boot ICM timeout). >> >> >> >> Mika might have a few more comments to add here from the testing he did >> >> to make those patches. >> > >> > Mika's patch series was merged into 4.18. >> >> It's not yet in the Linus' tree, though, AFAICS. >> > > Jarod just mentioned to me that everything should be there now. Can you check again? That's correct. The PCI material containing it was merged a couple of days ago and I'm going to queue up your patch for the second half of the merge window. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sunday, June 10, 2018 10:49:30 AM CEST Rafael J. Wysocki wrote: > On Sat, Jun 9, 2018 at 12:39 AM, <Mario.Limonciello@dell.com> wrote: > >> -----Original Message----- > >> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. > >> Wysocki > >> Sent: Tuesday, June 5, 2018 3:28 AM > >> To: Limonciello, Mario > >> Cc: Rafael J. Wysocki; ACPI Devel Maling List; Len Brown; Rafael J. Wysocki; Mika > >> Westerberg > >> Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > >> > >> On Mon, Jun 4, 2018 at 10:32 PM, <Mario.Limonciello@dell.com> wrote: > >> > Rafael, > >> > > >> >> -----Original Message----- > >> >> From: Limonciello, Mario > >> >> Sent: Wednesday, February 14, 2018 9:39 AM > >> >> To: 'Rafael J. Wysocki' > >> >> Cc: ACPI Devel Maling List; Len Brown; Rafael J . Wysocki; Mika Westerberg > >> >> Subject: RE: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > >> >> > >> >> > -----Original Message----- > >> >> > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of > >> Rafael J. > >> >> > Wysocki > >> >> > Sent: Wednesday, February 14, 2018 2:46 AM > >> >> > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > >> >> > Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Len Brown > >> >> > <lenb@kernel.org>; Rafael J . Wysocki <rjw@rjwysocki.net>; Mika Westerberg > >> >> > <mika.westerberg@linux.intel.com> > >> >> > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > >> >> > > >> >> > On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello > >> >> > <mario.limonciello@dell.com> wrote: > >> >> > > Dell uses this string to activate Thunderbolt native mode on supported > >> >> > > machines. > >> >> > > > >> >> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > >> >> > > --- > >> >> > > Thunderbolt Native mode requires other patches to be applied otherwise > >> >> > > this patch will cause problems. > >> >> > >> >> I should have been clearer - problems with thunderbolt driver in Linux. > >> >> > >> >> If you apply this patch without the rest of Mika's series there will be problems > >> >> with Thunderbolt native mode in Linux. > >> >> > >> >> The patches you already reviewed in > >> >> > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 > >> >> > >> >> Are the more important ones, but a few of the fixes that came in the second > >> >> series help with some of the corner cases (for example cold boot ICM timeout). > >> >> > >> >> Mika might have a few more comments to add here from the testing he did > >> >> to make those patches. > >> > > >> > Mika's patch series was merged into 4.18. > >> > >> It's not yet in the Linus' tree, though, AFAICS. > >> > > > > Jarod just mentioned to me that everything should be there now. Can you check again? > > That's correct. The PCI material containing it was merged a couple of > days ago and I'm going to queue up your patch for the second half of > the merge window. I've applied the one from the Erik's ACPICA series. Please double check my linux-next branch. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Tuesday, June 12, 2018 9:53 AM > To: Limonciello, Mario > Cc: ACPI Devel Maling List; Len Brown; Mika Westerberg; jarod@redhat.com; Erik > Schmauss > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > > On Sunday, June 10, 2018 10:49:30 AM CEST Rafael J. Wysocki wrote: > > On Sat, Jun 9, 2018 at 12:39 AM, <Mario.Limonciello@dell.com> wrote: > > >> -----Original Message----- > > >> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of > Rafael J. > > >> Wysocki > > >> Sent: Tuesday, June 5, 2018 3:28 AM > > >> To: Limonciello, Mario > > >> Cc: Rafael J. Wysocki; ACPI Devel Maling List; Len Brown; Rafael J. Wysocki; > Mika > > >> Westerberg > > >> Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > > >> > > >> On Mon, Jun 4, 2018 at 10:32 PM, <Mario.Limonciello@dell.com> wrote: > > >> > Rafael, > > >> > > > >> >> -----Original Message----- > > >> >> From: Limonciello, Mario > > >> >> Sent: Wednesday, February 14, 2018 9:39 AM > > >> >> To: 'Rafael J. Wysocki' > > >> >> Cc: ACPI Devel Maling List; Len Brown; Rafael J . Wysocki; Mika Westerberg > > >> >> Subject: RE: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > > >> >> > > >> >> > -----Original Message----- > > >> >> > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of > > >> Rafael J. > > >> >> > Wysocki > > >> >> > Sent: Wednesday, February 14, 2018 2:46 AM > > >> >> > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > > >> >> > Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Len Brown > > >> >> > <lenb@kernel.org>; Rafael J . Wysocki <rjw@rjwysocki.net>; Mika > Westerberg > > >> >> > <mika.westerberg@linux.intel.com> > > >> >> > Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string > > >> >> > > > >> >> > On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello > > >> >> > <mario.limonciello@dell.com> wrote: > > >> >> > > Dell uses this string to activate Thunderbolt native mode on supported > > >> >> > > machines. > > >> >> > > > > >> >> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > >> >> > > --- > > >> >> > > Thunderbolt Native mode requires other patches to be applied otherwise > > >> >> > > this patch will cause problems. > > >> >> > > >> >> I should have been clearer - problems with thunderbolt driver in Linux. > > >> >> > > >> >> If you apply this patch without the rest of Mika's series there will be > problems > > >> >> with Thunderbolt native mode in Linux. > > >> >> > > >> >> The patches you already reviewed in > > >> >> > https://marc.info/?l=linux-acpi&m=151853954129169&w=2 > > >> >> > > >> >> Are the more important ones, but a few of the fixes that came in the second > > >> >> series help with some of the corner cases (for example cold boot ICM > timeout). > > >> >> > > >> >> Mika might have a few more comments to add here from the testing he did > > >> >> to make those patches. > > >> > > > >> > Mika's patch series was merged into 4.18. > > >> > > >> It's not yet in the Linus' tree, though, AFAICS. > > >> > > > > > > Jarod just mentioned to me that everything should be there now. Can you check > again? > > > > That's correct. The PCI material containing it was merged a couple of > > days ago and I'm going to queue up your patch for the second half of > > the merge window. > > I've applied the one from the Erik's ACPICA series. Please double check my > linux-next branch. > > Thanks, > Rafael Looks good, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/acpica/utosi.c b/drivers/acpi/acpica/utosi.c index f6b8dd2..aed77c3 100644 --- a/drivers/acpi/acpica/utosi.c +++ b/drivers/acpi/acpica/utosi.c @@ -103,6 +103,7 @@ static struct acpi_interface_info acpi_default_supported_interfaces[] = { {"Windows 2015", NULL, 0, ACPI_OSI_WIN_10}, /* Windows 10 - Added 03/2015 */ {"Windows 2016", NULL, 0, ACPI_OSI_WIN_10_RS1}, /* Windows 10 version 1607 - Added 12/2017 */ {"Windows 2017", NULL, 0, ACPI_OSI_WIN_10_RS2}, /* Windows 10 version 1703 - Added 12/2017 */ + {"Windows 2017.2", NULL, 0, ACPI_OSI_WIN_10_RS3}, /* Windows 10 version 1709 - Added 02/2018 */ /* Feature Group Strings */ diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h index 31f1be7..3f829cc 100644 --- a/include/acpi/actypes.h +++ b/include/acpi/actypes.h @@ -1303,6 +1303,7 @@ typedef enum { #define ACPI_OSI_WIN_10 0x0D #define ACPI_OSI_WIN_10_RS1 0x0E #define ACPI_OSI_WIN_10_RS2 0x0F +#define ACPI_OSI_WIN_10_RS3 0x10 /* Definitions of getopt */
Dell uses this string to activate Thunderbolt native mode on supported machines. Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> --- Thunderbolt Native mode requires other patches to be applied otherwise this patch will cause problems. This patch should only be applied with: 1) Acpiphp platches from https://marc.info/?l=linux-acpi&m=151853954129169&w=2 and 2) Thunderbolt patches from https://lkml.org/lkml/2018/2/13/685 This has also been submited into ACPICA: https://github.com/acpica/acpica/pull/359 drivers/acpi/acpica/utosi.c | 1 + include/acpi/actypes.h | 1 + 2 files changed, 2 insertions(+)