| Message ID | 20180215103920.32017-5-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: > OF graph describes MHL data lanes between MHL and respective USB > connector. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++++++++++++++++++--- > 1 file changed, 28 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > index 7e49fadee412..ef758f7337e9 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > @@ -779,9 +779,22 @@ > clocks = <&pmu_system_controller 0>; > clock-names = "xtal"; > > - port { > - mhl_to_hdmi: endpoint { > - remote-endpoint = <&hdmi_to_mhl>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + mhl_to_hdmi: endpoint { > + remote-endpoint = <&hdmi_to_mhl>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + mhl_to_musb_con: endpoint { > + remote-endpoint = <&musb_con_to_mhl>; > + }; > }; > }; > }; > @@ -804,6 +817,18 @@ > "usb-b-connector"; > label = "micro-USB"; > type = "micro"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@3 { I think you might need here "reg = <3>". Doesn't it produce a warning now? BR, Krzysztof > + musb_con_to_mhl: endpoint { > + remote-endpoint = <&mhl_to_musb_con>; > + }; > + }; > + }; > + }; > }; > }; > > -- > 2.16.1 >
On 15.02.2018 13:14, Krzysztof Kozlowski wrote: > On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++++++++++++++++++--- >> 1 file changed, 28 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> index 7e49fadee412..ef758f7337e9 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -779,9 +779,22 @@ >> clocks = <&pmu_system_controller 0>; >> clock-names = "xtal"; >> >> - port { >> - mhl_to_hdmi: endpoint { >> - remote-endpoint = <&hdmi_to_mhl>; >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + mhl_to_hdmi: endpoint { >> + remote-endpoint = <&hdmi_to_mhl>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + mhl_to_musb_con: endpoint { >> + remote-endpoint = <&musb_con_to_mhl>; >> + }; >> }; >> }; >> }; >> @@ -804,6 +817,18 @@ >> "usb-b-connector"; >> label = "micro-USB"; >> type = "micro"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@3 { > I think you might need here "reg = <3>". Doesn't it produce a warning now? You are right, I will fix it. Warning is produced only if compiled with W=1. Regards Andrzej > > BR, > Krzysztof > >> + musb_con_to_mhl: endpoint { >> + remote-endpoint = <&mhl_to_musb_con>; >> + }; >> + }; >> + }; >> + }; >> }; >> }; >> >> -- >> 2.16.1 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index 7e49fadee412..ef758f7337e9 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -779,9 +779,22 @@ clocks = <&pmu_system_controller 0>; clock-names = "xtal"; - port { - mhl_to_hdmi: endpoint { - remote-endpoint = <&hdmi_to_mhl>; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; + }; + + port@1 { + reg = <1>; + mhl_to_musb_con: endpoint { + remote-endpoint = <&musb_con_to_mhl>; + }; }; }; }; @@ -804,6 +817,18 @@ "usb-b-connector"; label = "micro-USB"; type = "micro"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@3 { + musb_con_to_mhl: endpoint { + remote-endpoint = <&mhl_to_musb_con>; + }; + }; + }; + }; }; };
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-)