wcn36xx: reduce verbosity of drivers messages

Message ID	20180217202510.13707-1-rfried@codeaurora.org (mailing list archive)
State	Changes Requested
Delegated to:	Kalle Valo
Headers	show Return-Path: <linux-wireless-owner@kernel.org> sender: rfried@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6458C602B8; Sat, 17 Feb 2018 20:25:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6458C602B8 From: Ramon Fried <rfried@codeaurora.org> To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Cc: Ramon Fried <rfried@codeaurora.org> Subject: [PATCH] wcn36xx: reduce verbosity of drivers messages Date: Sat, 17 Feb 2018 22:25:10 +0200 Message-Id: <20180217202510.13707-1-rfried@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk

Message ID

20180217202510.13707-1-rfried@codeaurora.org (mailing list archive)

State

Changes Requested

Delegated to:

Kalle Valo

Headers

DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6458C602B8
From: Ramon Fried <rfried@codeaurora.org>
To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org,
	linux-wireless@vger.kernel.org
Cc: Ramon Fried <rfried@codeaurora.org>
Subject: [PATCH] wcn36xx: reduce verbosity of drivers messages
Date: Sat, 17 Feb 2018 22:25:10 +0200
Message-Id: <20180217202510.13707-1-rfried@codeaurora.org>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Commit Message

Ramon Fried Feb. 17, 2018, 8:25 p.m. UTC

Whenever the WLAN interface is started the FW
version and caps are printed, this info should appear as
debug info.

Signed-off-by: Ramon Fried <rfried@codeaurora.org>
---
 drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
 drivers/net/wireless/ath/wcn36xx/smd.c  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Bjorn Andersson Feb. 19, 2018, 3:27 a.m. UTC | #1

On Sat 17 Feb 12:25 PST 2018, Ramon Fried wrote:

> Whenever the WLAN interface is started the FW
> version and caps are printed, this info should appear as
> debug info.
> 
> Signed-off-by: Ramon Fried <rfried@codeaurora.org>

Looks reasonable,

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

Kalle Valo Feb. 27, 2018, 8:26 a.m. UTC | #2

Ramon Fried <rfried@codeaurora.org> writes:

> Whenever the WLAN interface is started the FW
> version and caps are printed, this info should appear as
> debug info.
>
> Signed-off-by: Ramon Fried <rfried@codeaurora.org>
> ---
>  drivers/net/wireless/ath/wcn36xx/main.c | 2 +-
>  drivers/net/wireless/ath/wcn36xx/smd.c  | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index ab5be6d2c691..8c2654075eb8 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -261,7 +261,7 @@ static void wcn36xx_feat_caps_info(struct wcn36xx *wcn)
>  
>  	for (i = 0; i < MAX_FEATURE_SUPPORTED; i++) {
>  		if (get_feat_caps(wcn->fw_feat_caps, i))
> -			wcn36xx_info("FW Cap %s\n", wcn36xx_get_cap_name(i));
> +			wcn36xx_dbg(WCN36XX_DBG_MAC, "FW Cap %s\n", wcn36xx_get_cap_name(i));
>  	}
>  }
>  
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 2a4871ca9c72..7c4d19b041bc 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -409,10 +409,10 @@ static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len)
>  	wcn->fw_minor = rsp->start_rsp_params.version.minor;
>  	wcn->fw_major = rsp->start_rsp_params.version.major;
>  
> -	wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n",
> +	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware WLAN version '%s' and CRM version '%s'\n",
>  		     wcn->wlan_version, wcn->crm_version);
>  
> -	wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
> +	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
>  		     wcn->fw_major, wcn->fw_minor,
>  		     wcn->fw_version, wcn->fw_revision,
>  		     rsp->start_rsp_params.stations,

I think that printing this information, especially the firmware version,
is useful. Isn't there a better way to solve this, like print this only
once during the driver is loaded or during the first start() call?

Kalle Valo Feb. 27, 2018, 1:20 p.m. UTC | #3

Hi Ramon,

you dropped the mailing lists from CC, I'll add them back.

Ramon Fried <rfried@codeaurora.org> writes:

> On 2/27/2018 10:26 AM, Kalle Valo wrote:
>> Ramon Fried <rfried@codeaurora.org> writes:
>>
>>> --- a/drivers/net/wireless/ath/wcn36xx/main.c
>>> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
>>> @@ -261,7 +261,7 @@ static void wcn36xx_feat_caps_info(struct wcn36xx *wcn)
>>>  
>>>  	for (i = 0; i < MAX_FEATURE_SUPPORTED; i++) {
>>>  		if (get_feat_caps(wcn->fw_feat_caps, i))
>>> -			wcn36xx_info("FW Cap %s\n", wcn36xx_get_cap_name(i));
>>> +			wcn36xx_dbg(WCN36XX_DBG_MAC, "FW Cap %s\n", wcn36xx_get_cap_name(i));
>>>  	}
>>>  }
>>>  
>>> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
>>> index 2a4871ca9c72..7c4d19b041bc 100644
>>> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
>>> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
>>> @@ -409,10 +409,10 @@ static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len)
>>>  	wcn->fw_minor = rsp->start_rsp_params.version.minor;
>>>  	wcn->fw_major = rsp->start_rsp_params.version.major;
>>>  
>>> -	wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n",
>>> +	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware WLAN version '%s' and CRM version '%s'\n",
>>>  		     wcn->wlan_version, wcn->crm_version);
>>>  
>>> -	wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
>>> +	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
>>>  		     wcn->fw_major, wcn->fw_minor,
>>>  		     wcn->fw_version, wcn->fw_revision,
>>>  		     rsp->start_rsp_params.stations,
>>
>> I think that printing this information, especially the firmware version,
>> is useful. Isn't there a better way to solve this, like print this only
>> once during the driver is loaded or during the first start() call?
>
> I agree regarding the firmware version. I can fix it.

Good, thanks.

> the capabilities IMHO is really only relevant for debug and hackers
> who can turn debug on.

Yeah, makes sense.

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index ab5be6d2c691..8c2654075eb8 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -261,7 +261,7 @@  static void wcn36xx_feat_caps_info(struct wcn36xx *wcn)
 
 	for (i = 0; i < MAX_FEATURE_SUPPORTED; i++) {
 		if (get_feat_caps(wcn->fw_feat_caps, i))
-			wcn36xx_info("FW Cap %s\n", wcn36xx_get_cap_name(i));
+			wcn36xx_dbg(WCN36XX_DBG_MAC, "FW Cap %s\n", wcn36xx_get_cap_name(i));
 	}
 }
 
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 2a4871ca9c72..7c4d19b041bc 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -409,10 +409,10 @@  static int wcn36xx_smd_start_rsp(struct wcn36xx *wcn, void *buf, size_t len)
 	wcn->fw_minor = rsp->start_rsp_params.version.minor;
 	wcn->fw_major = rsp->start_rsp_params.version.major;
 
-	wcn36xx_info("firmware WLAN version '%s' and CRM version '%s'\n",
+	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware WLAN version '%s' and CRM version '%s'\n",
 		     wcn->wlan_version, wcn->crm_version);
 
-	wcn36xx_info("firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
+	wcn36xx_dbg(WCN36XX_DBG_HAL, "firmware API %u.%u.%u.%u, %u stations, %u bssids\n",
 		     wcn->fw_major, wcn->fw_minor,
 		     wcn->fw_version, wcn->fw_revision,
 		     rsp->start_rsp_params.stations,

wcn36xx: reduce verbosity of drivers messages

Commit Message

Comments

Patch