| Message ID | 1518100057-23234-6-git-send-email-amelie.delaunay@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Amelie, thanks for your patch. On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay <amelie.delaunay@st.com> wrote: > The joystick on stm32746g-eval uses gpios on MFX gpio expander. > > Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> (...) > + joystick { > + compatible = "gpio-keys"; > + #address-cells = <1>; > + #size-cells = <0>; > + button@1 { > + label = "JoySel"; > + linux,code = <KEY_ENTER>; > + gpios = <&mfxgpio 0 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>; > + }; As I think this should not all be handled by GPIO, the joystick on gpio-keys needs a pin control handle pointing back to pin control states on the respective pins in the pin control/GPIO driver, where it can set up these properties. For the individual lines the pushing and pulling flags should be removed. Yours, Linus Walleij
On 02/22/2018 02:52 PM, Linus Walleij wrote: > Hi Amelie, > > thanks for your patch. > > On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay <amelie.delaunay@st.com> wrote: > >> The joystick on stm32746g-eval uses gpios on MFX gpio expander. >> >> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> > (...) >> + joystick { >> + compatible = "gpio-keys"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + button@1 { >> + label = "JoySel"; >> + linux,code = <KEY_ENTER>; >> + gpios = <&mfxgpio 0 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>; >> + }; > > As I think this should not all be handled by GPIO, the joystick on > gpio-keys needs a pin control handle pointing back to pin control > states on the respective pins in the pin control/GPIO driver, > where it can set up these properties. > > For the individual lines the pushing and pulling flags should be > removed. > Sure! I keep this in mind, thanks! Regards, Amelie > Yours, > Linus Walleij >
diff --git a/arch/arm/boot/dts/stm32746g-eval.dts b/arch/arm/boot/dts/stm32746g-eval.dts index 99739f7..eb5f43b 100644 --- a/arch/arm/boot/dts/stm32746g-eval.dts +++ b/arch/arm/boot/dts/stm32746g-eval.dts @@ -43,6 +43,7 @@ /dts-v1/; #include "stm32f746.dtsi" #include <dt-bindings/input/input.h> +#include <dt-bindings/gpio/st-mfx-gpio.h> / { model = "STMicroelectronics STM32746g-EVAL board"; @@ -98,6 +99,36 @@ }; }; + joystick { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>; + button@1 { + label = "JoySel"; + linux,code = <KEY_ENTER>; + gpios = <&mfxgpio 0 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>; + }; + button@2 { + label = "JoyDown"; + linux,code = <KEY_DOWN>; + gpios = <&mfxgpio 1 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>; + }; + button@3 { + label = "JoyLeft"; + linux,code = <KEY_LEFT>; + gpios = <&mfxgpio 2 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>; + }; + button@4 { + label = "JoyRight"; + linux,code = <KEY_RIGHT>; + gpios = <&mfxgpio 3 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>; + }; + button@5 { + label = "JoyUp"; + linux,code = <KEY_UP>; + gpios = <&mfxgpio 4 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>; + }; + }; mmc_vcard: mmc_vcard { compatible = "regulator-fixed";
The joystick on stm32746g-eval uses gpios on MFX gpio expander. Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> --- arch/arm/boot/dts/stm32746g-eval.dts | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)