| Message ID | 20180226143912.GC22024@char.us.oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 26/02/2018 15:39, Konrad Rzeszutek Wilk wrote: > Perhaps both ideas should be done? The one Boris suggested (See below, not > compile tested yet), and also this one? Keep in mind that other hypervisor > offerings (say Xen, VMWare, etc) may have provided the correct microcode > or not and it would be good for the OS to be comfortable running under them. Yes, the patch below is definitely a good idea. Can you send it to Thomas and Ingo? Thanks, Paolo > From 36ea81363c38942057b006ccaf2ef26708a894bb Mon Sep 17 00:00:00 2001 > From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Date: Mon, 26 Feb 2018 09:35:01 -0500 > Subject: [PATCH] x86/spectre_v2: Don't check bad microcode versions when > running under hypervisors. > > As: > 1) We know they lie about the env anyhow (host mismatch) > 2) Even if the hypervisor (Xen, KVM, VMWare, etc) provided > a valid "correct" value, it all gets to be very murky > when migration happens (do you provide the "new" > microcode of the machine?). > > And in reality the cloud vendors are the ones that should make > sure that the microcode that is running is correct and we should > just sing lalalala and believe them. More "trust" (as the comment says in the code below) than believe. And perhaps the code would be more accurate if it said "hope" instead of "trust". :) Paolo > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > arch/x86/kernel/cpu/intel.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c > index d19e903214b4..87d044ce837f 100644 > --- a/arch/x86/kernel/cpu/intel.c > +++ b/arch/x86/kernel/cpu/intel.c > @@ -144,6 +144,13 @@ static bool bad_spectre_microcode(struct cpuinfo_x86 *c) > { > int i; > > + /* > + * We know that the hypervisor lie to us on the microcode version so > + * we may as well trust that it is running the correct version. > + */ > + if (boot_cpu_has(X86_FEATURE_HYPERVISOR)) > + return false; > + > for (i = 0; i < ARRAY_SIZE(spectre_bad_microcodes); i++) { > if (c->x86_model == spectre_bad_microcodes[i].model && > c->x86_stepping == spectre_bad_microcodes[i].stepping) >
On Mon, Feb 26, 2018 at 09:39:12AM -0500, Konrad Rzeszutek Wilk wrote: > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c > index d19e903214b4..87d044ce837f 100644 > --- a/arch/x86/kernel/cpu/intel.c > +++ b/arch/x86/kernel/cpu/intel.c > @@ -144,6 +144,13 @@ static bool bad_spectre_microcode(struct cpuinfo_x86 *c) > { > int i; > > + /* > + * We know that the hypervisor lie to us on the microcode version so > + * we may as well trust that it is running the correct version. > + */ > + if (boot_cpu_has(X86_FEATURE_HYPERVISOR)) I guess cpu_has(c, X86_FEATURE_HYPERVISOR) since we're passing a ptr to the current CPU. It boils down to the same thing in the end but this is bit nicer and besides the rest of the code uses cpu_has() too. Otherwise, yap, this looks like a good idea. Thx.
On Mon, Feb 26, 2018 at 08:37:11PM +0100, Borislav Petkov wrote: > On Mon, Feb 26, 2018 at 09:39:12AM -0500, Konrad Rzeszutek Wilk wrote: > > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c > > index d19e903214b4..87d044ce837f 100644 > > --- a/arch/x86/kernel/cpu/intel.c > > +++ b/arch/x86/kernel/cpu/intel.c > > @@ -144,6 +144,13 @@ static bool bad_spectre_microcode(struct cpuinfo_x86 *c) > > { > > int i; > > > > + /* > > + * We know that the hypervisor lie to us on the microcode version so > > + * we may as well trust that it is running the correct version. > > + */ > > + if (boot_cpu_has(X86_FEATURE_HYPERVISOR)) > > I guess > > cpu_has(c, X86_FEATURE_HYPERVISOR) > > since we're passing a ptr to the current CPU. Ah yes. Let me fix it up and repost.
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c index d19e903214b4..87d044ce837f 100644 --- a/arch/x86/kernel/cpu/intel.c +++ b/arch/x86/kernel/cpu/intel.c @@ -144,6 +144,13 @@ static bool bad_spectre_microcode(struct cpuinfo_x86 *c) { int i; + /* + * We know that the hypervisor lie to us on the microcode version so + * we may as well trust that it is running the correct version. + */ + if (boot_cpu_has(X86_FEATURE_HYPERVISOR)) + return false; + for (i = 0; i < ARRAY_SIZE(spectre_bad_microcodes); i++) { if (c->x86_model == spectre_bad_microcodes[i].model && c->x86_stepping == spectre_bad_microcodes[i].stepping)