| Message ID | 20180221085541.14556-5-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi Andrzej,
I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.16-rc2 next-20180221]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Andrzej-Hajda/dt-bindings-add-bindings-for-USB-physical-connector/20180221-185759
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi:864.1-2 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Wed, Feb 21, 2018 at 9:55 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: > OF graph describes MHL data lanes between MHL and respective USB > connector. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > v4: > - added missing reg property in connector's port node (Krzysztof) > --- > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 ++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 3 deletions(-) You have a duplicated '};' so kbuild complains so I assume there will be next iteration of this. Beside that I am okay with both, so I will take next version when your bindings and driver changes get acked/accepted. Best Regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 26.02.2018 16:21, Krzysztof Kozlowski wrote: > On Wed, Feb 21, 2018 at 9:55 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> v4: >> - added missing reg property in connector's port node (Krzysztof) >> --- >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 ++++++++++++++++++++-- >> 1 file changed, 29 insertions(+), 3 deletions(-) > You have a duplicated '};' so kbuild complains so I assume there will > be next iteration of this. Beside that I am okay with both, so I will > take next version when your bindings and driver changes get > acked/accepted. Yes, test robot already reported it, thanks for looking at it. I have postponed next iteration in case anything new is spotted, but since it is calm I will send it in few minutes. Regards Andrzej > > Best Regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 21, 2018 at 2:55 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: > OF graph describes MHL data lanes between MHL and respective USB > connector. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > v4: > - added missing reg property in connector's port node (Krzysztof) > --- > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 ++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > index f604f6b1a9c2..2ed506df94d0 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > @@ -817,9 +817,22 @@ > clocks = <&pmu_system_controller 0>; > clock-names = "xtal"; > > - port { > - mhl_to_hdmi: endpoint { > - remote-endpoint = <&hdmi_to_mhl>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + mhl_to_hdmi: endpoint { > + remote-endpoint = <&hdmi_to_mhl>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + mhl_to_musb_con: endpoint { > + remote-endpoint = <&musb_con_to_mhl>; > + }; These ports are mutually exclusive, right? If so, it should be 1 port with 2 endpoints. Ports should represent independent data flows. Something muxed or replicated (1 to many connection) should be be endpoints. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 27.02.2018 22:24, Rob Herring wrote: > On Wed, Feb 21, 2018 at 2:55 AM, Andrzej Hajda <a.hajda@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> --- >> v4: >> - added missing reg property in connector's port node (Krzysztof) >> --- >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 ++++++++++++++++++++-- >> 1 file changed, 29 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> index f604f6b1a9c2..2ed506df94d0 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -817,9 +817,22 @@ >> clocks = <&pmu_system_controller 0>; >> clock-names = "xtal"; >> >> - port { >> - mhl_to_hdmi: endpoint { >> - remote-endpoint = <&hdmi_to_mhl>; >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + mhl_to_hdmi: endpoint { >> + remote-endpoint = <&hdmi_to_mhl>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + mhl_to_musb_con: endpoint { >> + remote-endpoint = <&musb_con_to_mhl>; >> + }; > These ports are mutually exclusive, right? If so, it should be 1 port > with 2 endpoints. Ports should represent independent data flows. > Something muxed or replicated (1 to many connection) should be be > endpoints. No, this is HDMI -> MHL bridge, so port 0 is HDMI input, and port 1 is MHL output. Regards Andrzej > > Rob > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index f604f6b1a9c2..2ed506df94d0 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -817,9 +817,22 @@ clocks = <&pmu_system_controller 0>; clock-names = "xtal"; - port { - mhl_to_hdmi: endpoint { - remote-endpoint = <&hdmi_to_mhl>; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; + }; + + port@1 { + reg = <1>; + mhl_to_musb_con: endpoint { + remote-endpoint = <&musb_con_to_mhl>; + }; }; }; }; @@ -842,6 +855,19 @@ "usb-b-connector"; label = "micro-USB"; type = "micro"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@3 { + reg = <3>; + musb_con_to_mhl: endpoint { + remote-endpoint = <&mhl_to_musb_con>; + }; + }; + }; + }; }; };
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- v4: - added missing reg property in connector's port node (Krzysztof) --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 ++++++++++++++++++++-- 1 file changed, 29 insertions(+), 3 deletions(-)