diff mbox

mmc: ushc: Remove bogus check of usb_submit_urb

Message ID 1519522656-117862-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shawn Lin Feb. 25, 2018, 1:37 a.m. UTC
Not sure why it was there in the first place, but it's
obviously useless check, so let's remove it.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/mmc/host/ushc.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ulf Hansson Feb. 27, 2018, 11:28 a.m. UTC | #1
On 25 February 2018 at 02:37, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> Not sure why it was there in the first place, but it's
> obviously useless check, so let's remove it.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/ushc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
> index 1d84335..81dac17 100644
> --- a/drivers/mmc/host/ushc.c
> +++ b/drivers/mmc/host/ushc.c
> @@ -309,8 +309,6 @@ static void ushc_request(struct mmc_host *mmc, struct mmc_request *req)
>
>         /* Submit CSW. */
>         ret = usb_submit_urb(ushc->csw_urb, GFP_ATOMIC);
> -       if (ret < 0)
> -               goto out;
>
>  out:
>         spin_unlock_irqrestore(&ushc->lock, flags);
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index 1d84335..81dac17 100644
--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -309,8 +309,6 @@  static void ushc_request(struct mmc_host *mmc, struct mmc_request *req)
 
 	/* Submit CSW. */
 	ret = usb_submit_urb(ushc->csw_urb, GFP_ATOMIC);
-	if (ret < 0)
-		goto out;
 
 out:
 	spin_unlock_irqrestore(&ushc->lock, flags);