| Message ID | 76a05abd818c89032161585ba130511a5bd673f0.1519799691.git.jan.kiszka@siemens.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Wed, Feb 28, 2018 at 8:34 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > From: Jan Kiszka <jan.kiszka@siemens.com> > > Not sure if those two worked by design or just by chance so far. In any > case, it's at least cleaner and clearer to express this in a single > config statement. I would add a reference to the commit which brought that in the first place. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > arch/x86/Kconfig | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index eb7f43f23521..63e85e7da12e 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2641,8 +2641,9 @@ config PCI_DIRECT > depends on PCI && (X86_64 || (PCI_GODIRECT || PCI_GOANY || PCI_GOOLPC || PCI_GOMMCONFIG)) > > config PCI_MMCONFIG > - def_bool y > - depends on X86_32 && PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY) > + bool "Support mmconfig PCI config space access" if X86_64 > + default y > + depends on PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY || X86_64) Looking to the above context I would rather put it like depends on PCI && (ACPI || SFI) && (X86_64 || (PCI_GOANY || PCI_GOMMCONFIG))
On Wed, Feb 28, 2018 at 05:45:37PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2018 at 8:34 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > > From: Jan Kiszka <jan.kiszka@siemens.com> > > > > Not sure if those two worked by design or just by chance so far. In any > > case, it's at least cleaner and clearer to express this in a single > > config statement. It would be nice if this were a complete statement of what the patch does, but without the subject, it's not. E.g., as I'm composing this response in an editor window, I can't see the subject, so it seems incomplete. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > > --- > > arch/x86/Kconfig | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > index eb7f43f23521..63e85e7da12e 100644 > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -2641,8 +2641,9 @@ config PCI_DIRECT > > depends on PCI && (X86_64 || (PCI_GODIRECT || PCI_GOANY || PCI_GOOLPC || PCI_GOMMCONFIG)) > > > > config PCI_MMCONFIG > > - def_bool y > > - depends on X86_32 && PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY) > > + bool "Support mmconfig PCI config space access" if X86_64 > > + default y > > + depends on PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY || X86_64) > > Looking to the above context I would rather put it like > > depends on PCI && (ACPI || SFI) && (X86_64 || (PCI_GOANY || PCI_GOMMCONFIG)) The changelog doesn't point out any intended functional change, but I think both these proposals add some new configs that previously could not occur, e.g., CONFIG_X86_64=y CONFIG_SFI=y # CONFIG_ACPI is unset CONFIG_PCI_MMCONFIG=y If this is intended, the changelog should mention it.
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index eb7f43f23521..63e85e7da12e 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2641,8 +2641,9 @@ config PCI_DIRECT depends on PCI && (X86_64 || (PCI_GODIRECT || PCI_GOANY || PCI_GOOLPC || PCI_GOMMCONFIG)) config PCI_MMCONFIG - def_bool y - depends on X86_32 && PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY) + bool "Support mmconfig PCI config space access" if X86_64 + default y + depends on PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY || X86_64) config PCI_OLPC def_bool y @@ -2657,10 +2658,6 @@ config PCI_DOMAINS def_bool y depends on PCI -config PCI_MMCONFIG - bool "Support mmconfig PCI config space access" - depends on X86_64 && PCI && ACPI - config PCI_CNB20LE_QUIRK bool "Read CNB20LE Host Bridge Windows" if EXPERT depends on PCI