| Message ID | 1309563076-5050-2-git-send-email-lacombar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Fri, Jul 1, 2011 at 7:31 PM, Arnaud Lacombe <lacombar@gmail.com> wrote: > Cc: Steven Rostedt <srostedt@redhat.com> > --- > Makefile | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index afb8e0d..ea517fd 100644 > --- a/Makefile > +++ b/Makefile > @@ -22,6 +22,9 @@ LC_COLLATE=C > LC_NUMERIC=C > export LC_COLLATE LC_NUMERIC > > +# Export make goals > +export MAKECMDGOALS > + > # We are using a recursive build, so we need to do a little thinking > # to get the ordering right. > # Michal, before I send a new version of this serie, can you tell me your point of view on the export of MAKECMDGOALS (or KBUILD_MAKECMDGOALS) and Kconfig to the environment ? Thanks, - Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18.7.2011 21:05, Arnaud Lacombe wrote: > Hi, > > On Fri, Jul 1, 2011 at 7:31 PM, Arnaud Lacombe<lacombar@gmail.com> wrote: >> Cc: Steven Rostedt<srostedt@redhat.com> >> --- >> Makefile | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index afb8e0d..ea517fd 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -22,6 +22,9 @@ LC_COLLATE=C >> LC_NUMERIC=C >> export LC_COLLATE LC_NUMERIC >> >> +# Export make goals >> +export MAKECMDGOALS >> + >> # We are using a recursive build, so we need to do a little thinking >> # to get the ordering right. >> # > Michal, before I send a new version of this serie, can you tell me > your point of view on the export of MAKECMDGOALS (or > KBUILD_MAKECMDGOALS) and Kconfig to the environment ? A cleaner interface would IMO be to check the target in the makefile and pass a commandline option to streamline_config.pl, so that it's easier to run it manually. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Jul 19, 2011 at 10:07 AM, Michal Marek <mmarek@suse.cz> wrote: > On 18.7.2011 21:05, Arnaud Lacombe wrote: >> >> Hi, >> >> On Fri, Jul 1, 2011 at 7:31 PM, Arnaud Lacombe<lacombar@gmail.com> wrote: >>> >>> Cc: Steven Rostedt<srostedt@redhat.com> >>> --- >>> Makefile | 3 +++ >>> 1 files changed, 3 insertions(+), 0 deletions(-) >>> >>> diff --git a/Makefile b/Makefile >>> index afb8e0d..ea517fd 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -22,6 +22,9 @@ LC_COLLATE=C >>> LC_NUMERIC=C >>> export LC_COLLATE LC_NUMERIC >>> >>> +# Export make goals >>> +export MAKECMDGOALS >>> + >>> # We are using a recursive build, so we need to do a little thinking >>> # to get the ordering right. >>> # >> >> Michal, before I send a new version of this serie, can you tell me >> your point of view on the export of MAKECMDGOALS (or >> KBUILD_MAKECMDGOALS) and Kconfig to the environment ? > > A cleaner interface would IMO be to check the target in the makefile and > pass a commandline option to streamline_config.pl, so that it's easier to > run it manually. > thanks, I'll do the same for $(Kconfig), ie. pass it on the command line. - Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2011-07-19 at 16:07 +0200, Michal Marek wrote: > On 18.7.2011 21:05, Arnaud Lacombe wrote: > > Hi, > > > > On Fri, Jul 1, 2011 at 7:31 PM, Arnaud Lacombe<lacombar@gmail.com> wrote: > >> Cc: Steven Rostedt<srostedt@redhat.com> > >> --- > >> Makefile | 3 +++ > >> 1 files changed, 3 insertions(+), 0 deletions(-) > >> > >> diff --git a/Makefile b/Makefile > >> index afb8e0d..ea517fd 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -22,6 +22,9 @@ LC_COLLATE=C > >> LC_NUMERIC=C > >> export LC_COLLATE LC_NUMERIC > >> > >> +# Export make goals > >> +export MAKECMDGOALS > >> + > >> # We are using a recursive build, so we need to do a little thinking > >> # to get the ordering right. > >> # > > Michal, before I send a new version of this serie, can you tell me > > your point of view on the export of MAKECMDGOALS (or > > KBUILD_MAKECMDGOALS) and Kconfig to the environment ? > > A cleaner interface would IMO be to check the target in the makefile and > pass a commandline option to streamline_config.pl, so that it's easier > to run it manually. I agree with this. As I've been told by many people that they prefer to run streamline_config.pl directly. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Makefile b/Makefile index afb8e0d..ea517fd 100644 --- a/Makefile +++ b/Makefile @@ -22,6 +22,9 @@ LC_COLLATE=C LC_NUMERIC=C export LC_COLLATE LC_NUMERIC +# Export make goals +export MAKECMDGOALS + # We are using a recursive build, so we need to do a little thinking # to get the ordering right. #