| Message ID | 1520262025-21088-2-git-send-email-patrice.chotard@st.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Mon, Mar 5, 2018 at 9:00 AM, <patrice.chotard@st.com> wrote: > From: Patrice Chotard <patrice.chotard@st.com> > > Since dtc v1.4.6-9-gaadd0b65c987, aliases property name must > be lowercase only. > This allows to fix following warnings when compiling dtb > with W=1 option : I'm so glad to see fixes before the dtc update landed in the kernel tree! > arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' > arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' > arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' > arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' > > Signed-off-by: Patrice Chotard <patrice.chotard@st.com> > --- > arch/arm/boot/dts/stih407-b2120.dts | 4 ++-- > arch/arm/boot/dts/stih410-b2120.dts | 4 ++-- > arch/arm/boot/dts/stih410-b2260.dts | 4 ++-- > arch/arm/boot/dts/stih418-b2199.dts | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts > index c8ad905d0309..fa1186af6574 100644 > --- a/arch/arm/boot/dts/stih407-b2120.dts > +++ b/arch/arm/boot/dts/stih407-b2120.dts > @@ -14,7 +14,7 @@ > compatible = "st,stih407-b2120", "st,stih407"; > > chosen { > - bootargs = "console=ttyAS0,115200 clk_ignore_unused"; > + bootargs = "console=ttyas0,115200 clk_ignore_unused"; The kernel change for this is an ABI breakage both DT <-> kernel and kernel <-> userspace. Really, if you are okay with doing this, you should change it to ttySx IMO. > linux,stdout-path = &sbc_serial0; And since you have this, you don't even need the console praram. > }; > > @@ -24,7 +24,7 @@ > }; > > aliases { > - ttyAS0 = &sbc_serial0; > + ttyas0 = &sbc_serial0; The correct fix is use "serialN" for aliases. I have a check for only known alias names which would give a better warning, but David thought it was too restrictive. > ethernet0 = ðernet0; > }; >
Hi Rob On 03/05/2018 04:28 PM, Rob Herring wrote: > On Mon, Mar 5, 2018 at 9:00 AM, <patrice.chotard@st.com> wrote: >> From: Patrice Chotard <patrice.chotard@st.com> >> >> Since dtc v1.4.6-9-gaadd0b65c987, aliases property name must >> be lowercase only. >> This allows to fix following warnings when compiling dtb >> with W=1 option : > > I'm so glad to see fixes before the dtc update landed in the kernel tree! ;-) > >> arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' >> arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' >> arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' >> arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-' >> >> Signed-off-by: Patrice Chotard <patrice.chotard@st.com> >> --- >> arch/arm/boot/dts/stih407-b2120.dts | 4 ++-- >> arch/arm/boot/dts/stih410-b2120.dts | 4 ++-- >> arch/arm/boot/dts/stih410-b2260.dts | 4 ++-- >> arch/arm/boot/dts/stih418-b2199.dts | 4 ++-- >> 4 files changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts >> index c8ad905d0309..fa1186af6574 100644 >> --- a/arch/arm/boot/dts/stih407-b2120.dts >> +++ b/arch/arm/boot/dts/stih407-b2120.dts >> @@ -14,7 +14,7 @@ >> compatible = "st,stih407-b2120", "st,stih407"; >> >> chosen { >> - bootargs = "console=ttyAS0,115200 clk_ignore_unused"; >> + bootargs = "console=ttyas0,115200 clk_ignore_unused"; > > The kernel change for this is an ABI breakage both DT <-> kernel and > kernel <-> userspace. > > Really, if you are okay with doing this, you should change it to ttySx IMO. OK i will use serialN instead > >> linux,stdout-path = &sbc_serial0; > > And since you have this, you don't even need the console praram. Ok, i will remove stdout-path in an additional patch > >> }; >> >> @@ -24,7 +24,7 @@ >> }; >> >> aliases { >> - ttyAS0 = &sbc_serial0; >> + ttyas0 = &sbc_serial0; > > The correct fix is use "serialN" for aliases. Ok > > I have a check for only known alias names which would give a better > warning, but David thought it was too restrictive. > >> ethernet0 = ðernet0; >> }; >> Thanks Patrice
diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts index c8ad905d0309..fa1186af6574 100644 --- a/arch/arm/boot/dts/stih407-b2120.dts +++ b/arch/arm/boot/dts/stih407-b2120.dts @@ -14,7 +14,7 @@ compatible = "st,stih407-b2120", "st,stih407"; chosen { - bootargs = "console=ttyAS0,115200 clk_ignore_unused"; + bootargs = "console=ttyas0,115200 clk_ignore_unused"; linux,stdout-path = &sbc_serial0; }; @@ -24,7 +24,7 @@ }; aliases { - ttyAS0 = &sbc_serial0; + ttyas0 = &sbc_serial0; ethernet0 = ðernet0; }; diff --git a/arch/arm/boot/dts/stih410-b2120.dts b/arch/arm/boot/dts/stih410-b2120.dts index 9830be577433..00258212b6fb 100644 --- a/arch/arm/boot/dts/stih410-b2120.dts +++ b/arch/arm/boot/dts/stih410-b2120.dts @@ -14,7 +14,7 @@ compatible = "st,stih410-b2120", "st,stih410"; chosen { - bootargs = "console=ttyAS0,115200 clk_ignore_unused"; + bootargs = "console=ttyas0,115200 clk_ignore_unused"; linux,stdout-path = &sbc_serial0; }; @@ -24,7 +24,7 @@ }; aliases { - ttyAS0 = &sbc_serial0; + ttyas0 = &sbc_serial0; ethernet0 = ðernet0; }; diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts index c663b70c43a7..3d122c3a1ad6 100644 --- a/arch/arm/boot/dts/stih410-b2260.dts +++ b/arch/arm/boot/dts/stih410-b2260.dts @@ -15,7 +15,7 @@ compatible = "st,stih410-b2260", "st,stih410"; chosen { - bootargs = "console=ttyAS1,115200 clk_ignore_unused"; + bootargs = "console=ttyas1,115200 clk_ignore_unused"; linux,stdout-path = &uart1; }; @@ -25,7 +25,7 @@ }; aliases { - ttyAS1 = &uart1; + ttyas1 = &uart1; ethernet0 = ðernet0; }; diff --git a/arch/arm/boot/dts/stih418-b2199.dts b/arch/arm/boot/dts/stih418-b2199.dts index 4e6d915c85ff..8459a3766b7c 100644 --- a/arch/arm/boot/dts/stih418-b2199.dts +++ b/arch/arm/boot/dts/stih418-b2199.dts @@ -14,7 +14,7 @@ compatible = "st,stih418-b2199", "st,stih418"; chosen { - bootargs = "console=ttyAS0,115200 clk_ignore_unused"; + bootargs = "console=ttyas0,115200 clk_ignore_unused"; linux,stdout-path = &sbc_serial0; }; @@ -24,7 +24,7 @@ }; aliases { - ttyAS0 = &sbc_serial0; + ttyas0 = &sbc_serial0; ethernet0 = ðernet0; };