| Message ID | 1519856687-5568-3-git-send-email-luca@lucaceresoli.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi, I noticed a typo in the title: cantext -> context I will fix in v2. On 28/02/2018 23:24, Luca Ceresoli wrote: > Driver writers can benefit in knowing if/when callbacks are called in > interrupt context. But it is not completely obvious here, so document it. > > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Pawel Osciak <pawel@osciak.com> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > --- > include/media/videobuf2-core.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h > index f20000887d3c..f6818f732f34 100644 > --- a/include/media/videobuf2-core.h > +++ b/include/media/videobuf2-core.h > @@ -296,6 +296,9 @@ struct vb2_buffer { > /** > * struct vb2_ops - driver-specific callbacks. > * > + * These operations are not called from interrupt context except where > + * mentioned specifically. > + * > * @queue_setup: called from VIDIOC_REQBUFS() and VIDIOC_CREATE_BUFS() > * handlers before memory allocation. It can be called > * twice: if the original number of requested buffers >
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index f20000887d3c..f6818f732f34 100644 --- a/include/media/videobuf2-core.h +++ b/include/media/videobuf2-core.h @@ -296,6 +296,9 @@ struct vb2_buffer { /** * struct vb2_ops - driver-specific callbacks. * + * These operations are not called from interrupt context except where + * mentioned specifically. + * * @queue_setup: called from VIDIOC_REQBUFS() and VIDIOC_CREATE_BUFS() * handlers before memory allocation. It can be called * twice: if the original number of requested buffers
Driver writers can benefit in knowing if/when callbacks are called in interrupt context. But it is not completely obvious here, so document it. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Pawel Osciak <pawel@osciak.com> Cc: Marek Szyprowski <m.szyprowski@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> --- include/media/videobuf2-core.h | 3 +++ 1 file changed, 3 insertions(+)