| Message ID | 20180301152515.20940-3-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Mar 01, 2018 at 04:25:11PM +0100, Enric Balletbo i Serra wrote: > The extcon property is used to detect the cable-state but some boards > just connect the type-c phy to a regular USB-A connector without any > power-delivery and thus no controller reporting the cable-state. > So the extcon property is not really a required property, move it to be > optional instead. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > > Changes in v2: > - [2/6] Rewrite the justification as suggested by Heiko Stuebner. > > Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++ > 1 file changed, 2 insertions(+) And extcon should be deprecated IMO. Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Mar 7, 2018 at 11:34 AM, Rob Herring <robh@kernel.org> wrote: > On Thu, Mar 01, 2018 at 04:25:11PM +0100, Enric Balletbo i Serra wrote: >> The extcon property is used to detect the cable-state but some boards >> just connect the type-c phy to a regular USB-A connector without any >> power-delivery and thus no controller reporting the cable-state. >> So the extcon property is not really a required property, move it to be >> optional instead. >> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >> Reviewed-by: Heiko Stuebner <heiko@sntech.de> >> --- >> >> Changes in v2: >> - [2/6] Rewrite the justification as suggested by Heiko Stuebner. >> >> Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++ >> 1 file changed, 2 insertions(+) > > And extcon should be deprecated IMO. > > Reviewed-by: Rob Herring <robh@kernel.org> Hello Rob, I'm currently learning a bit about USB and extcon. Could you provide some background on why you think extcon should be deprecated? What do you propose we replace it with?
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt index 6ea867e3176f..a66f23a01129 100644 --- a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt @@ -14,6 +14,8 @@ Required properties: - resets : a list of phandle + reset specifier pairs - reset-names : string reset name, must be: "uphy", "uphy-pipe", "uphy-tcphy" + +Optional properties: - extcon : extcon specifier for the Power Delivery Note, there are 2 type-c phys for RK3399, and they are almost identical, except