| Message ID | 20180311162756.26950-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On (03/11/18 17:27), Colin King wrote: > Variable sg_off is assigned a value but it is never read, hence it is > redundant and can be removed. > Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/11/18 9:27 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Variable sg_off is assigned a value but it is never read, hence it is > redundant and can be removed. > > Cleans up clang warning: > net/rds/message.c:373:2: warning: Value stored to 'sg_off' is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > net/rds/message.c | 2 -- > 1 file changed, 2 deletions(-) > Thanks Colin !! Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Colin King <colin.king@canonical.com> Date: Sun, 11 Mar 2018 17:27:56 +0100 > From: Colin Ian King <colin.king@canonical.com> > > Variable sg_off is assigned a value but it is never read, hence it is > redundant and can be removed. > > Cleans up clang warning: > net/rds/message.c:373:2: warning: Value stored to 'sg_off' is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/message.c b/net/rds/message.c index 90dcdcfe9f62..9c41bdd9e444 100644 --- a/net/rds/message.c +++ b/net/rds/message.c @@ -357,7 +357,6 @@ struct rds_message *rds_message_map_pages(unsigned long *page_addrs, unsigned in int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from) { - unsigned long sg_off; struct scatterlist *sg; int ret = 0; int length = iov_iter_count(from); @@ -370,7 +369,6 @@ int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter *from) * now allocate and copy in the data payload. */ sg = rm->data.op_sg; - sg_off = 0; /* Dear gcc, sg->page will be null from kzalloc. */ info = kzalloc(sizeof(*info), GFP_KERNEL); if (!info)