| Message ID | 1520799995-26347-4-git-send-email-ykaneko0929@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
Hi Kaneko-san, On Sun, Mar 11, 2018 at 9:26 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -402,5 +402,36 @@ > #phy-cells = <0>; > status = "disabled"; > }; > + > + thermal: thermal@e61f0000 { According to the Hard User Manual rev. 0.80, the base address is e6190000? > + compatible = "renesas,thermal-r8a77995", > + "renesas,rcar-thermal"; I would drop the fallback property, cfr. my comments on the DT binding patch. > + reg = <0 0xe61f0000 0 0x10>, <0 0xe61f0100 0 0x38>; 0xe619... (twice) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, Thanks for your review. 2018-03-12 19:56 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: > Hi Kaneko-san, > > On Sun, Mar 11, 2018 at 9:26 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > Thanks for your patch! > >> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi >> @@ -402,5 +402,36 @@ >> #phy-cells = <0>; >> status = "disabled"; >> }; >> + >> + thermal: thermal@e61f0000 { > > According to the Hard User Manual rev. 0.80, the base address is e6190000? You are correct. I will update this patch to fix it. > >> + compatible = "renesas,thermal-r8a77995", >> + "renesas,rcar-thermal"; > > I would drop the fallback property, cfr. my comments on the DT binding > patch. Yes. I will do it. > >> + reg = <0 0xe61f0000 0 0x10>, <0 0xe61f0100 0 0x38>; > > 0xe619... (twice) I will fix it. Thanks, Kaneko > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index 788e3af..d1a5197 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi @@ -402,5 +402,36 @@ #phy-cells = <0>; status = "disabled"; }; + + thermal: thermal@e61f0000 { + compatible = "renesas,thermal-r8a77995", + "renesas,rcar-thermal"; + reg = <0 0xe61f0000 0 0x10>, <0 0xe61f0100 0 0x38>; + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 522>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 522>; + #thermal-sensor-cells = <0>; + }; + }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <250>; + polling-delay = <1000>; + thermal-sensors = <&thermal>; + + trips { + cpu-crit { + temperature = <120000>; + hysteresis = <2000>; + type = "critical"; + }; + }; + cooling-maps { + }; + }; }; };
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)