diff mbox

[v2,14/17,4/4] mfd: tps65910: Move an assignment in tps65910_sleepinit()

Message ID eb3c38d5-23c3-dcf0-3772-66b917326f0a@users.sourceforge.net (mailing list archive)
State New, archived
Headers show

Commit Message

SF Markus Elfring March 9, 2018, 4:42 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 9 Mar 2018 09:19:42 +0100

Move the assignment for the local variable "dev" so that its setting
will be performed after a configuration check by this function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---

v2:
Lee Jones requested a resend for this patch. The change was rebased
on source files from Linux next-20180308.

 drivers/mfd/tps65910.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lee Jones March 12, 2018, 8:57 a.m. UTC | #1 
On Fri, 09 Mar 2018, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 9 Mar 2018 09:19:42 +0100
> 
> Move the assignment for the local variable "dev" so that its setting
> will be performed after a configuration check by this function.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> 
> v2:
> Lee Jones requested a resend for this patch. The change was rebased
> on source files from Linux next-20180308.

Thanks.

What happened here: [PATCH v2 14/17 4/4]

How have you managed to insert 4 patches into the x/17 thread?

It shouldn't matter for reviewing purposes.  It just looks really
odd.

>  drivers/mfd/tps65910.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index 7e7d3d1642c6..bf16cbe6fd88 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -315,11 +315,11 @@ static int tps65910_sleepinit(struct tps65910 *tps65910,
>  	struct device *dev;
>  	int ret;
>  
> -	dev = tps65910->dev;
> -
>  	if (!pmic_pdata->en_dev_slp)
>  		return 0;
>  
> +	dev = tps65910->dev;
> +
>  	/* enabling SLEEP device state */
>  	ret = tps65910_reg_set_bits(tps65910, TPS65910_DEVCTRL,
>  				DEVCTRL_DEV_SLP_MASK);
SF Markus Elfring March 13, 2018, 7:14 a.m. UTC | #2 
> How have you managed to insert 4 patches into the x/17 thread?

I dared to group the desired patch series into dedicated mail threads.

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lee Jones March 13, 2018, 7:56 a.m. UTC | #3 
On Tue, 13 Mar 2018, SF Markus Elfring wrote:

> > How have you managed to insert 4 patches into the x/17 thread?
> 
> I dared to group the desired patch series into dedicated mail threads.

Interesting.  I've never seen that done before.
diff mbox

Patch

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 7e7d3d1642c6..bf16cbe6fd88 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -315,11 +315,11 @@  static int tps65910_sleepinit(struct tps65910 *tps65910,
 	struct device *dev;
 	int ret;
 
-	dev = tps65910->dev;
-
 	if (!pmic_pdata->en_dev_slp)
 		return 0;
 
+	dev = tps65910->dev;
+
 	/* enabling SLEEP device state */
 	ret = tps65910_reg_set_bits(tps65910, TPS65910_DEVCTRL,
 				DEVCTRL_DEV_SLP_MASK);