| Message ID | 20180306000043.GA1603@embeddedgus (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Mar 05, 2018 at 06:00:43PM -0600, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied, thank you. > --- > drivers/input/mouse/appletouch.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c > index 81a695d..032d279 100644 > --- a/drivers/input/mouse/appletouch.c > +++ b/drivers/input/mouse/appletouch.c > @@ -587,7 +587,7 @@ static void atp_complete_geyser_1_2(struct urb *urb) > /* Perform size detection, if not done already */ > if (unlikely(!dev->size_detect_done)) { > atp_detect_size(dev); > - dev->size_detect_done = 1; > + dev->size_detect_done = true; > goto exit; > } > } > @@ -813,7 +813,7 @@ static int atp_open(struct input_dev *input) > if (usb_submit_urb(dev->urb, GFP_ATOMIC)) > return -EIO; > > - dev->open = 1; > + dev->open = true; > return 0; > } > > @@ -823,7 +823,7 @@ static void atp_close(struct input_dev *input) > > usb_kill_urb(dev->urb); > cancel_work_sync(&dev->work); > - dev->open = 0; > + dev->open = false; > } > > static int atp_handle_geyser(struct atp *dev) > -- > 2.7.4 >
diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c index 81a695d..032d279 100644 --- a/drivers/input/mouse/appletouch.c +++ b/drivers/input/mouse/appletouch.c @@ -587,7 +587,7 @@ static void atp_complete_geyser_1_2(struct urb *urb) /* Perform size detection, if not done already */ if (unlikely(!dev->size_detect_done)) { atp_detect_size(dev); - dev->size_detect_done = 1; + dev->size_detect_done = true; goto exit; } } @@ -813,7 +813,7 @@ static int atp_open(struct input_dev *input) if (usb_submit_urb(dev->urb, GFP_ATOMIC)) return -EIO; - dev->open = 1; + dev->open = true; return 0; } @@ -823,7 +823,7 @@ static void atp_close(struct input_dev *input) usb_kill_urb(dev->urb); cancel_work_sync(&dev->work); - dev->open = 0; + dev->open = false; } static int atp_handle_geyser(struct atp *dev)
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/input/mouse/appletouch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)