Message ID | 20180315033504.12628-5-himanshu.madhani@cavium.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <linux-scsi-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B004C60291 for <patchwork-linux-scsi@patchwork.kernel.org>; Thu, 15 Mar 2018 03:35:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A2B73287AD for <patchwork-linux-scsi@patchwork.kernel.org>; Thu, 15 Mar 2018 03:35:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9782D28807; Thu, 15 Mar 2018 03:35:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C4BE287AD for <patchwork-linux-scsi@patchwork.kernel.org>; Thu, 15 Mar 2018 03:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbeCODfV (ORCPT <rfc822;patchwork-linux-scsi@patchwork.kernel.org>); Wed, 14 Mar 2018 23:35:21 -0400 Received: from mail-bn3nam01on0085.outbound.protection.outlook.com ([104.47.33.85]:35456 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751840AbeCODfQ (ORCPT <rfc822;linux-scsi@vger.kernel.org>); Wed, 14 Mar 2018 23:35:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eL68/k+ypT954/MgPPNdbwadztZxF2iyRqOTKkL9Mi0=; b=E0M1MkZP3OTyUi48AUT1DRmUxhrpm9i8G761cL+2/ZOCJcTfmSAbx+TmaGBagzogg9v8ZkIP+CCSQZK3w+V4yZQI/CnGNQ7lZrNasOXQAk+ujuFTaqQbSB38h7LU45oUtphpp3cEGmNpoCfeB220KxGPHQpAMShCqjauIEHZzqY= Received: from CO2PR07CA0076.namprd07.prod.outlook.com (2603:10b6:100::44) by SN1PR0701MB2094.namprd07.prod.outlook.com (2a01:111:e400:5309::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Thu, 15 Mar 2018 03:35:13 +0000 Received: from BY2FFO11OLC012.protection.gbl (2a01:111:f400:7c0c::164) by CO2PR07CA0076.outlook.office365.com (2603:10b6:100::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.588.14 via Frontend Transport; Thu, 15 Mar 2018 03:35:13 +0000 Authentication-Results: spf=fail (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; HansenPartnership.com; dkim=none (message not signed) header.d=none;HansenPartnership.com; dmarc=none action=none header.from=cavium.com; Received-SPF: Fail (protection.outlook.com: domain of cavium.com does not designate 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11OLC012.mail.protection.outlook.com (10.1.15.23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.527.18 via Frontend Transport; Thu, 15 Mar 2018 03:35:13 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 14 Mar 2018 20:35:06 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w2F3Z60n012679; Wed, 14 Mar 2018 20:35:06 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w2F3Z6Ew012678; Wed, 14 Mar 2018 20:35:06 -0700 From: Himanshu Madhani <himanshu.madhani@cavium.com> To: <linux-nvme@lists.infradead.org>, <hch@lst.de>, <sagi@grimberg.me>, <James.Bottomley@HansenPartnership.com>, <martin.petersen@oracle.com> CC: <himanshu.madhani@cavium.com>, <linux-scsi@vger.kernel.org> Subject: [PATCH v2 04/13] qla2xxx: Restore ZIO threshold setting Date: Wed, 14 Mar 2018 20:34:55 -0700 Message-ID: <20180315033504.12628-5-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180315033504.12628-1-himanshu.madhani@cavium.com> References: <20180315033504.12628-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(199004)(189003)(105606002)(76176011)(5660300001)(72206003)(87636003)(47776003)(305945005)(6666003)(2201001)(36756003)(1076002)(69596002)(356003)(16586007)(81156014)(51416003)(50226002)(50466002)(42186006)(106466001)(85426001)(186003)(478600001)(2906002)(80596001)(4326008)(8936002)(336012)(48376002)(316002)(81166006)(26005)(8676002)(110136005)(86362001)(2950100002)(54906003)(59450400001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB2094; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC012; 1:saqZeJq2HQDiOy8JU/NaeaXFpQH9SE8ZH7eSIXz2mDG52gFeIbrkBqBsMJnv97228/aFCOP6KoXQ84k4haSW0/oXKny7b2s+E099gprzHo0IPJtsJQlDoU47drAIgPmo X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60e7e06e-606f-4181-64b3-08d58a25c316 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:SN1PR0701MB2094; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 3:TXUOY38mLVR1UJKwBQCWjgux0H0WyPq+C/PSNGGDWSNhzJnSfWPzyPj9FpYuamzlEGlOqQp0J6h1uvQhb6Gz3tgp6dYanGumA+sd3VjrdFT+d06kl+fG8prohuvdUjGdKBaK+vydAVE9Nl2VKRsTBMiCXeEsReeVNxqtaStlId/8mA30kRN5krgIZ/yRd2t8Zr86KF5ZZGi8PKmIP7iofkBE65zjIMZh1AqSMpEkl0Z6DpD7kOQFnkovI8DgmT81aaLrnxd3qmIYIvu8WcRlLwSesyS/4Lqgmcypk+XJ+WEo42jqwgilskDDMvjiGIk20PYnCK2R0Szyzx8EycXnC2tGetLv36xuawlubVewty0=; 25:0PGUx5qpCdfP9ejWvRqWikIaAgVOarMp6CMvfGnk9DsTacsrV/c3YF2nv3MK6k0pF72OSYI4oP9cfSGKIx0iXg1yfTLNey+SdFfBcqeCZXHvMI4vfgXdX7D5t9/0CfHInPEUm+k9W/ycXnTK3bBwUxNkrZGeHTGmaYgQztjJJDw1RD9aFucMSuFcSHKY+Hx35WyMZV1Rv/3u9eA8T/OkAhBXD1WAHU7IzOpMvgwgP2BXVsFIKaYDWqV/vbQrmd9xLWrdgNE5+P1z6U3JUS71d3W2t0aH4w4sWnbXJYmGn8EuIJtTmNy0wethZagJ6TcFVAhFWyqatmRWZBYP631fKg== X-MS-TrafficTypeDiagnostic: SN1PR0701MB2094: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 31:YX1G79xs/5jqHgmfO+e6TyWrn0GgdPZ/Af9YgLgnJP41iMZI7vKl+ezPufhrlW344TlS6ECGiUgjKiq3+Kq203bJxz8GvDFny7X+EbDIkfBK8IyvEnzsYA5e/4GxQeZH+bwMV1f6EAujWoNeB9aCcfXTy4xNvDzoINZxPwoq2+qhHZleFu3XqacYuGUpQQUY4POaSnOzpXAvd3GMPDUW2IjqGF4IB+F0VfkdAJ6v1Go=; 20:cI2hp/UygzW9CYlEoO/71ShY9w0cOFnuoMGkIaRTXb6cC+AijuNjr+rPCqE6KpIXz4IoY9SEerMcd+bu0/3VP/zXxfyWj3hJcNq8ZwHPXXRyraUey7XdMK7btHbU7wFXvtEG/oB5o4eW6Ah7gfoKxLwzB3yAKZpc5RNN1xB7RGYoaDC5+ZDMc+l4rtxvCftBf6cUKEkIZgZ+NkJ6uG9dbddq+dmx3oug17rAf/musioKpkIH/mDJacu7GmC+vf8JWo9YHWpc3aapKM0vLu1vsPaKXMMSQRS3rpfsXVyanIOdlmppUROTXw9S7FNyOfufcqpnLtJnBWwQFzxPge1j+Dd2kDFJK4ZL7qG2M5HT1MQIr7TnwylBSViItrkrJi868IR1ZxX63HmLOBf676gTd6RqBWq2l4xi1OaRfasyqieCjBzedkl1WsVx8qPZVW1caUs4W8i2WqUqsx0UDVO7AoOJBlaqxzaCUNQqku5BI47gqCzYfDBC4ShBJnOTeyuk X-Microsoft-Antispam-PRVS: <SN1PR0701MB209451BA0397FB3101F1E9B9F5D00@SN1PR0701MB2094.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231221)(944501244)(52105095)(93006095)(93001095)(6041310)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:SN1PR0701MB2094; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0701MB2094; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 4:wbfG0FlJHkC2EpmWEMkMq9YVoZgiTz3O272lwF74JSkQdWCOvsCVKEe8m16dkOTHBmlmGYT8USjkMbKHVTHyz2WIR02xycz3MP1Alj63R5N+BtiZsclz9ClVVfcPIWqQE3yeGkZ14NsrONaCr9dk8USlP8KLFI6gAGMMuc34shhpk3HkYAAAcOLXN6kM2PNF0RnrmCQFUx1gcn2mKTzh7YjyY6rj5b0RZIl34SJCXnRD+bMs8T9gfz5cZiVxX5z9yfLkxrQa3aFtRpNBSOXtVw== X-Forefront-PRVS: 0612E553B4 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0701MB2094; 23:lbEi7+ShSLd2MMyl366KkbS7eVPcmjylrtSoDWN?= =?us-ascii?Q?eE7zmT/APCH+bfi6Mmb8V4j1pjNZRiz5U1Pvv1A1SOw5T3ZlnpCHduNxuyoJ?= =?us-ascii?Q?umfkJ043nSYW7wX+i+yJEs7xxnx7VDyxpSU5GxJOhQDYLy+QatBvTFWdrp1B?= =?us-ascii?Q?8jiFDL+Ttue1eHETh74G2Ue/hTMkt/Q8Qw9y23e5OzZ/X2Gm2+oD4JiFl8K6?= =?us-ascii?Q?ActBYgHIvPqs6uM29Ww42kSkKoJ39qKeVbxBI/rTl01oV21CJZ/LO79Dpd3u?= =?us-ascii?Q?zAABALXMkrJCN2/PxhP95rp8brzckl5ztxQbCxgY+WtcNGL2arDDN4uFkg6b?= =?us-ascii?Q?MhQm5JS8S7Z9UxgYwy2Rkr55c8XRT60vapG1AEuKOycy9E7MWXLFoeaoD5z2?= =?us-ascii?Q?ADS63454PlTbkSDXF76T1Q3hj3SbWyM1fIz7Gr+ALdB4wVS3xtPqeJqrfcSc?= =?us-ascii?Q?NtslnWTAZjfGoKvhm7pYkgotvyM290upGK2wYgH2oQDPOmRu4qltlRcWIBB6?= =?us-ascii?Q?7ABA+DIi0atIa7WoJ8D5MzaaoWb69bIBCUq7h1um2ypo4J4xYhGdjhrdpA3w?= =?us-ascii?Q?R7LvWa2K81HU4TJ5M1MHsvEpSGqcGqIoWxGS6ZUopXEKHbjbNem8vMEn3Il5?= =?us-ascii?Q?wHH8h5HNApjCSKPQr6cDsIAkSZAsvRQM7fjRqXn1IkPgpbDo/D638OgQA78m?= =?us-ascii?Q?ALFevPRQBXfMcEnquYSE9ksuMCUcVxYypnFjvo4dmOnOcZY/rlvg82m1FT7S?= =?us-ascii?Q?Quf+R1U0b3osbLd5bjQPmvNmT9NAqlsFaCi8lHzNJ+2vJ+aaZUqLSQc8awod?= =?us-ascii?Q?7iYz5IoRGUleJAiqTuJPxcrNcbmIjijFcM/TxD1T3jd860ekzbj9LsA8/ZdT?= =?us-ascii?Q?xPQWE//PFR9ScbtWLx1sMB8iHRsqN11f8t/t8oae27i+BEdi2vQqrj2MzCYm?= =?us-ascii?Q?6udw/BnY1NTI6yhhPQAy1YZqaFeV+MKZbRcjMxr3kJ2gMLx04ZCGxJnoMwwh?= =?us-ascii?Q?dBqty0b/W6WwA4IHSH2mc1qqcSZpOPRbR5fhJ+jMPmJkafLG9VFLbJj7oZ3J?= =?us-ascii?Q?fNpX4wFZWQu81UVhn73QsDY+vMLXq4rI/9ls0nOB8KBC7BDmlrorAZqj4GSl?= =?us-ascii?Q?m+YVIROLJ7kFjZup+wvjkdsPJboWFamHR?= X-Microsoft-Antispam-Message-Info: xfC797YLfgPQfQG5WYO73t7i3hTWQEoq1PrAu5eu95CeoMJRHn++uJEkmmFHkzZCLvEnUtxUlp6zmZnBwNMNSSswsOgjG16mdBA51HzSjN0+dD4iJN1LCAJUiygTk8mHQcr1JsgUYcfJs+GZ9HAuYHiYCkC84X60NAy0hI4Pggws3vehvX1j4T3Nc7ZO60Lz X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2094; 6:hF1hwYeFTaJAmysp29Jxoa+Rx7998zB/VyeFZwpu+54Rtm2r2x/jcNqnRgoR1AoyFjz9I2WEfGdDixUUyOjeD8qCpL9UoaOtQzrRIe5SfqLaFgkvCIxYAD7jeGwZKQZ4kGHaYJr61VUjnIcbRofxWpT4Dd1OYGDVG7vRlJOeQWHd3FpP0rsjosdFsT6i5hAXK/lkLkf78D0wIN900wAl9Z7w47LKG/7dQZZlqUPwB/IcKmGQyfEPNo5UR6rycYzxCc6T/hjCCMujU0FxSf+31IJ1HdqYtaXVyq7CtlVAo4oRXNoEwH04dOakWRjMvicjh7/HN9IUlt9sHUxiGAuv5+3CqVOqnx4ALspOZMyrMEE=; 5:qJ1HwavgZjdjYxyOi+zlp4W+iUQO74qrRhCMvcYOYiwlRq2MP168nSUDNbZ+PvOSASaQ4Mu2Kk6KxM754iDMHx8byBb2PQ3mHKUqBTAlu4Px/sqELV2JUoW+nAAKYZWIu6he5ZU2EEdkruFnFH2JSJTVEdHT+CjoXL8l29Vq/1Y=; 24:Qo1vGpJnmRoqKHpMgz27+O/U0Hu1nHKVjS9UqH+oVb7XgaDki8B78L/4Tocf6ikA6f+EFOYZWhCzoFH3caGr2TYkz6eFvyES3glojuaJzcg=; 7:XMfbe9BMTcRfqkHmGgkK0bVt+1H+lArS4IMQ+EdL6/J4sdjVyzTGXv4x6elbsje0an54COk6Ypb62i48S1GL4yvsPHO7yZfrFaj2lu0MK6PoOAiP6T3qBvw0i3JhT1oJzD3oRkQiW7ytCtMoGzLUdriju2iKWFp8s2LbWNHIJwTvOk0RK893CXBMBvly2TyOkiI8fnpaEiuaxHmCrErvwB/n1dxEN/waYxof6sL0igRc77WyzS/h78PIHJ9D6QqK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2018 03:35:13.2212 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60e7e06e-606f-4181-64b3-08d58a25c316 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB2094 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: <linux-scsi.vger.kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
I'd really appreciate a more verbose changelog. No only on this patch,
but in general.
Anyways,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index a8e81fc14c44..5ee447680ddd 100644 --- a/drivers/scsi/qla2xxx/qla_nvme.c +++ b/drivers/scsi/qla2xxx/qla_nvme.c @@ -464,11 +464,6 @@ static int qla2x00_start_nvme_mq(srb_t *sp) /* Set chip new ring index. */ WRT_REG_DWORD(req->req_q_in, req->ring_index); - /* Manage unprocessed RIO/ZIO commands in response queue. */ - if (vha->flags.process_response_queue && - rsp->ring_ptr->signature != RESPONSE_PROCESSED) - qla24xx_process_response_queue(vha, rsp); - queuing_error: spin_unlock_irqrestore(&qpair->qp_lock, flags); return rval;