| Message ID | 20180316023713.30323-1-honli@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
On 3/15/2018 10:37 PM, Honggang LI wrote: > From: Honggang Li <honli@redhat.com> > > commit f1b65df5a232 ("IB/mlx5: Add support for active_width and > active_speed in RoCE"). Before this patch applied, the mlx5_ib > driver set default active_width and active_speed to IB_WIDTH_4X > and IB_SPEED_QDR. > > When the RoCE port is down, the RoCE port did not negotiate the > active width with remote side. The active width is zero. If run > ibstat to require the port status, ibstat will panic as it read > invalid width from sys file. > > This patch restores the original behavior. > > Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE"). > Signed-off-by: Honggang Li <honli@redhat.com> Reviewed-by: Hal Rosenstock <hal@mellanox.com> > --- > drivers/infiniband/hw/mlx5/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c > index 033b6af90de9..a48e9730fab8 100644 > --- a/drivers/infiniband/hw/mlx5/main.c > +++ b/drivers/infiniband/hw/mlx5/main.c > @@ -388,6 +388,9 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num, > if (err) > goto out; > > + props->active_width = IB_WIDTH_4X; > + props->active_speed = IB_SPEED_QDR; > + > translate_eth_proto_oper(eth_prot_oper, &props->active_speed, > &props->active_width); > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/16/2018 4:59 PM, Hal Rosenstock wrote: > On 3/15/2018 10:37 PM, Honggang LI wrote: >> From: Honggang Li <honli@redhat.com> >> >> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and >> active_speed in RoCE"). Before this patch applied, the mlx5_ib >> driver set default active_width and active_speed to IB_WIDTH_4X >> and IB_SPEED_QDR. >> >> When the RoCE port is down, the RoCE port did not negotiate the >> active width with remote side. The active width is zero. If run >> ibstat to require the port status, ibstat will panic as it read >> invalid width from sys file. >> >> This patch restores the original behavior. >> >> Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE"). >> Signed-off-by: Honggang Li <honli@redhat.com> > Reviewed-by: Hal Rosenstock <hal@mellanox.com> Reviewed-by: Noa Osherovich <noaos@mellanox.com> > >> --- >> drivers/infiniband/hw/mlx5/main.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c >> index 033b6af90de9..a48e9730fab8 100644 >> --- a/drivers/infiniband/hw/mlx5/main.c >> +++ b/drivers/infiniband/hw/mlx5/main.c >> @@ -388,6 +388,9 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num, >> if (err) >> goto out; >> >> + props->active_width = IB_WIDTH_4X; >> + props->active_speed = IB_SPEED_QDR; >> + >> translate_eth_proto_oper(eth_prot_oper, &props->active_speed, >> &props->active_width); >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 16, 2018 at 10:37:13AM +0800, Honggang LI wrote: > From: Honggang Li <honli@redhat.com> > > commit f1b65df5a232 ("IB/mlx5: Add support for active_width and > active_speed in RoCE"). Before this patch applied, the mlx5_ib > driver set default active_width and active_speed to IB_WIDTH_4X > and IB_SPEED_QDR. > > When the RoCE port is down, the RoCE port did not negotiate the > active width with remote side. The active width is zero. If run > ibstat to require the port status, ibstat will panic as it read > invalid width from sys file. > > This patch restores the original behavior. > > Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed in RoCE"). > Signed-off-by: Honggang Li <honli@redhat.com> > Reviewed-by: Hal Rosenstock <hal@mellanox.com> > Reviewed-by: Noa Osherovich <noaos@mellanox.com> > drivers/infiniband/hw/mlx5/main.c | 3 +++ > 1 file changed, 3 insertions(+) Applied to for-next, thanks Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 033b6af90de9..a48e9730fab8 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -388,6 +388,9 @@ static int mlx5_query_port_roce(struct ib_device *device, u8 port_num, if (err) goto out; + props->active_width = IB_WIDTH_4X; + props->active_speed = IB_SPEED_QDR; + translate_eth_proto_oper(eth_prot_oper, &props->active_speed, &props->active_width);