| Message ID | 1520588080-31264-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Geert, Thanks for your patch. On 2018-03-09 10:34:40 +0100, Geert Uytterhoeven wrote: > According to the Devicetree Specification, "ok" is not a valid status. > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > For the checkpatch TODO list? > https://www.devicetree.org/ > > Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt > index 68c5c497b7fa5551..a19517e1c669eb35 100644 > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > @@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite video input) > ------------------------------------------------------------------- > > &i2c2 { > - status = "ok"; > + status = "okay"; > pinctrl-0 = <&i2c2_pins>; > pinctrl-names = "default"; > > @@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite video input) > pinctrl-0 = <&vin1_pins>; > pinctrl-names = "default"; > > - status = "ok"; > + status = "okay"; > > port { > #address-cells = <1>; > -- > 2.7.4 >
On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > According to the Devicetree Specification, "ok" is not a valid status. > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> There are a few other matches, too, it'd be nice to fix them as well: $ git grep 'status.*"ok"' -- Documentation/devicetree/bindings/ Documentation/devicetree/bindings/ata/apm-xgene.txt:- status : Shall be "ok" if enabled or "disabled" if disabled. Documentation/devicetree/bindings/display/hisilicon/dw-dsi.txt: status = "ok"; Documentation/devicetree/bindings/display/ti/ti,omap-dss.txt: status = "ok"; Documentation/devicetree/bindings/display/ti/ti,omap-dss.txt: status = "ok"; Documentation/devicetree/bindings/media/rcar_vin.txt: status = "ok"; Documentation/devicetree/bindings/media/rcar_vin.txt: status = "ok"; Documentation/devicetree/bindings/net/apm-xgene-enet.txt:- status: Should be "ok" or "disabled" for enabled/disabled. Default is "ok". Documentation/devicetree/bindings/net/apm-xgene-enet.txt: status = "ok"; Documentation/devicetree/bindings/net/apm-xgene-enet.txt: status = "ok"; Documentation/devicetree/bindings/pci/hisilicon-pcie.txt:- status: Either "ok" or "disabled". Documentation/devicetree/bindings/pci/xgene-pci.txt:- status: Either "ok" or "disabled". Documentation/devicetree/bindings/pci/xgene-pci.txt: status = "ok"; Documentation/devicetree/bindings/phy/apm-xgene-phy.txt:- status : Shall be "ok" if enabled or "disabled" if disabled.
On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > According to the Devicetree Specification, "ok" is not a valid status. Correct. > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > For the checkpatch TODO list? > https://www.devicetree.org/ > > Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt > index 68c5c497b7fa5551..a19517e1c669eb35 100644 > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > @@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite video input) > ------------------------------------------------------------------- > > &i2c2 { > - status = "ok"; > + status = "okay"; However, I prefer that status not be in examples as it applies to any node and the SoC/board split is not relevant to binding docs. I'd cleaned all these up except for the cases with SoC/board split. > pinctrl-0 = <&i2c2_pins>; > pinctrl-names = "default"; > > @@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite video input) > pinctrl-0 = <&vin1_pins>; > pinctrl-names = "default"; > > - status = "ok"; > + status = "okay"; > > port { > #address-cells = <1>; > -- > 2.7.4 >
On Sun, Mar 18, 2018 at 07:47:57AM -0500, Rob Herring wrote: > On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > > According to the Devicetree Specification, "ok" is not a valid status. > > Correct. > > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > For the checkpatch TODO list? > > https://www.devicetree.org/ > > > > Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt > > index 68c5c497b7fa5551..a19517e1c669eb35 100644 > > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > > @@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite video input) > > ------------------------------------------------------------------- > > > > &i2c2 { > > - status = "ok"; > > + status = "okay"; > > However, I prefer that status not be in examples as it applies to any > node and the SoC/board split is not relevant to binding docs. I'd > cleaned all these up except for the cases with SoC/board split. Hi Rob, I'm a little confused. This example is a board override for a node (implicitly) defined in the DT of an SoC. Could you clarify when the status should be omitted? > > > pinctrl-0 = <&i2c2_pins>; > > pinctrl-names = "default"; > > > > @@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite video input) > > pinctrl-0 = <&vin1_pins>; > > pinctrl-names = "default"; > > > > - status = "ok"; > > + status = "okay"; > > > > port { > > #address-cells = <1>; > > -- > > 2.7.4 > > >
diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt index 68c5c497b7fa5551..a19517e1c669eb35 100644 --- a/Documentation/devicetree/bindings/media/rcar_vin.txt +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt @@ -81,7 +81,7 @@ Board setup example for Gen2 platforms (vin1 composite video input) ------------------------------------------------------------------- &i2c2 { - status = "ok"; + status = "okay"; pinctrl-0 = <&i2c2_pins>; pinctrl-names = "default"; @@ -104,7 +104,7 @@ Board setup example for Gen2 platforms (vin1 composite video input) pinctrl-0 = <&vin1_pins>; pinctrl-names = "default"; - status = "ok"; + status = "okay"; port { #address-cells = <1>;
According to the Devicetree Specification, "ok" is not a valid status. Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- For the checkpatch TODO list? https://www.devicetree.org/ Documentation/devicetree/bindings/media/rcar_vin.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)