| Message ID | 1521336419-21289-1-git-send-email-stschake@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Mar 18, 2018 at 9:26 AM, Stefan Schake <stschake@gmail.com> wrote: > They were set for the static library but not the shared variant. > > Cc: John Stultz <john.stultz@linaro.org> > Signed-off-by: Stefan Schake <stschake@gmail.com> > --- > Android.mk | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Android.mk b/Android.mk > index 8611c5e..1b77c53 100644 > --- a/Android.mk > +++ b/Android.mk > @@ -53,7 +53,9 @@ LOCAL_MODULE := libdrm > > LOCAL_SRC_FILES := $(LIBDRM_FILES) > LOCAL_EXPORT_C_INCLUDE_DIRS := \ > - $(LOCAL_PATH)/include/drm > + $(LOCAL_PATH) \ > + $(LOCAL_PATH)/include/drm \ > + $(LOCAL_PATH)/android > > LOCAL_SHARED_LIBRARIES := \ > libcutils > -- I've validated with this along with your suggested change to my drm_hwcomposer patch, and it is building just fine. So I'm reworking my patch stack to include this. Acked-by: John Stultz <john.stultz@linaro.org> thanks -john
On 19 March 2018 at 08:12, John Stultz <john.stultz@linaro.org> wrote: > On Sun, Mar 18, 2018 at 9:26 AM, Stefan Schake <stschake@gmail.com> wrote: >> They were set for the static library but not the shared variant. >> >> Cc: John Stultz <john.stultz@linaro.org> >> Signed-off-by: Stefan Schake <stschake@gmail.com> >> --- >> Android.mk | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Android.mk b/Android.mk >> index 8611c5e..1b77c53 100644 >> --- a/Android.mk >> +++ b/Android.mk >> @@ -53,7 +53,9 @@ LOCAL_MODULE := libdrm >> >> LOCAL_SRC_FILES := $(LIBDRM_FILES) >> LOCAL_EXPORT_C_INCLUDE_DIRS := \ >> - $(LOCAL_PATH)/include/drm >> + $(LOCAL_PATH) \ >> + $(LOCAL_PATH)/include/drm \ >> + $(LOCAL_PATH)/android >> >> LOCAL_SHARED_LIBRARIES := \ >> libcutils >> -- > > I've validated with this along with your suggested change to my > drm_hwcomposer patch, and it is building just fine. So I'm reworking > my patch stack to include this. > > Acked-by: John Stultz <john.stultz@linaro.org> > Looks spot on - pushed to master. Thanks gents! -Emil
diff --git a/Android.mk b/Android.mk index 8611c5e..1b77c53 100644 --- a/Android.mk +++ b/Android.mk @@ -53,7 +53,9 @@ LOCAL_MODULE := libdrm LOCAL_SRC_FILES := $(LIBDRM_FILES) LOCAL_EXPORT_C_INCLUDE_DIRS := \ - $(LOCAL_PATH)/include/drm + $(LOCAL_PATH) \ + $(LOCAL_PATH)/include/drm \ + $(LOCAL_PATH)/android LOCAL_SHARED_LIBRARIES := \ libcutils
They were set for the static library but not the shared variant. Cc: John Stultz <john.stultz@linaro.org> Signed-off-by: Stefan Schake <stschake@gmail.com> --- Android.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)