diff mbox

scripts/decodetree: Fix insnmask not marked as global in main()

Message ID 20180319115846.9662-1-kbastian@mail.uni-paderborn.de (mailing list archive)
State New, archived
Headers show

Commit Message

Bastian Koppelmann March 19, 2018, 11:58 a.m. UTC 
if '-w 16' was given as a cmdline args a local copy of insnmask
is set and not the global one.

Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
 scripts/decodetree.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Richard Henderson March 20, 2018, 1:24 a.m. UTC | #1 
On 03/19/2018 07:58 PM, Bastian Koppelmann wrote:
> if '-w 16' was given as a cmdline args a local copy of insnmask
> is set and not the global one.
> 
> Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
Richard Henderson March 20, 2018, 4:03 a.m. UTC | #2 
On 03/20/2018 09:24 AM, Richard Henderson wrote:
> On 03/19/2018 07:58 PM, Bastian Koppelmann wrote:
>> if '-w 16' was given as a cmdline args a local copy of insnmask
>> is set and not the global one.
>>
>> Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
>> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I've applied this locally.  I'll wait until development opens to send a pull
for this, given than there are no in-tree users of this script for the release.


r~
diff mbox

Patch

diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 41301c84aa..277f9a9bba 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -972,6 +972,7 @@  def main():
     global input_file
     global insnwidth
     global insntype
+    global insnmask
 
     decode_function = 'decode'
     decode_scope = 'static '