| Message ID | 1521193500-4696-6-git-send-email-mgautam@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, Mar 16, 2018 at 03:14:58PM +0530, Manu Gautam wrote: > Update compatible strings for USB2 PHYs on sdm845. > There are two QUSB2 PHYs present on sdm845. Few PHY registers > programming is different for these PHYs related to electrical > parameters, otherwise both are same. Register locations are different or tuning values are different? For the latter, is that something that could be DT properties? > > Signed-off-by: Manu Gautam <mgautam@codeaurora.org> > --- > Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > index 42c9742..20deaeb 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > Required properties: > - compatible: compatible list, contains > "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. > + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY, > + "qcom,sdm845-1-qusb2-phy" for primary PHY on sdm845, > + "qcom,sdm845-2-qusb2-phy" for secondary PHY on sdm845. > > - reg: offset and length of the PHY register set. > - #phy-cells: must be 0. > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 3/18/2018 6:22 PM, Rob Herring wrote: > On Fri, Mar 16, 2018 at 03:14:58PM +0530, Manu Gautam wrote: >> Update compatible strings for USB2 PHYs on sdm845. >> There are two QUSB2 PHYs present on sdm845. Few PHY registers >> programming is different for these PHYs related to electrical >> parameters, otherwise both are same. > Register locations are different or tuning values are different? For the > latter, is that something that could be DT properties? There are only register values changes. Corresponding driver change: https://patchwork.kernel.org/patch/10286803/
Hi Manu, On 3/16/2018 3:14 PM, Manu Gautam wrote: > Update compatible strings for USB2 PHYs on sdm845. > There are two QUSB2 PHYs present on sdm845. Few PHY registers > programming is different for these PHYs related to electrical > parameters, otherwise both are same. > > Signed-off-by: Manu Gautam <mgautam@codeaurora.org> > --- > Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > index 42c9742..20deaeb 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > Required properties: > - compatible: compatible list, contains > "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. > + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY, > + "qcom,sdm845-1-qusb2-phy" for primary PHY on sdm845, > + "qcom,sdm845-2-qusb2-phy" for secondary PHY on sdm845. Thanks for the patch. "qcom,sdm845-1/2-qusb2-phy" gives an impression that it is different versions of SoC, and not like two numbers of phy. May be - "qcom,sdm845-qusb2-phy-1/2" Regards Vivek > > - reg: offset and length of the PHY register set. > - #phy-cells: must be 0. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 3/20/2018 3:53 PM, Vivek Gautam wrote: > Hi Manu, > > > On 3/16/2018 3:14 PM, Manu Gautam wrote: >> Update compatible strings for USB2 PHYs on sdm845. >> There are two QUSB2 PHYs present on sdm845. Few PHY registers >> programming is different for these PHYs related to electrical >> parameters, otherwise both are same. >> >> Signed-off-by: Manu Gautam <mgautam@codeaurora.org> >> --- >> Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> index 42c9742..20deaeb 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt >> @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. >> Required properties: >> - compatible: compatible list, contains >> "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, >> - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. >> + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY, >> + "qcom,sdm845-1-qusb2-phy" for primary PHY on sdm845, >> + "qcom,sdm845-2-qusb2-phy" for secondary PHY on sdm845. > > Thanks for the patch. > > "qcom,sdm845-1/2-qusb2-phy" gives an impression that it is different versions of SoC, > and not like two numbers of phy. > May be - "qcom,sdm845-qusb2-phy-1/2" I agree with that. Will update. > > Regards > Vivek > > >> - reg: offset and length of the PHY register set. >> - #phy-cells: must be 0. >
diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt index 42c9742..20deaeb 100644 --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. Required properties: - compatible: compatible list, contains "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY, + "qcom,sdm845-1-qusb2-phy" for primary PHY on sdm845, + "qcom,sdm845-2-qusb2-phy" for secondary PHY on sdm845. - reg: offset and length of the PHY register set. - #phy-cells: must be 0.
Update compatible strings for USB2 PHYs on sdm845. There are two QUSB2 PHYs present on sdm845. Few PHY registers programming is different for these PHYs related to electrical parameters, otherwise both are same. Signed-off-by: Manu Gautam <mgautam@codeaurora.org> --- Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)