| Message ID | 1521208314-4783-7-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
Hi Geert,
This essentially removes this commit
commit 1c8cb409491403036919dd1c6b45013dc8835a44
Author: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Wed Aug 3 13:45:46 2016 -0700
drivers/fpga/Kconfig: fix build failure
While building m32r allmodconfig the build is failing with the error:
ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
Xilinx Zynq FPGA is using DMA but there was no dependency while
building.
Link: http://lkml.kernel.org/r/1464346526-13913-1-git-send-email-sudipm.mukherjee@gmail.com
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Alan Tull <atull@opensource.altera.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Alan
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or PCI.
>
> Generic symbols and drivers without platform dependencies keep their
> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
> cannot work anyway.
>
> This simplifies the dependencies, and allows to improve compile-testing.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Mark Brown <broonie@kernel.org>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
> ---
> v2:
> - Add Reviewed-by, Acked-by,
> - Drop RFC state,
> - Split per subsystem.
> ---
> drivers/fpga/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index f47ef848bcd056d5..fd539132542e30ee 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -53,7 +53,6 @@ config FPGA_MGR_ALTERA_CVP
> config FPGA_MGR_ZYNQ_FPGA
> tristate "Xilinx Zynq FPGA"
> depends on ARCH_ZYNQ || COMPILE_TEST
> - depends on HAS_DMA
> help
> FPGA manager driver support for Xilinx Zynq FPGAs.
>
> --
> 2.7.4
>
Hi Alan, On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull <atull@kernel.org> wrote: > On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > This essentially removes this commit > > commit 1c8cb409491403036919dd1c6b45013dc8835a44 > Author: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > Date: Wed Aug 3 13:45:46 2016 -0700 > > drivers/fpga/Kconfig: fix build failure > > While building m32r allmodconfig the build is failing with the error: > > ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined! > > Xilinx Zynq FPGA is using DMA but there was no dependency while > building. > > Link: http://lkml.kernel.org/r/1464346526-13913-1-git-send-email-sudipm.mukherjee@gmail.com > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > Acked-by: Moritz Fischer <moritz.fischer@ettus.com> > Cc: Alan Tull <atull@opensource.altera.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Yes it does. The major change is that the first (core) series introduces all needed dummies to do successful compile-testing on NO_DMA=y platforms. >> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another >> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". >> In most cases this other symbol is an architecture or platform specific >> symbol, or PCI. >> >> Generic symbols and drivers without platform dependencies keep their >> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that >> cannot work anyway. >> >> This simplifies the dependencies, and allows to improve compile-testing. >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Reviewed-by: Mark Brown <broonie@kernel.org> >> Acked-by: Robin Murphy <robin.murphy@arm.com> Gr{oetje,eeting}s, Geert
On Tue, Mar 20, 2018 at 5:04 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: Hi Geert, > Hi Alan, > > On Mon, Mar 19, 2018 at 5:06 PM, Alan Tull <atull@kernel.org> wrote: >> On Fri, Mar 16, 2018 at 8:51 AM, Geert Uytterhoeven >> <geert@linux-m68k.org> wrote: >> This essentially removes this commit >> >> commit 1c8cb409491403036919dd1c6b45013dc8835a44 >> Author: Sudip Mukherjee <sudipm.mukherjee@gmail.com> >> Date: Wed Aug 3 13:45:46 2016 -0700 >> >> drivers/fpga/Kconfig: fix build failure >> >> While building m32r allmodconfig the build is failing with the error: >> >> ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined! >> >> Xilinx Zynq FPGA is using DMA but there was no dependency while >> building. >> >> Link: http://lkml.kernel.org/r/1464346526-13913-1-git-send-email-sudipm.mukherjee@gmail.com >> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> >> Acked-by: Moritz Fischer <moritz.fischer@ettus.com> >> Cc: Alan Tull <atull@opensource.altera.com> >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> >> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > > Yes it does. The major change is that the first (core) series introduces > all needed dummies to do successful compile-testing on NO_DMA=y platforms. OK yes, I looked at the first patch that does the fix. Looks good. Thanks for doing this. > >>> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another >>> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". >>> In most cases this other symbol is an architecture or platform specific >>> symbol, or PCI. >>> >>> Generic symbols and drivers without platform dependencies keep their >>> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that >>> cannot work anyway. >>> >>> This simplifies the dependencies, and allows to improve compile-testing. >>> >>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Reviewed-by: Mark Brown <broonie@kernel.org> >>> Acked-by: Robin Murphy <robin.murphy@arm.com> Acked-by: Alan Tull <atull@kernel.org> Regards, Alan > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index f47ef848bcd056d5..fd539132542e30ee 100644 --- a/drivers/fpga/Kconfig +++ b/drivers/fpga/Kconfig @@ -53,7 +53,6 @@ config FPGA_MGR_ALTERA_CVP config FPGA_MGR_ZYNQ_FPGA tristate "Xilinx Zynq FPGA" depends on ARCH_ZYNQ || COMPILE_TEST - depends on HAS_DMA help FPGA manager driver support for Xilinx Zynq FPGAs.