| Message ID | 20180326152711.7780-1-parkch98@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Mar 26, 2018 at 5:27 PM, Chanho Park <parkch98@gmail.com> wrote: > This patch adds a samsung_pin_dbg_show function to implement the > pin_dbg_show callback function which can be used to show pin > confuration values. Basically, it can show pin setting values by > accessing the "pins" node like below: > > $ cat pins > pin 0 (gpy7-0) CON(0x0) DAT(0x1) PUD(0x1) DRV(0x0) CON_PDN(0x0) PUD_PDN(0x0) > > Signed-off-by: Chanho Park <parkch98@gmail.com> > --- > drivers/pinctrl/samsung/pinctrl-samsung.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > index 336e88d7bdb9..bdec0cbd64f1 100644 > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > @@ -279,6 +279,30 @@ static int samsung_dt_node_to_map(struct pinctrl_dev *pctldev, > return 0; > } > > +#ifdef CONFIG_DEBUG_FS > +/* Forward declaration which can be used by samsung_pin_dbg_show */ > +static int samsung_pinconf_rw(struct pinctrl_dev *pctldev, unsigned int pin, > + unsigned long *config, bool set); > +static char *reg_names[] = {"CON", "DAT", "PUD", "DRV", "CON_PDN", "PUD_PDN"}; This should be static const char. Please also add an empty line here. > +static void samsung_pin_dbg_show(struct pinctrl_dev *pctldev, > + struct seq_file *s, unsigned int pin) > +{ > + enum pincfg_type cfg_type; > + unsigned long config; > + int ret; > + > + for (cfg_type = 0; cfg_type < PINCFG_TYPE_NUM; cfg_type++) { > + config = PINCFG_PACK(cfg_type, 0); > + ret = samsung_pinconf_rw(pctldev, pin, &config, false); Use samsung_pinconf_get(). > + if (ret == -EINVAL) if (ret < 0) Best regards, Krzysztof > + continue; > + > + seq_printf(s, " %s(0x%lx)", reg_names[cfg_type], > + PINCFG_UNPACK_VALUE(config)); > + } > +} > +#endif > + > /* list of pinctrl callbacks for the pinctrl core */ > static const struct pinctrl_ops samsung_pctrl_ops = { > .get_groups_count = samsung_get_group_count, > @@ -286,6 +310,9 @@ static const struct pinctrl_ops samsung_pctrl_ops = { > .get_group_pins = samsung_get_group_pins, > .dt_node_to_map = samsung_dt_node_to_map, > .dt_free_map = samsung_dt_free_map, > +#ifdef CONFIG_DEBUG_FS > + .pin_dbg_show = samsung_pin_dbg_show, > +#endif > }; > > /* check if the selector is a valid pin function selector */ > -- > 2.14.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Krzysztof, First of all, thanks for your review. On 03/27/2018 04:07 PM, Krzysztof Kozlowski wrote: > On Mon, Mar 26, 2018 at 5:27 PM, Chanho Park <parkch98@gmail.com> wrote: >> This patch adds a samsung_pin_dbg_show function to implement the >> pin_dbg_show callback function which can be used to show pin >> confuration values. Basically, it can show pin setting values by >> accessing the "pins" node like below: >> >> $ cat pins >> pin 0 (gpy7-0) CON(0x0) DAT(0x1) PUD(0x1) DRV(0x0) CON_PDN(0x0) PUD_PDN(0x0) >> >> Signed-off-by: Chanho Park <parkch98@gmail.com> >> --- >> drivers/pinctrl/samsung/pinctrl-samsung.c | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c >> index 336e88d7bdb9..bdec0cbd64f1 100644 >> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c >> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c >> @@ -279,6 +279,30 @@ static int samsung_dt_node_to_map(struct pinctrl_dev *pctldev, >> return 0; >> } >> >> +#ifdef CONFIG_DEBUG_FS >> +/* Forward declaration which can be used by samsung_pin_dbg_show */ >> +static int samsung_pinconf_rw(struct pinctrl_dev *pctldev, unsigned int pin, >> + unsigned long *config, bool set); >> +static char *reg_names[] = {"CON", "DAT", "PUD", "DRV", "CON_PDN", "PUD_PDN"}; > This should be static const char. Please also add an empty line here. Okay. I'll fix it and use samsung_pinconf_get forward declaration. > >> +static void samsung_pin_dbg_show(struct pinctrl_dev *pctldev, >> + struct seq_file *s, unsigned int pin) >> +{ >> + enum pincfg_type cfg_type; >> + unsigned long config; >> + int ret; >> + >> + for (cfg_type = 0; cfg_type < PINCFG_TYPE_NUM; cfg_type++) { >> + config = PINCFG_PACK(cfg_type, 0); >> + ret = samsung_pinconf_rw(pctldev, pin, &config, false); > Use samsung_pinconf_get(). > >> + if (ret == -EINVAL) > if (ret < 0) Okay. I'll apply this next patch. Best Regards, Chanho Park -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index 336e88d7bdb9..bdec0cbd64f1 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -279,6 +279,30 @@ static int samsung_dt_node_to_map(struct pinctrl_dev *pctldev, return 0; } +#ifdef CONFIG_DEBUG_FS +/* Forward declaration which can be used by samsung_pin_dbg_show */ +static int samsung_pinconf_rw(struct pinctrl_dev *pctldev, unsigned int pin, + unsigned long *config, bool set); +static char *reg_names[] = {"CON", "DAT", "PUD", "DRV", "CON_PDN", "PUD_PDN"}; +static void samsung_pin_dbg_show(struct pinctrl_dev *pctldev, + struct seq_file *s, unsigned int pin) +{ + enum pincfg_type cfg_type; + unsigned long config; + int ret; + + for (cfg_type = 0; cfg_type < PINCFG_TYPE_NUM; cfg_type++) { + config = PINCFG_PACK(cfg_type, 0); + ret = samsung_pinconf_rw(pctldev, pin, &config, false); + if (ret == -EINVAL) + continue; + + seq_printf(s, " %s(0x%lx)", reg_names[cfg_type], + PINCFG_UNPACK_VALUE(config)); + } +} +#endif + /* list of pinctrl callbacks for the pinctrl core */ static const struct pinctrl_ops samsung_pctrl_ops = { .get_groups_count = samsung_get_group_count, @@ -286,6 +310,9 @@ static const struct pinctrl_ops samsung_pctrl_ops = { .get_group_pins = samsung_get_group_pins, .dt_node_to_map = samsung_dt_node_to_map, .dt_free_map = samsung_dt_free_map, +#ifdef CONFIG_DEBUG_FS + .pin_dbg_show = samsung_pin_dbg_show, +#endif }; /* check if the selector is a valid pin function selector */
This patch adds a samsung_pin_dbg_show function to implement the pin_dbg_show callback function which can be used to show pin confuration values. Basically, it can show pin setting values by accessing the "pins" node like below: $ cat pins pin 0 (gpy7-0) CON(0x0) DAT(0x1) PUD(0x1) DRV(0x0) CON_PDN(0x0) PUD_PDN(0x0) Signed-off-by: Chanho Park <parkch98@gmail.com> --- drivers/pinctrl/samsung/pinctrl-samsung.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)