| Message ID | 20180330154420.6903-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7bdeac2e6f49c7632557fb4a5816932fd38e0942 |
| Headers | show |
On 30/03/2018 at 16:44:20 +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Trivial fix to spelling mistake in pr_debug message text > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > sound/soc/atmel/atmel_ssc_dai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index a1e2c5682dcd..1c7af0ca98ec 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -820,7 +820,7 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, > if (ret < 0) { > printk(KERN_WARNING > "atmel_ssc_dai: request_irq failure\n"); > - pr_debug("Atmel_ssc_dai: Stoping clock\n"); > + pr_debug("Atmel_ssc_dai: Stopping clock\n"); > clk_disable(ssc_p->ssc->clk); > return ret; > } > -- > 2.15.1 >
On 31/03/2018 at 10:54, Alexandre Belloni wrote: > On 30/03/2018 at 16:44:20 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Trivial fix to spelling mistake in pr_debug message text >> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> sound/soc/atmel/atmel_ssc_dai.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c >> index a1e2c5682dcd..1c7af0ca98ec 100644 >> --- a/sound/soc/atmel/atmel_ssc_dai.c >> +++ b/sound/soc/atmel/atmel_ssc_dai.c >> @@ -820,7 +820,7 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, >> if (ret < 0) { >> printk(KERN_WARNING >> "atmel_ssc_dai: request_irq failure\n"); >> - pr_debug("Atmel_ssc_dai: Stoping clock\n"); >> + pr_debug("Atmel_ssc_dai: Stopping clock\n"); >> clk_disable(ssc_p->ssc->clk); >> return ret; >> } >> -- >> 2.15.1 >> >
On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> Hello Colin, > Trivial fix to spelling mistake in pr_debug message text would you mind making this patch a bit less non-trivial and change pr_debug to dev_dbg dropping Atmel_ssc_dai prefix? Thank you. > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > sound/soc/atmel/atmel_ssc_dai.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index a1e2c5682dcd..1c7af0ca98ec 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -820,7 +820,7 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, > if (ret < 0) { > printk(KERN_WARNING > "atmel_ssc_dai: request_irq failure\n"); > - pr_debug("Atmel_ssc_dai: Stoping clock\n"); > + pr_debug("Atmel_ssc_dai: Stopping clock\n"); > clk_disable(ssc_p->ssc->clk); > return ret; > } > -- > 2.15.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote: > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > Hello Colin, > > > Trivial fix to spelling mistake in pr_debug message text > > would you mind making this patch a bit less non-trivial and > change pr_debug to dev_dbg dropping Atmel_ssc_dai prefix? > > Thank you. > Trivial patches should just be trivial instead of evolving into a thread that lasts for days. I sometimes write trivial clean up patches for things like: arch/x86/lib/csum-partial_64.c:97 do_csum() warn: inconsistent indenting 88 /* last up to 7 8byte blocks */ 89 count %= 8; 90 while (count) { 91 asm("addq %1,%0\n\t" 92 "adcq %2,%0\n" 93 : "=r" (result) 94 : "m" (*(unsigned long *)buff), 95 "r" (zero), "0" (result)); 96 --count; 97 buff += 8; 98 } Why is "buff += 8;" indented too far? And why does every line end in a space character? And I think about it for 10 minutes and then delete my patch because it's too much hassle to deal with for something small. regards, dan carpenter
On 04/04/18 11:24, Dan Carpenter wrote: > On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote: >> On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >> >> Hello Colin, >> >>> Trivial fix to spelling mistake in pr_debug message text >> >> would you mind making this patch a bit less non-trivial and >> change pr_debug to dev_dbg dropping Atmel_ssc_dai prefix? >> >> Thank you. >> > > Trivial patches should just be trivial instead of evolving into a thread > that lasts for days. Yep, this feels like this scenario for sure. > > I sometimes write trivial clean up patches for things like: > > arch/x86/lib/csum-partial_64.c:97 do_csum() warn: inconsistent indenting > 88 /* last up to 7 8byte blocks */ > 89 count %= 8; > 90 while (count) { > 91 asm("addq %1,%0\n\t" > 92 "adcq %2,%0\n" > 93 : "=r" (result) > 94 : "m" (*(unsigned long *)buff), > 95 "r" (zero), "0" (result)); > 96 --count; > 97 buff += 8; > 98 } > > Why is "buff += 8;" indented too far? And why does every line end in a > space character? And I think about it for 10 minutes and then delete my > patch because it's too much hassle to deal with for something small. Same here. Hence stuff never gets fixed. > > regards, > dan carpenter > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
On Wed, Apr 04, 2018 at 01:24:26PM +0300, Dan Carpenter wrote: > Trivial patches should just be trivial instead of evolving into a thread > that lasts for days. Indeed, and it's usually easier to just send a further trivial patch rather than just talk about it. > Why is "buff += 8;" indented too far? And why does every line end in a > space character? And I think about it for 10 minutes and then delete my > patch because it's too much hassle to deal with for something small. The other option is to just send it and not worry too much about it getting applied or not.
diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index a1e2c5682dcd..1c7af0ca98ec 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -820,7 +820,7 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, if (ret < 0) { printk(KERN_WARNING "atmel_ssc_dai: request_irq failure\n"); - pr_debug("Atmel_ssc_dai: Stoping clock\n"); + pr_debug("Atmel_ssc_dai: Stopping clock\n"); clk_disable(ssc_p->ssc->clk); return ret; }