| Message ID | b38ac7608bc8d7cba2a9b7178bd755fae0fc7c6b.1522766852.git.lorenzo.bianconi@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 2018-04-03 16:52, Lorenzo Bianconi wrote: > Remove unnecessary MT_TX_ALC_CFG_4 configuration since register value > has already set to 0 on 5GHz band > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> If I read the code correctly, I think it makes more sense to remove the previous initialization, in order to have the writes to that register grouped together. - Felix
> On 2018-04-03 16:52, Lorenzo Bianconi wrote: >> Remove unnecessary MT_TX_ALC_CFG_4 configuration since register value >> has already set to 0 on 5GHz band >> >> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > If I read the code correctly, I think it makes more sense to remove the > previous initialization, in order to have the writes to that register > grouped together. > > - Felix Ack, will do in v2 Regards, Lorenzo
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c index f28c55746cea..cbf185e9f707 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c @@ -294,7 +294,6 @@ mt76x2_phy_set_txpower_regs(struct mt76x2_dev *dev, enum nl80211_band band) } else { mt76_wr(dev, MT_TX0_RF_GAIN_CORR, 0x383c023c); mt76_wr(dev, MT_TX1_RF_GAIN_CORR, 0x24282e28); - mt76_wr(dev, MT_TX_ALC_CFG_4, 0); } } }
Remove unnecessary MT_TX_ALC_CFG_4 configuration since register value has already set to 0 on 5GHz band Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> --- drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 1 - 1 file changed, 1 deletion(-)