| Message ID | 20180404153818.26179-19-eric.engestrom@imgtec.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
You can ignore my comments on the first couple of patches if you like, I think the result is much nicer anyway. 1-19 are: Reviewed-by: Dylan Baker <dylan@pnwbakers.com> Quoting Eric Engestrom (2018-04-04 08:38:14) > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> > --- > meson.build | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/meson.build b/meson.build > index f3747736f5bed7c01143..f659c02bc82660d038cc 100644 > --- a/meson.build > +++ b/meson.build > @@ -80,6 +80,7 @@ foreach d : [ > ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())], > ['tegra', true, false], > ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())], > + ['etnaviv', true, false], > ] > driver = d[0] > require_atomics = d[1] > @@ -100,15 +101,6 @@ foreach d : [ > endif > endforeach > > -with_etnaviv = false > -_etnaviv = get_option('etnaviv') > -if _etnaviv == 'true' > - if not with_atomics > - error('libdrm_etnaviv requires atomics.') > - endif > - with_etnaviv = true > -endif > - > with_exynos = get_option('exynos') == 'true' > > # XXX: Aparently only freebsd and dragonfly bsd actually need this (and > -- > Cheers, > Eric >
diff --git a/meson.build b/meson.build index f3747736f5bed7c01143..f659c02bc82660d038cc 100644 --- a/meson.build +++ b/meson.build @@ -80,6 +80,7 @@ foreach d : [ ['freedreno', true, ['arm', 'aarch64'].contains(host_machine.cpu_family())], ['tegra', true, false], ['vc4', false, ['arm', 'aarch64'].contains(host_machine.cpu_family())], + ['etnaviv', true, false], ] driver = d[0] require_atomics = d[1] @@ -100,15 +101,6 @@ foreach d : [ endif endforeach -with_etnaviv = false -_etnaviv = get_option('etnaviv') -if _etnaviv == 'true' - if not with_atomics - error('libdrm_etnaviv requires atomics.') - endif - with_etnaviv = true -endif - with_exynos = get_option('exynos') == 'true' # XXX: Aparently only freebsd and dragonfly bsd actually need this (and
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> --- meson.build | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)