diff mbox

[2/5] arm64:dts:sdm845: Add support for GPU LLCC

Message ID 1521789591-28628-3-git-send-email-smasetty@codeaurora.org (mailing list archive)
State New, archived
Delegated to: Andy Gross
Headers show

Commit Message

Sharat Masetty March 23, 2018, 7:19 a.m. UTC
Add client side bindings required for the GPU to use the last level
system cache. Also add a register range in the GPU CX domain.

Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Jordan Crouse April 3, 2018, 9:22 p.m. UTC | #1
On Fri, Mar 23, 2018 at 12:49:48PM +0530, Sharat Masetty wrote:
> Add client side bindings required for the GPU to use the last level
> system cache. Also add a register range in the GPU CX domain.

Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>

Also, these should go the the devicetree lists for review (but maybe wait until
the other changes have gotten further through the process).

> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index eb0a1b2..7e2d938 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -887,8 +887,8 @@
>  		compatible = "qcom,adreno-630.2", "qcom,adreno";
>  		#stream-id-cells = <16>;
>  
> -		reg = <0x5000000 0x40000>;
> -		reg-names = "kgsl_3d0_reg_memory";
> +		reg = <0x5000000 0x40000>, <0x509e000 0x10>;
> +		reg-names = "kgsl_3d0_reg_memory", "cx_mem";
>  
>  		/*
>  		 * Look ma, no clocks! The GPU clocks and power are controlled
> @@ -898,6 +898,10 @@
>  		interrupts = <0 300 0>;
>  		interrupt-names = "kgsl_3d0_irq";
>  
> +		/* GPU related llc slices */
> +		cache-slice-names = "gpu", "gpuhtw";
> +		cache-slices = <&llcc 12>, <&llcc 11>;
> +
>  		iommus = <&kgsl_smmu 0>;
>  
>  		operating-points-v2 = <&gpu_opp_table>;
> -- 
> 1.9.1
> 
> _______________________________________________
> Freedreno mailing list
> Freedreno@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno
Sharat Masetty April 5, 2018, 5:20 a.m. UTC | #2
On 4/4/2018 2:52 AM, Jordan Crouse wrote:
> On Fri, Mar 23, 2018 at 12:49:48PM +0530, Sharat Masetty wrote:
>> Add client side bindings required for the GPU to use the last level
>> system cache. Also add a register range in the GPU CX domain.
> 
> Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
> 
> Also, these should go the the devicetree lists for review (but maybe wait until
> the other changes have gotten further through the process).

Thanks Jordan for the review and the reminder, I will send this specific 
patch out to the devicetree mailing list for review.

> 
>> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index eb0a1b2..7e2d938 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -887,8 +887,8 @@
>>   		compatible = "qcom,adreno-630.2", "qcom,adreno";
>>   		#stream-id-cells = <16>;
>>   
>> -		reg = <0x5000000 0x40000>;
>> -		reg-names = "kgsl_3d0_reg_memory";
>> +		reg = <0x5000000 0x40000>, <0x509e000 0x10>;
>> +		reg-names = "kgsl_3d0_reg_memory", "cx_mem";
>>   
>>   		/*
>>   		 * Look ma, no clocks! The GPU clocks and power are controlled
>> @@ -898,6 +898,10 @@
>>   		interrupts = <0 300 0>;
>>   		interrupt-names = "kgsl_3d0_irq";
>>   
>> +		/* GPU related llc slices */
>> +		cache-slice-names = "gpu", "gpuhtw";
>> +		cache-slices = <&llcc 12>, <&llcc 11>;
>> +
>>   		iommus = <&kgsl_smmu 0>;
>>   
>>   		operating-points-v2 = <&gpu_opp_table>;
>> -- 
>> 1.9.1
>>
>> _______________________________________________
>> Freedreno mailing list
>> Freedreno@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/freedreno
>
Vivek Gautam April 5, 2018, 6:52 a.m. UTC | #3
Hi Sharat,


On 3/23/2018 12:49 PM, Sharat Masetty wrote:
> Add client side bindings required for the GPU to use the last level
> system cache. Also add a register range in the GPU CX domain.
>
> Signed-off-by: Sharat Masetty <smasetty@codeaurora.org>
> ---
>   arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index eb0a1b2..7e2d938 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -887,8 +887,8 @@
>   		compatible = "qcom,adreno-630.2", "qcom,adreno";
>   		#stream-id-cells = <16>;
>   
> -		reg = <0x5000000 0x40000>;
> -		reg-names = "kgsl_3d0_reg_memory";
> +		reg = <0x5000000 0x40000>, <0x509e000 0x10>;
> +		reg-names = "kgsl_3d0_reg_memory", "cx_mem";
>   
>   		/*
>   		 * Look ma, no clocks! The GPU clocks and power are controlled
> @@ -898,6 +898,10 @@
>   		interrupts = <0 300 0>;
>   		interrupt-names = "kgsl_3d0_irq";
>   
> +		/* GPU related llc slices */
> +		cache-slice-names = "gpu", "gpuhtw";
> +		cache-slices = <&llcc 12>, <&llcc 11>;

Please add corresponding binding doc changes.

Best regards
Vivek

> +
>   		iommus = <&kgsl_smmu 0>;
>   
>   		operating-points-v2 = <&gpu_opp_table>;

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index eb0a1b2..7e2d938 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -887,8 +887,8 @@ 
 		compatible = "qcom,adreno-630.2", "qcom,adreno";
 		#stream-id-cells = <16>;
 
-		reg = <0x5000000 0x40000>;
-		reg-names = "kgsl_3d0_reg_memory";
+		reg = <0x5000000 0x40000>, <0x509e000 0x10>;
+		reg-names = "kgsl_3d0_reg_memory", "cx_mem";
 
 		/*
 		 * Look ma, no clocks! The GPU clocks and power are controlled
@@ -898,6 +898,10 @@ 
 		interrupts = <0 300 0>;
 		interrupt-names = "kgsl_3d0_irq";
 
+		/* GPU related llc slices */
+		cache-slice-names = "gpu", "gpuhtw";
+		cache-slices = <&llcc 12>, <&llcc 11>;
+
 		iommus = <&kgsl_smmu 0>;
 
 		operating-points-v2 = <&gpu_opp_table>;