| Message ID | 1522747141-8299-1-git-send-email-loic.poulain@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Hi Xiaowei, On 3 April 2018 at 11:19, Loic Poulain <loic.poulain@linaro.org> wrote: > As documented in the device-tree bindings (pci/kirin-pcie.txt) and > defined in existing device-tree (hi3660.dtsi), the reset gpio name > is 'reset-gpios'. However, driver looks for a 'reset-gpio' resource > which makes the driver probe fail. Fix this. > > Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver") > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Are you still maintaining this driver ? Binghui's email seems to be invalid now. Regards, Loic
It's a bug indeed, thank you very much for the patch. I think the patch is ok. -----邮件原件----- 发件人: Loic Poulain [mailto:loic.poulain@linaro.org] 发送时间: 2018年4月16日 19:35 收件人: songxiaowei <songxiaowei@hisilicon.com>; Wangbinghui <wangbinghui@hisilicon.com> 抄送: linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>; lorenzo.pieralisi@arm.com; Loic Poulain <loic.poulain@linaro.org>; Guodong Xu <guodong.xu@linaro.org> 主题: Re: [PATCH] PCI: kirin: Fix reset gpio name Hi Xiaowei, On 3 April 2018 at 11:19, Loic Poulain <loic.poulain@linaro.org> wrote: > As documented in the device-tree bindings (pci/kirin-pcie.txt) and > defined in existing device-tree (hi3660.dtsi), the reset gpio name is > 'reset-gpios'. However, driver looks for a 'reset-gpio' resource which > makes the driver probe fail. Fix this. > > Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe > controller driver") > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Are you still maintaining this driver ? Binghui's email seems to be invalid now. Regards, Loic
On Mon, Apr 16, 2018 at 11:48:52AM +0000, songxiaowei wrote: > It's a bug indeed, thank you very much for the patch. I think the > patch is ok. Is this an ACK ? Please provide one if you want me to merge this fix. Lorenzo > -----邮件原件----- > 发件人: Loic Poulain [mailto:loic.poulain@linaro.org] > 发送时间: 2018年4月16日 19:35 > 收件人: songxiaowei <songxiaowei@hisilicon.com>; Wangbinghui <wangbinghui@hisilicon.com> > 抄送: linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>; lorenzo.pieralisi@arm.com; Loic Poulain <loic.poulain@linaro.org>; Guodong Xu <guodong.xu@linaro.org> > 主题: Re: [PATCH] PCI: kirin: Fix reset gpio name > > Hi Xiaowei, > > On 3 April 2018 at 11:19, Loic Poulain <loic.poulain@linaro.org> wrote: > > As documented in the device-tree bindings (pci/kirin-pcie.txt) and > > defined in existing device-tree (hi3660.dtsi), the reset gpio name is > > 'reset-gpios'. However, driver looks for a 'reset-gpio' resource which > > makes the driver probe fail. Fix this. > > > > Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe > > controller driver") > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > > Are you still maintaining this driver ? Binghui's email seems to be invalid now. > > Regards, > Loic
Acked-by: Xiaowei Song <songxiaowei@hisilicon.com> -----邮件原件----- 发件人: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] 发送时间: 2018年4月16日 21:49 收件人: songxiaowei <songxiaowei@hisilicon.com> 抄送: Loic Poulain <loic.poulain@linaro.org>; Wangbinghui <wangbinghui@hisilicon.com>; linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>; Guodong Xu <guodong.xu@linaro.org> 主题: Re: 答复: [PATCH] PCI: kirin: Fix reset gpio name On Mon, Apr 16, 2018 at 11:48:52AM +0000, songxiaowei wrote: > It's a bug indeed, thank you very much for the patch. I think the > patch is ok. Is this an ACK ? Please provide one if you want me to merge this fix. Lorenzo > -----邮件原件----- > 发件人: Loic Poulain [mailto:loic.poulain@linaro.org] > 发送时间: 2018年4月16日 19:35 > 收件人: songxiaowei <songxiaowei@hisilicon.com>; Wangbinghui > <wangbinghui@hisilicon.com> > 抄送: linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>; > lorenzo.pieralisi@arm.com; Loic Poulain <loic.poulain@linaro.org>; > Guodong Xu <guodong.xu@linaro.org> > 主题: Re: [PATCH] PCI: kirin: Fix reset gpio name > > Hi Xiaowei, > > On 3 April 2018 at 11:19, Loic Poulain <loic.poulain@linaro.org> wrote: > > As documented in the device-tree bindings (pci/kirin-pcie.txt) and > > defined in existing device-tree (hi3660.dtsi), the reset gpio name > > is 'reset-gpios'. However, driver looks for a 'reset-gpio' resource > > which makes the driver probe fail. Fix this. > > > > Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe > > controller driver") > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > > Are you still maintaining this driver ? Binghui's email seems to be invalid now. > > Regards, > Loic
diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c index dc3033c..efc317e 100644 --- a/drivers/pci/dwc/pcie-kirin.c +++ b/drivers/pci/dwc/pcie-kirin.c @@ -490,7 +490,7 @@ static int kirin_pcie_probe(struct platform_device *pdev) return ret; kirin_pcie->gpio_id_reset = of_get_named_gpio(dev->of_node, - "reset-gpio", 0); + "reset-gpios", 0); if (kirin_pcie->gpio_id_reset < 0) return -ENODEV;
As documented in the device-tree bindings (pci/kirin-pcie.txt) and defined in existing device-tree (hi3660.dtsi), the reset gpio name is 'reset-gpios'. However, driver looks for a 'reset-gpio' resource which makes the driver probe fail. Fix this. Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver") Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- drivers/pci/dwc/pcie-kirin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)