| Message ID | aa0dd9f7-3475-c2b3-8d5c-032a7ad72fe9@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Apr 16, 2018 at 06:51:50PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix build errors when INFINIBAND_USER_ACCESS=m and MLX5_INFINIBAND=y. > The build error occurs when the mlx5 driver code attempts to use > USER_ACCESS interfaces, which are built as a loadable module. > > Fixes these build errors: > > drivers/infiniband/hw/mlx5/main.o: In function `populate_specs_root': > ../drivers/infiniband/hw/mlx5/main.c:4982: undefined reference to `uverbs_default_get_objects' > ../drivers/infiniband/hw/mlx5/main.c:4994: undefined reference to `uverbs_alloc_spec_tree' > drivers/infiniband/hw/mlx5/main.o: In function `depopulate_specs_root': > ../drivers/infiniband/hw/mlx5/main.c:5001: undefined reference to `uverbs_free_spec_tree' > > Build-tested with multiple config combinations. > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Matan Barak <matanb@mellanox.com> > Cc: Jason Gunthorpe <jgg@mellanox.com> > Cc: Leon Romanovsky <leonro@mellanox.com> > Cc: Doug Ledford <dledford@redhat.com> > Cc: linux-rdma@vger.kernel.org > Cc: stable@vger.kernel.org # reported against 4.16 > --- > v2: allow building mxl5 even when INFINIBAND_USER_ACCESS is disabled. > > drivers/infiniband/hw/mlx5/Kconfig | 1 + > 1 file changed, 1 insertion(+) I added a Fixes: 8c84660bb437 ("IB/mlx5: Initialize the parsing tree root without the help of uverbs") Applied to for-rc thanks Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- lnx-417-rc1.orig/drivers/infiniband/hw/mlx5/Kconfig +++ lnx-417-rc1/drivers/infiniband/hw/mlx5/Kconfig @@ -1,6 +1,7 @@ config MLX5_INFINIBAND tristate "Mellanox Connect-IB HCA support" depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE + depends on INFINIBAND_USER_ACCESS || INFINIBAND_USER_ACCESS=n ---help--- This driver provides low-level InfiniBand support for Mellanox Connect-IB PCI Express host channel adapters (HCAs).