diff mbox

[1/2] ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags

Message ID 1524115745-7868-1-git-send-email-hui.wang@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hui Wang April 19, 2018, 5:29 a.m. UTC
Otherwise, the pin will be regarded as microphone, and the jack name
is "Mic Phantom", it is always on in the pulseaudio even nothing is
plugged into the jack. So the UI is confusing to users since the
microphone always shows up in the UI even there is no microphone
plugged.

After adding this flag, the jack name is "Headset Mic Phantom", then
the pulseaudio can handle its detection correctly.

Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Takashi Iwai April 19, 2018, 9:46 a.m. UTC | #1
On Thu, 19 Apr 2018 07:29:04 +0200,
Hui Wang wrote:
> 
> Otherwise, the pin will be regarded as microphone, and the jack name
> is "Mic Phantom", it is always on in the pulseaudio even nothing is
> plugged into the jack. So the UI is confusing to users since the
> microphone always shows up in the UI even there is no microphone
> plugged.
> 
> After adding this flag, the jack name is "Headset Mic Phantom", then
> the pulseaudio can handle its detection correctly.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Applied now.
But at the next time, please put "Fixes:" tag pointing to the commit
that introduced the problem.  In this case, it was f0ba9d699e5c.


thanks,

Takashi
Hui Wang April 19, 2018, 10:54 a.m. UTC | #2
On 2018年04月19日 17:46, Takashi Iwai wrote:
> On Thu, 19 Apr 2018 07:29:04 +0200,
> Hui Wang wrote:
>> Otherwise, the pin will be regarded as microphone, and the jack name
>> is "Mic Phantom", it is always on in the pulseaudio even nothing is
>> plugged into the jack. So the UI is confusing to users since the
>> microphone always shows up in the UI even there is no microphone
>> plugged.
>>
>> After adding this flag, the jack name is "Headset Mic Phantom", then
>> the pulseaudio can handle its detection correctly.
>>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Applied now.
> But at the next time, please put "Fixes:" tag pointing to the commit
> that introduced the problem.  In this case, it was f0ba9d699e5c.
Got it. Thanks.

>
> thanks,
>
> Takashi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
diff mbox

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index aef1f52..c3b63b7 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6370,6 +6370,8 @@  static const struct hda_fixup alc269_fixups[] = {
 			{ 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */
 			{ }
 		},
+		.chained = true,
+		.chain_id = ALC269_FIXUP_HEADSET_MIC
 	},
 };