| Message ID | 20180423152907.5113-1-yixun.lan@amlogic.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, 23 Apr 2018, Yixun Lan wrote: > This fix invalid SPDX license indentifier, also move it to > first top line according to documentation. > > Link: https://lkml.org/lkml/2018/4/22/713 Please do not use lkml.org links. lkml.org is not always usable. Use; https://lkml.kernel.org/r/$MESSAGE-ID instead. So this would be https://lkml.kernel.org/r/alpine.DEB.2.21.1804222108120.6136@nanos.tec.linutronix.de The reason is that kernel.org is very likely there as long as the kernel exists, but random archives can vanish, change their URL, etc. The above address is a redirector to the marc archive, but if that vanishes or stops working the redirector can point to some other working archive. > Fixes: c16292578ffa ("dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller") > Reported-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> > --- > include/dt-bindings/reset/amlogic,meson-axg-reset.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/dt-bindings/reset/amlogic,meson-axg-reset.h b/include/dt-bindings/reset/amlogic,meson-axg-reset.h > index ad6f55dabd6d..4a8e52f68fb7 100644 > --- a/include/dt-bindings/reset/amlogic,meson-axg-reset.h > +++ b/include/dt-bindings/reset/amlogic,meson-axg-reset.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Hi Thomas On 04/23/18 15:45, Thomas Gleixner wrote: > On Mon, 23 Apr 2018, Yixun Lan wrote: > >> This fix invalid SPDX license indentifier, also move it to >> first top line according to documentation. >> >> Link: https://lkml.org/lkml/2018/4/22/713 > > Please do not use lkml.org links. lkml.org is not always usable. Use; > > https://lkml.kernel.org/r/$MESSAGE-ID > > instead. So this would be > > https://lkml.kernel.org/r/alpine.DEB.2.21.1804222108120.6136@nanos.tec.linutronix.de > > The reason is that kernel.org is very likely there as long as the kernel > exists, but random archives can vanish, change their URL, etc. The above > address is a redirector to the marc archive, but if that vanishes or stops > working the redirector can point to some other working archive. > oh, never know the difference, thanks for the info >> Fixes: c16292578ffa ("dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller") >> Reported-by: Thomas Gleixner <tglx@linutronix.de> >> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> >> --- >> include/dt-bindings/reset/amlogic,meson-axg-reset.h | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/include/dt-bindings/reset/amlogic,meson-axg-reset.h b/include/dt-bindings/reset/amlogic,meson-axg-reset.h >> index ad6f55dabd6d..4a8e52f68fb7 100644 >> --- a/include/dt-bindings/reset/amlogic,meson-axg-reset.h >> +++ b/include/dt-bindings/reset/amlogic,meson-axg-reset.h >> @@ -1,3 +1,4 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ > > Reviewed-by: Thomas Gleixner <tglx@linutronix.de> > thanks, I'll update Yixun
diff --git a/include/dt-bindings/reset/amlogic,meson-axg-reset.h b/include/dt-bindings/reset/amlogic,meson-axg-reset.h index ad6f55dabd6d..4a8e52f68fb7 100644 --- a/include/dt-bindings/reset/amlogic,meson-axg-reset.h +++ b/include/dt-bindings/reset/amlogic,meson-axg-reset.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ /* * * Copyright (c) 2016 BayLibre, SAS. @@ -5,8 +6,6 @@ * * Copyright (c) 2017 Amlogic, inc. * Author: Yixun Lan <yixun.lan@amlogic.com> - * - * SPDX-License-Identifier: (GPL-2.0+ OR BSD) */ #ifndef _DT_BINDINGS_AMLOGIC_MESON_AXG_RESET_H
This fix invalid SPDX license indentifier, also move it to first top line according to documentation. Link: https://lkml.org/lkml/2018/4/22/713 Fixes: c16292578ffa ("dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller") Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> --- include/dt-bindings/reset/amlogic,meson-axg-reset.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)