| Message ID | 20180423144657.63264-4-icenowy@aosc.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 23, 2018 at 10:46:57PM +0800, Icenowy Zheng wrote: > From: Ondrej Jirman <megous@megous.com> > > Add SY8106A regulator to r_i2c bus and enable the r_i2c bus on > Orange Pi PC, then set the power supply of the ARM cores to this > regulator, in order to enable DVFS. > > Signed-off-by: Ondrej Jirman <megous@megous.com> > [Icenowy: Enable DVFS in this patch, slight changes and change commit > message] > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > [wens@csie.org: Rename regulator label] > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Why is there Chen-Yu's SoB? It doesn't really make much sense, unless Chen-Yu would have applied this patch already, but then you wouldn't post it, right? Maxime > ---
于 2018年4月23日 GMT+08:00 下午11:03:09, Maxime Ripard <maxime.ripard@bootlin.com> 写到: >On Mon, Apr 23, 2018 at 10:46:57PM +0800, Icenowy Zheng wrote: >> From: Ondrej Jirman <megous@megous.com> >> >> Add SY8106A regulator to r_i2c bus and enable the r_i2c bus on >> Orange Pi PC, then set the power supply of the ARM cores to this >> regulator, in order to enable DVFS. >> >> Signed-off-by: Ondrej Jirman <megous@megous.com> >> [Icenowy: Enable DVFS in this patch, slight changes and change commit >> message] >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> Reviewed-by: Chen-Yu Tsai <wens@csie.org> >> [wens@csie.org: Rename regulator label] >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > >Why is there Chen-Yu's SoB? It doesn't really make much sense, unless >Chen-Yu would have applied this patch already, but then you wouldn't >post it, right? This is taken from sunxi/h3-h5-for-4.18 branch, which has label name change from wens, and then added microvolt property. So his SoB is from when he apply it for the first time. > >Maxime > >> ---
diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts index cea4d647ecbf..46240334128f 100644 --- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts @@ -113,6 +113,10 @@ status = "okay"; }; +&cpu0 { + cpu-supply = <®_vdd_cpux>; +}; + &ehci0 { status = "okay"; }; @@ -182,6 +186,30 @@ }; }; +&r_i2c { + status = "okay"; + + reg_vdd_cpux: regulator@65 { + compatible = "silergy,sy8106a"; + reg = <0x65>; + regulator-name = "vdd-cpux"; + silergy,fixed-microvolt = <1200000>; + /* + * The datasheet uses 1.1V as the minimum value of VDD-CPUX, + * however both the Armbian DVFS table and the official one + * have operating points with voltage under 1.1V, and both + * DVFS table are known to work properly at the lowest + * operating point. + * + * Use 1.0V as the minimum voltage instead. + */ + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1300000>; + regulator-boot-on; + regulator-always-on; + }; +}; + &r_pio { leds_r_opc: led_pins { pins = "PL10";