diff mbox

[v2] mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration

Message ID 20180403203019.8988-1-lorenzo.bianconi@redhat.com (mailing list archive)
State Accepted
Commit cf7b411dcea8849e1802bd1ac35249b33050afed
Delegated to: Kalle Valo
Headers show

Commit Message

Lorenzo Bianconi April 3, 2018, 8:30 p.m. UTC
Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
will be properly set according to the usage of an external power amplifier

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
Changes since v1:
- remove first initialization in order to have the writes to that register
  grouped together in the same if/else chunk
---
 drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Felix Fietkau April 8, 2018, 10:56 a.m. UTC | #1
On 2018-04-03 22:30, Lorenzo Bianconi wrote:
> Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
> will be properly set according to the usage of an external power amplifier
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
Kalle Valo April 24, 2018, 5:32 p.m. UTC | #2
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:

> Remove unnecessary MT_TX_ALC_CFG_4 configuration since the register value
> will be properly set according to the usage of an external power amplifier
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Acked-by: Felix Fietkau <nbd@nbd.name>

Patch applied to wireless-drivers-next.git, thanks.

cf7b411dcea8 mt76x2: remove unnecessary MT_TX_ALC_CFG_4 configuration
diff mbox

Patch

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
index f28c55746cea..42414c5fa01e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_phy.c
@@ -257,7 +257,6 @@  mt76x2_phy_set_txpower_regs(struct mt76x2_dev *dev, enum nl80211_band band)
 			mt76_wr(dev, MT_TX_ALC_CFG_2, 0x1b0f0400);
 			mt76_wr(dev, MT_TX_ALC_CFG_3, 0x1b0f0476);
 		}
-		mt76_wr(dev, MT_TX_ALC_CFG_4, 0);
 
 		if (mt76x2_ext_pa_enabled(dev, band))
 			pa_mode_adj = 0x04000000;