| Message ID | 20180424154003.2604-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 24, 2018 at 9:10 PM, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > Replace the initialisation of the vsps table with a NULL specifier. > > Fixes the following warning: > linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40: > warning: Using plain integer as NULL pointer > CC drivers/gpu/drm/rcar-du/rcar_du_kms.o Hi Kieran, Change looks ok to me. > Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same VSP") > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Vaishali Thakkar <vthakkar@vaishalithakkar.in> > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index ef72dff00763..cf5b422fc753 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu) > struct { > struct device_node *np; > unsigned int crtcs_mask; > - } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, }; > + } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, }; > unsigned int vsps_count = 0; > unsigned int cells; > unsigned int i; > -- > 2.17.0 >
On Tue, Apr 24, 2018 at 04:40:03PM +0100, Kieran Bingham wrote: > Replace the initialisation of the vsps table with a NULL specifier. > > Fixes the following warning: > linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40: > warning: Using plain integer as NULL pointer > CC drivers/gpu/drm/rcar-du/rcar_du_kms.o > > Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same VSP") > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Hi Kieran, Thank you for the patch. On Tuesday, 24 April 2018 18:40:03 EEST Kieran Bingham wrote: > Replace the initialisation of the vsps table with a NULL specifier. > > Fixes the following warning: > linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40: > warning: Using plain integer as NULL pointer > CC drivers/gpu/drm/rcar-du/rcar_du_kms.o > > Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same > VSP") Signed-off-by: Kieran Bingham > <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and applied to my tree. > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index ef72dff00763..cf5b422fc753 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device > *rcdu) struct { > struct device_node *np; > unsigned int crtcs_mask; > - } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, }; > + } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, }; > unsigned int vsps_count = 0; > unsigned int cells; > unsigned int i;
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index ef72dff00763..cf5b422fc753 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c @@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu) struct { struct device_node *np; unsigned int crtcs_mask; - } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, }; + } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, }; unsigned int vsps_count = 0; unsigned int cells; unsigned int i;
Replace the initialisation of the vsps table with a NULL specifier. Fixes the following warning: linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40: warning: Using plain integer as NULL pointer CC drivers/gpu/drm/rcar-du/rcar_du_kms.o Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same VSP") Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)