| Message ID | 1524160568-27583-3-git-send-email-spanda@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Sandeep Panda (2018-04-19 10:56:06) > Document the bindings used for the sn65dsi86 DSI to eDP bridge. > > Changes in v1: > - Rephrase the dt-binding descriptions to be more inline with existing > bindings (Andrzej Hajda). > - Add missing dt-binding that are parsed by corresponding driver > (Andrzej Hajda). > > Changes in v2: > - Removed edp panel specific dt-binding entries. Only keep bridge > specific entries (Sean Paul). > - Remove custom-modes dt entry since its usage is removed from driver also (Sean Paul). > - Remove is-pluggable dt entry since this will not be needed anymore (Sean Paul). > > Changes in v3: > - Removed irq-gpio dt entry and instead populate is an interrupt > property (Rob Herring). These changelogs usually go below the triple dash, but maybe drm is different and wants them? > > Signed-off-by: Sandeep Panda <spanda@codeaurora.org> > --- > .../bindings/display/bridge/ti,sn65dsi86.txt | 61 ++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > new file mode 100644 > index 0000000..412c4a2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > @@ -0,0 +1,61 @@ > +SN65DSI86 DSI to eDP bridge chip > +-------------------------------- > + > +This is the binding for Texas Instruments SN65DSI86 bridge. Can you add a link to the datasheet here please? > + > +Required properties: > +- compatible: Must be "ti,sn65dsi86" > +- reg: i2c address of the chip, 0x2d as per datasheet > +- enable-gpios: OF device-tree gpio specifications for bridge_en pin > + > +- vccio-supply: A 1.8V supply that powers up the digital IOs. > +- vcca-supply: A 1.2V supply that powers up the analog circuits. Can you add vpll and vcc from the datasheet as well? Also refclk would be good to have just in case it's present (so optional?), and hpd should be another gpio property (could be optional I suppose). It also looks like this chip has a gpio controller on it, so it would need to have a gpio-controller property and #gpio-cells. And one of those GPIOs does PWM, so it would need #pwm-cells as well. I'm not saying the code needs to be written yet, but at least the binding would need to specify these things.
On Wed, Apr 25, 2018 at 7:45 PM, Stephen Boyd <swboyd@chromium.org> wrote: > Quoting Sandeep Panda (2018-04-19 10:56:06) >> Document the bindings used for the sn65dsi86 DSI to eDP bridge. >> >> Changes in v1: >> - Rephrase the dt-binding descriptions to be more inline with existing >> bindings (Andrzej Hajda). >> - Add missing dt-binding that are parsed by corresponding driver >> (Andrzej Hajda). >> >> Changes in v2: >> - Removed edp panel specific dt-binding entries. Only keep bridge >> specific entries (Sean Paul). >> - Remove custom-modes dt entry since its usage is removed from driver also (Sean Paul). >> - Remove is-pluggable dt entry since this will not be needed anymore (Sean Paul). >> >> Changes in v3: >> - Removed irq-gpio dt entry and instead populate is an interrupt >> property (Rob Herring). > > These changelogs usually go below the triple dash, but maybe drm is > different and wants them? yeah, drm generally wants them in the commit msg rather than below the triple-dash, although I guess for bindings docs it should follow the rules for that tree.. I usually just fix up these sort of things as I apply patches, but not sure what other maintainers prefer BR, -R >> >> Signed-off-by: Sandeep Panda <spanda@codeaurora.org> >> --- >> .../bindings/display/bridge/ti,sn65dsi86.txt | 61 ++++++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt >> new file mode 100644 >> index 0000000..412c4a2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt >> @@ -0,0 +1,61 @@ >> +SN65DSI86 DSI to eDP bridge chip >> +-------------------------------- >> + >> +This is the binding for Texas Instruments SN65DSI86 bridge. > > Can you add a link to the datasheet here please? > >> + >> +Required properties: >> +- compatible: Must be "ti,sn65dsi86" >> +- reg: i2c address of the chip, 0x2d as per datasheet >> +- enable-gpios: OF device-tree gpio specifications for bridge_en pin >> + >> +- vccio-supply: A 1.8V supply that powers up the digital IOs. >> +- vcca-supply: A 1.2V supply that powers up the analog circuits. > > Can you add vpll and vcc from the datasheet as well? > > Also refclk would be good to have just in case it's present (so > optional?), and hpd should be another gpio property (could be optional I > suppose). > > It also looks like this chip has a gpio controller on it, so it would > need to have a gpio-controller property and #gpio-cells. And one of > those GPIOs does PWM, so it would need #pwm-cells as well. I'm not > saying the code needs to be written yet, but at least the binding would > need to specify these things.
On Wed, Apr 25, 2018 at 08:46:13PM -0400, Rob Clark wrote: > On Wed, Apr 25, 2018 at 7:45 PM, Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Sandeep Panda (2018-04-19 10:56:06) > >> Document the bindings used for the sn65dsi86 DSI to eDP bridge. > >> > >> Changes in v1: > >> - Rephrase the dt-binding descriptions to be more inline with existing > >> bindings (Andrzej Hajda). > >> - Add missing dt-binding that are parsed by corresponding driver > >> (Andrzej Hajda). > >> > >> Changes in v2: > >> - Removed edp panel specific dt-binding entries. Only keep bridge > >> specific entries (Sean Paul). > >> - Remove custom-modes dt entry since its usage is removed from driver also (Sean Paul). > >> - Remove is-pluggable dt entry since this will not be needed anymore (Sean Paul). > >> > >> Changes in v3: > >> - Removed irq-gpio dt entry and instead populate is an interrupt > >> property (Rob Herring). > > > > These changelogs usually go below the triple dash, but maybe drm is > > different and wants them? > > yeah, drm generally wants them in the commit msg rather than below the > triple-dash, although I guess for bindings docs it should follow the > rules for that tree.. I usually just fix up these sort of things as I > apply patches, but not sure what other maintainers prefer Well, these DPU patches aren't targeted for upstream so who cares. Many patch revision changelogs I see are crap with statements like "implement changes requested by ??". But in this case, the changelog is really good. Rob
On 2018-04-27 08:43, Rob Herring wrote: > On Wed, Apr 25, 2018 at 08:46:13PM -0400, Rob Clark wrote: >> On Wed, Apr 25, 2018 at 7:45 PM, Stephen Boyd <swboyd@chromium.org> >> wrote: >> > Quoting Sandeep Panda (2018-04-19 10:56:06) >> >> Document the bindings used for the sn65dsi86 DSI to eDP bridge. >> >> >> >> Changes in v1: >> >> - Rephrase the dt-binding descriptions to be more inline with existing >> >> bindings (Andrzej Hajda). >> >> - Add missing dt-binding that are parsed by corresponding driver >> >> (Andrzej Hajda). >> >> >> >> Changes in v2: >> >> - Removed edp panel specific dt-binding entries. Only keep bridge >> >> specific entries (Sean Paul). >> >> - Remove custom-modes dt entry since its usage is removed from driver also (Sean Paul). >> >> - Remove is-pluggable dt entry since this will not be needed anymore (Sean Paul). >> >> >> >> Changes in v3: >> >> - Removed irq-gpio dt entry and instead populate is an interrupt >> >> property (Rob Herring). >> > >> > These changelogs usually go below the triple dash, but maybe drm is >> > different and wants them? >> >> yeah, drm generally wants them in the commit msg rather than below the >> triple-dash, although I guess for bindings docs it should follow the >> rules for that tree.. I usually just fix up these sort of things as I >> apply patches, but not sure what other maintainers prefer > > Well, these DPU patches aren't targeted for upstream so who cares. This change is independent of other DPU patches. We are planning to upstream these bridge and panel changes. I will upload the next patchset dropping the DPU tag to avoid any confusion. > > Many patch revision changelogs I see are crap with statements like > "implement changes requested by ??". But in this case, the changelog is > really good. > > Rob
On Fri, Apr 27, 2018 at 3:02 AM, <spanda@codeaurora.org> wrote: > On 2018-04-27 08:43, Rob Herring wrote: >> >> On Wed, Apr 25, 2018 at 08:46:13PM -0400, Rob Clark wrote: >>> >>> On Wed, Apr 25, 2018 at 7:45 PM, Stephen Boyd <swboyd@chromium.org> >>> wrote: >>> > Quoting Sandeep Panda (2018-04-19 10:56:06) >>> >> Document the bindings used for the sn65dsi86 DSI to eDP bridge. >>> >> >>> >> Changes in v1: >>> >> - Rephrase the dt-binding descriptions to be more inline with >>> >> existing >>> >> bindings (Andrzej Hajda). >>> >> - Add missing dt-binding that are parsed by corresponding driver >>> >> (Andrzej Hajda). >>> >> >>> >> Changes in v2: >>> >> - Removed edp panel specific dt-binding entries. Only keep bridge >>> >> specific entries (Sean Paul). >>> >> - Remove custom-modes dt entry since its usage is removed from driver >>> >> also (Sean Paul). >>> >> - Remove is-pluggable dt entry since this will not be needed anymore >>> >> (Sean Paul). >>> >> >>> >> Changes in v3: >>> >> - Removed irq-gpio dt entry and instead populate is an interrupt >>> >> property (Rob Herring). >>> > >>> > These changelogs usually go below the triple dash, but maybe drm is >>> > different and wants them? >>> >>> yeah, drm generally wants them in the commit msg rather than below the >>> triple-dash, although I guess for bindings docs it should follow the >>> rules for that tree.. I usually just fix up these sort of things as I >>> apply patches, but not sure what other maintainers prefer >> >> >> Well, these DPU patches aren't targeted for upstream so who cares. > > > This change is independent of other DPU patches. We are planning to upstream > these bridge and panel changes. > I will upload the next patchset dropping the DPU tag to avoid any confusion. > jfwiw, probably a good idea not to use the 'DPU' tag for anything that isn't dependent on the DPU patcheset, to reduce confusion BR, -R
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt new file mode 100644 index 0000000..412c4a2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt @@ -0,0 +1,61 @@ +SN65DSI86 DSI to eDP bridge chip +-------------------------------- + +This is the binding for Texas Instruments SN65DSI86 bridge. + +Required properties: +- compatible: Must be "ti,sn65dsi86" +- reg: i2c address of the chip, 0x2d as per datasheet +- enable-gpios: OF device-tree gpio specifications for bridge_en pin + +- vccio-supply: A 1.8V supply that powers up the digital IOs. +- vcca-supply: A 1.2V supply that powers up the analog circuits. + +Optional properties: +- interrupts: Specifier for the SN65DSI86 interrupt line. + +Required nodes: + +This device has two video ports. Their connections are modelled using the +OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. + +- Video port 0 for DSI input +- Video port 1 for eDP output + +Example +------- + +edp-bridge@2d { + compatible = "ti,sn65dsi86"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x2d>; + + enable-gpios = <&msmgpio 33 GPIO_ACTIVE_HIGH>; + interrupt-parent = <&gpio3>; + interrupts = <4 IRQ_TYPE_EDGE_FALLING>; + + vccio-supply = <&pm8916_l17>; + vcca-supply = <&pm8916_l6>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + edp_bridge_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + + port@1 { + reg = <1>; + + edp_bridge_out: endpoint { + remote-endpoint = <&edp_panel_in>; + }; + }; + }; +}
Document the bindings used for the sn65dsi86 DSI to eDP bridge. Changes in v1: - Rephrase the dt-binding descriptions to be more inline with existing bindings (Andrzej Hajda). - Add missing dt-binding that are parsed by corresponding driver (Andrzej Hajda). Changes in v2: - Removed edp panel specific dt-binding entries. Only keep bridge specific entries (Sean Paul). - Remove custom-modes dt entry since its usage is removed from driver also (Sean Paul). - Remove is-pluggable dt entry since this will not be needed anymore (Sean Paul). Changes in v3: - Removed irq-gpio dt entry and instead populate is an interrupt property (Rob Herring). Signed-off-by: Sandeep Panda <spanda@codeaurora.org> --- .../bindings/display/bridge/ti,sn65dsi86.txt | 61 ++++++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt