| Message ID | 20180426115115.13744-6-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 26, 2018 at 02:51:15PM +0300, Peter Ujfalusi wrote: > From: Jarkko Nikula <jarkko.nikula@bitmer.com> > > Commit e9f5f1e45608 ("ARM: OMAP2+: Remove legacy mux code") removed > CONFIG_OMAP_MUX making impossible to build Nokia N810 audio support. Remove > this dependency so we can do at least build tests. > > Fixes: e9f5f1e45608 ("ARM: OMAP2+: Remove legacy mux code") > Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com> > --- You're missing your signoff here.
Mark, On 2018-04-26 15:54, Mark Brown wrote: > On Thu, Apr 26, 2018 at 02:51:15PM +0300, Peter Ujfalusi wrote: >> From: Jarkko Nikula <jarkko.nikula@bitmer.com> >> >> Commit e9f5f1e45608 ("ARM: OMAP2+: Remove legacy mux code") removed >> CONFIG_OMAP_MUX making impossible to build Nokia N810 audio support. Remove >> this dependency so we can do at least build tests. >> >> Fixes: e9f5f1e45608 ("ARM: OMAP2+: Remove legacy mux code") >> Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com> >> --- > > You're missing your signoff here. I have not changed the patch itself, just picked it from the list to include to the series. Afaik in this case my signoff is not needed. Can you add my (or I can resend the series): Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> or Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com> or Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On Thu, Apr 26, 2018 at 04:01:51PM +0300, Peter Ujfalusi wrote: > On 2018-04-26 15:54, Mark Brown wrote: > > You're missing your signoff here. > I have not changed the patch itself, just picked it from the list to > include to the series. Afaik in this case my signoff is not needed. No, you need to add your signoff for *anything* you're submitting. It's about tracking the path the patch takes to mainline. > Can you add my (or I can resend the series): > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> OK.
On 2018-04-26 16:03, Mark Brown wrote: > On Thu, Apr 26, 2018 at 04:01:51PM +0300, Peter Ujfalusi wrote: >> On 2018-04-26 15:54, Mark Brown wrote: > >>> You're missing your signoff here. > >> I have not changed the patch itself, just picked it from the list to >> include to the series. Afaik in this case my signoff is not needed. > > No, you need to add your signoff for *anything* you're submitting. It's > about tracking the path the patch takes to mainline. OK. I left it off because recently there were replies from other maintainers saying otherwise (no need to singoff of unmodified patches from others). I agree that adding the signoff is the correct way. >> Can you add my (or I can resend the series): >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > OK. Thank you, - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On Thu, Apr 26, 2018 at 04:06:51PM +0300, Peter Ujfalusi wrote: > On 2018-04-26 16:03, Mark Brown wrote: > > No, you need to add your signoff for *anything* you're submitting. It's > > about tracking the path the patch takes to mainline. > OK. I left it off because recently there were replies from other > maintainers saying otherwise (no need to singoff of unmodified patches > from others). > I agree that adding the signoff is the correct way. Oh dear, who was saying that - might cause lawyers to get upset...
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index ba56d71c3ca7..65864a60d0e2 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -42,7 +42,6 @@ config SND_OMAP_SOC_HDMI_AUDIO config SND_OMAP_SOC_N810 tristate "SoC Audio support for Nokia N810" depends on SND_OMAP_SOC && MACH_NOKIA_N810 && I2C - depends on OMAP_MUX select SND_OMAP_SOC_MCBSP select SND_SOC_TLV320AIC3X help