| Message ID | 20180424164049.4687-1-bigeasy@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 24 April 2018 at 18:40, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > From: Thomas Gleixner <tglx@linutronix.de> > > On !RT interrupt runs with interrupts disabled. On RT it's in a > thread, so no need to disable interrupts at all. > Remove the local_irq_save() invocation. I was curious and found that those calls has been there forever. Weird that we haven't spotted this until now. :-) > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/mmci.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > index 70b0df8b9c78..f1849775e47e 100644 > --- a/drivers/mmc/host/mmci.c > +++ b/drivers/mmc/host/mmci.c > @@ -1253,15 +1253,12 @@ static irqreturn_t mmci_pio_irq(int irq, void *dev_id) > struct sg_mapping_iter *sg_miter = &host->sg_miter; > struct variant_data *variant = host->variant; > void __iomem *base = host->base; > - unsigned long flags; > u32 status; > > status = readl(base + MMCISTATUS); > > dev_dbg(mmc_dev(host->mmc), "irq1 (pio) %08x\n", status); > > - local_irq_save(flags); > - > do { > unsigned int remain, len; > char *buffer; > @@ -1301,8 +1298,6 @@ static irqreturn_t mmci_pio_irq(int irq, void *dev_id) > > sg_miter_stop(sg_miter); > > - local_irq_restore(flags); > - > /* > * If we have less than the fifo 'half-full' threshold to transfer, > * trigger a PIO interrupt as soon as any data is available. > -- > 2.17.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index 70b0df8b9c78..f1849775e47e 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -1253,15 +1253,12 @@ static irqreturn_t mmci_pio_irq(int irq, void *dev_id) struct sg_mapping_iter *sg_miter = &host->sg_miter; struct variant_data *variant = host->variant; void __iomem *base = host->base; - unsigned long flags; u32 status; status = readl(base + MMCISTATUS); dev_dbg(mmc_dev(host->mmc), "irq1 (pio) %08x\n", status); - local_irq_save(flags); - do { unsigned int remain, len; char *buffer; @@ -1301,8 +1298,6 @@ static irqreturn_t mmci_pio_irq(int irq, void *dev_id) sg_miter_stop(sg_miter); - local_irq_restore(flags); - /* * If we have less than the fifo 'half-full' threshold to transfer, * trigger a PIO interrupt as soon as any data is available.