| Message ID | 20180430114058.5061-9-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 30, 2018 at 05:10:45PM +0530, Jagan Teki wrote: > HDMI PHY on Allwinner A64 has similar like H3/H5. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index 9ea4353caadd..7dcd1d64dfe4 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -104,6 +104,7 @@ Required properties: > - compatible: value must be one of: > * allwinner,sun8i-a83t-hdmi-phy > * allwinner,sun8i-h3-hdmi-phy > + * allwinner,sun50i-a64-hdmi-phy This should be one valid combination per line. The dts shows that the h3 string is a fallback which should be captured in the binding doc. > - reg: base address and size of memory-mapped region > - clocks: phandles to the clocks feeding the HDMI PHY > * bus: the HDMI PHY interface clock > -- > 2.14.3 >
Hi Rob, On Tue, May 1, 2018 at 9:49 PM, Rob Herring <robh@kernel.org> wrote: > > On Mon, Apr 30, 2018 at 05:10:45PM +0530, Jagan Teki wrote: > > HDMI PHY on Allwinner A64 has similar like H3/H5. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > index 9ea4353caadd..7dcd1d64dfe4 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > @@ -104,6 +104,7 @@ Required properties: > > - compatible: value must be one of: > > * allwinner,sun8i-a83t-hdmi-phy > > * allwinner,sun8i-h3-hdmi-phy > > + * allwinner,sun50i-a64-hdmi-phy > > This should be one valid combination per line. The dts shows that the h3 > string is a fallback which should be captured in the binding doc. The fallback compatible "allwinner,sun8i-h3-hdmi-phy" is already documented above, what we need to capture here? or did I miss anything here?
On Wed, May 2, 2018 at 1:27 AM, Jagan Teki <jagan@amarulasolutions.com> wrote: > Hi Rob, > > On Tue, May 1, 2018 at 9:49 PM, Rob Herring <robh@kernel.org> wrote: >> >> On Mon, Apr 30, 2018 at 05:10:45PM +0530, Jagan Teki wrote: >> > HDMI PHY on Allwinner A64 has similar like H3/H5. >> > >> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> > --- >> > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt >> > index 9ea4353caadd..7dcd1d64dfe4 100644 >> > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt >> > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt >> > @@ -104,6 +104,7 @@ Required properties: >> > - compatible: value must be one of: >> > * allwinner,sun8i-a83t-hdmi-phy >> > * allwinner,sun8i-h3-hdmi-phy >> > + * allwinner,sun50i-a64-hdmi-phy >> >> This should be one valid combination per line. The dts shows that the h3 >> string is a fallback which should be captured in the binding doc. > > The fallback compatible "allwinner,sun8i-h3-hdmi-phy" is already > documented above, what we need to capture here? or did I miss anything > here? The documentation should make it clear which of these is valid in a dts: "allwinner,sun50i-a64-hdmi-phy", "allwinner,sun8i-h3-hdmi-phy" or: "allwinner,sun50i-a64-hdmi-phy" IOW, your list should look like this: * "allwinner,sun8i-a83t-hdmi-phy", "allwinner,sun8i-h3-hdmi-phy" * "allwinner,sun50i-a64-hdmi-phy", "allwinner,sun8i-h3-hdmi-phy" * "allwinner,sun8i-h3-hdmi-phy" Depending on whether the a83t is also compatible with h3. Rob
diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index 9ea4353caadd..7dcd1d64dfe4 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt @@ -104,6 +104,7 @@ Required properties: - compatible: value must be one of: * allwinner,sun8i-a83t-hdmi-phy * allwinner,sun8i-h3-hdmi-phy + * allwinner,sun50i-a64-hdmi-phy - reg: base address and size of memory-mapped region - clocks: phandles to the clocks feeding the HDMI PHY * bus: the HDMI PHY interface clock
HDMI PHY on Allwinner A64 has similar like H3/H5. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 1 + 1 file changed, 1 insertion(+)