| Message ID | 20180425132641.106385-1-tweek@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote: > Signed-off-by: Thiebaud Weksteen <tweek@google.com> > --- > drivers/char/tpm/tpm_eventlog_of.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_eventlog_of.c b/drivers/char/tpm/tpm_eventlog_of.c > index 96fd5646f866..ea0f16f19d73 100644 > --- a/drivers/char/tpm/tpm_eventlog_of.c > +++ b/drivers/char/tpm/tpm_eventlog_of.c > @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip) > * but physical tpm needs the conversion. > */ > if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) { > - size = be32_to_cpup(sizep); > - base = be64_to_cpup(basep); > + size = be32_to_cpup((__force __be32 *)sizep); > + base = be64_to_cpup((__force __be64 *)basep); > } else { > size = *sizep; > base = *basep; > -- > 2.17.0.484.g0c8726318c-goog > Repeal and replace, right (no change log)? /Jarkko
On Tue, May 1, 2018 at 1:49 PM Jarkko Sakkinen < jarkko.sakkinen@linux.intel.com> wrote: > On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote: > > Signed-off-by: Thiebaud Weksteen <tweek@google.com> > > --- > > drivers/char/tpm/tpm_eventlog_of.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/char/tpm/tpm_eventlog_of.c b/drivers/char/tpm/tpm_eventlog_of.c > > index 96fd5646f866..ea0f16f19d73 100644 > > --- a/drivers/char/tpm/tpm_eventlog_of.c > > +++ b/drivers/char/tpm/tpm_eventlog_of.c > > @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip) > > * but physical tpm needs the conversion. > > */ > > if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) { > > - size = be32_to_cpup(sizep); > > - base = be64_to_cpup(basep); > > + size = be32_to_cpup((__force __be32 *)sizep); > > + base = be64_to_cpup((__force __be64 *)basep); > > } else { > > size = *sizep; > > base = *basep; > > -- > > 2.17.0.484.g0c8726318c-goog > > > Repeal and replace, right (no change log)? Yep, that's right. Thanks. > /Jarkko
On Wed, May 02, 2018 at 08:49:41AM +0000, Thiebaud Weksteen wrote: > On Tue, May 1, 2018 at 1:49 PM Jarkko Sakkinen < > jarkko.sakkinen@linux.intel.com> wrote: > > > On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote: > > > Signed-off-by: Thiebaud Weksteen <tweek@google.com> > > > --- > > > drivers/char/tpm/tpm_eventlog_of.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/char/tpm/tpm_eventlog_of.c > b/drivers/char/tpm/tpm_eventlog_of.c > > > index 96fd5646f866..ea0f16f19d73 100644 > > > --- a/drivers/char/tpm/tpm_eventlog_of.c > > > +++ b/drivers/char/tpm/tpm_eventlog_of.c > > > @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip) > > > * but physical tpm needs the conversion. > > > */ > > > if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) { > > > - size = be32_to_cpup(sizep); > > > - base = be64_to_cpup(basep); > > > + size = be32_to_cpup((__force __be32 *)sizep); > > > + base = be64_to_cpup((__force __be64 *)basep); > > > } else { > > > size = *sizep; > > > base = *basep; > > > -- > > > 2.17.0.484.g0c8726318c-goog > > > > > > Repeal and replace, right (no change log)? > > Yep, that's right. Thanks. Done. /Jarkko
diff --git a/drivers/char/tpm/tpm_eventlog_of.c b/drivers/char/tpm/tpm_eventlog_of.c index 96fd5646f866..ea0f16f19d73 100644 --- a/drivers/char/tpm/tpm_eventlog_of.c +++ b/drivers/char/tpm/tpm_eventlog_of.c @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip) * but physical tpm needs the conversion. */ if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) { - size = be32_to_cpup(sizep); - base = be64_to_cpup(basep); + size = be32_to_cpup((__force __be32 *)sizep); + base = be64_to_cpup((__force __be64 *)basep); } else { size = *sizep; base = *basep;
Signed-off-by: Thiebaud Weksteen <tweek@google.com> --- drivers/char/tpm/tpm_eventlog_of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)