diff mbox

arm64: defconfig: Increase CMA size for VC4

Message ID 1525296700-3588-1-git-send-email-stefan.wahren@i2se.com (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Wahren May 2, 2018, 9:31 p.m. UTC
The VC4 needs more memory than the default setting (16 MB):

  vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
  [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
  vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
    You may need to enable CMA or give it more memory.
  vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
  vc4-drm soc:gpu: master bind failed: -12
  vc4-drm: probe of soc:gpu failed with error -12

So increase the value to 32 MB and fix this issue.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---

Hi,
i known it's a little bit late for 4.18 or should i rebase for 4.17?

Regards

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Eric Anholt May 3, 2018, 9:20 p.m. UTC | #1
Stefan Wahren <stefan.wahren@i2se.com> writes:

> The VC4 needs more memory than the default setting (16 MB):
>
>   vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
>   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
>   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
>     You may need to enable CMA or give it more memory.
>   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
>   vc4-drm soc:gpu: master bind failed: -12
>   vc4-drm: probe of soc:gpu failed with error -12
>
> So increase the value to 32 MB and fix this issue.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

If there was a way to check how big the CMA pool is, then we could
probably have V3D disable itself when the pool was too small.  It's not
like V3D rendering is going to actually *work* with just a 32mb pool to
play in.

That said, I'd also be fine with this patch.
Stefan Wahren May 12, 2018, 9:10 a.m. UTC | #2
Hi Florian,

> Eric Anholt <eric@anholt.net> hat am 3. Mai 2018 um 23:20 geschrieben:
> 
> 
> Stefan Wahren <stefan.wahren@i2se.com> writes:
> 
> > The VC4 needs more memory than the default setting (16 MB):
> >
> >   vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
> >   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
> >   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
> >     You may need to enable CMA or give it more memory.
> >   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
> >   vc4-drm soc:gpu: master bind failed: -12
> >   vc4-drm: probe of soc:gpu failed with error -12
> >
> > So increase the value to 32 MB and fix this issue.
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> 
> If there was a way to check how big the CMA pool is, then we could
> probably have V3D disable itself when the pool was too small.  It's not
> like V3D rendering is going to actually *work* with just a 32mb pool to
> play in.
> 
> That said, I'd also be fine with this patch.

should i rebase my patch?
Florian Fainelli May 12, 2018, 5:36 p.m. UTC | #3
On May 12, 2018 2:10:26 AM PDT, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>Hi Florian,
>
>> Eric Anholt <eric@anholt.net> hat am 3. Mai 2018 um 23:20
>geschrieben:
>> 
>> 
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>> 
>> > The VC4 needs more memory than the default setting (16 MB):
>> >
>> >   vc4-drm soc:gpu: swiotlb: coherent allocation failed,
>size=16777216
>> >   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
>> >   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning:
>-12.
>> >     You may need to enable CMA or give it more memory.
>> >   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops
>[vc4]): -12
>> >   vc4-drm soc:gpu: master bind failed: -12
>> >   vc4-drm: probe of soc:gpu failed with error -12
>> >
>> > So increase the value to 32 MB and fix this issue.
>> >
>> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> 
>> If there was a way to check how big the CMA pool is, then we could
>> probably have V3D disable itself when the pool was too small.  It's
>not
>> like V3D rendering is going to actually *work* with just a 32mb pool
>to
>> play in.
>> 
>> That said, I'd also be fine with this patch.
>
>should i rebase my patch?

I was expecting Eric to pick it up, but I can do this as well sorry about the miscommunication here. Let me queue this up and update the defconfig-arm64 pull request with this commit.
Florian Fainelli May 13, 2018, 4:58 p.m. UTC | #4
Le 05/02/18 à 14:31, Stefan Wahren a écrit :
> The VC4 needs more memory than the default setting (16 MB):
> 
>   vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
>   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
>   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
>     You may need to enable CMA or give it more memory.
>   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
>   vc4-drm soc:gpu: master bind failed: -12
>   vc4-drm: probe of soc:gpu failed with error -12
> 
> So increase the value to 32 MB and fix this issue.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

Applied to defconfig-arm64/next, thanks!
Stefan Wahren May 13, 2018, 7:10 p.m. UTC | #5
> Florian Fainelli <f.fainelli@gmail.com> hat am 13. Mai 2018 um 18:58 geschrieben:
> 
> 
> Le 05/02/18 à 14:31, Stefan Wahren a écrit :
> > The VC4 needs more memory than the default setting (16 MB):
> > 
> >   vc4-drm soc:gpu: swiotlb: coherent allocation failed, size=16777216
> >   [drm:vc4_bo_create [vc4]] *ERROR* Failed to allocate from CMA:
> >   vc4_v3d 3fc00000.v3d: Failed to allocate memory for tile binning: -12.
> >     You may need to enable CMA or give it more memory.
> >   vc4-drm soc:gpu: failed to bind 3fc00000.v3d (ops vc4_v3d_ops [vc4]): -12
> >   vc4-drm soc:gpu: master bind failed: -12
> >   vc4-drm: probe of soc:gpu failed with error -12
> > 
> > So increase the value to 32 MB and fix this issue.
> > 
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> 
> Applied to defconfig-arm64/next, thanks!
> -- 
> Florian

Thank you, i will add a note next time.

Stefan
diff mbox

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 7ca583e..0e1f6d7 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -172,6 +172,7 @@  CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_DMA_CMA=y
+CONFIG_CMA_SIZE_MBYTES=32
 CONFIG_MTD=y
 CONFIG_MTD_BLOCK=y
 CONFIG_MTD_M25P80=y