diff mbox

[v2,9/9] cx231xx: Add I2C_MUX dependency

Message ID 1525382415-4049-10-git-send-email-brad@nextdimension.cc (mailing list archive)
State New, archived
Headers show

Commit Message

Brad Love May 3, 2018, 9:20 p.m. UTC
cx231xx requires i2c mux adapter capability.

Signed-off-by: Brad Love <brad@nextdimension.cc>
---
 drivers/media/usb/cx231xx/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

kernel test robot May 5, 2018, 3:36 a.m. UTC | #1
Hi Brad,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17-rc3 next-20180504]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Brad-Love/cx231xx-House-cleaning/20180505-040333
base:   git://linuxtv.org/media_tree.git master
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/i2c/Kconfig:61:error: recursive dependency detected!
>> drivers/i2c/Kconfig:61: symbol I2C_MUX is selected by VIDEO_CX231XX
>> drivers/media/usb/cx231xx/Kconfig:1: symbol VIDEO_CX231XX depends on I2C_MUX
   For a resolution refer to Documentation/kbuild/kconfig-language.txt
   subsection "Kconfig recursive dependency limitations"

vim +61 drivers/i2c/Kconfig

16538e6b Jan Engelhardt   2007-05-01  37  
9c1600ed David Brownell   2007-05-01  38  config I2C_BOARDINFO
6341e62b Christoph Jaeger 2014-12-20  39  	bool
9c1600ed David Brownell   2007-05-01  40  	default y
9c1600ed David Brownell   2007-05-01  41  
2bb5095a Jean Delvare     2009-09-18  42  config I2C_COMPAT
6341e62b Christoph Jaeger 2014-12-20  43  	bool "Enable compatibility bits for old user-space"
2bb5095a Jean Delvare     2009-09-18  44  	default y
2bb5095a Jean Delvare     2009-09-18  45  	help
2bb5095a Jean Delvare     2009-09-18  46  	  Say Y here if you intend to run lm-sensors 3.1.1 or older, or any
2bb5095a Jean Delvare     2009-09-18  47  	  other user-space package which expects i2c adapters to be class
2bb5095a Jean Delvare     2009-09-18  48  	  devices. If you don't know, say Y.
2bb5095a Jean Delvare     2009-09-18  49  
^1da177e Linus Torvalds   2005-04-16  50  config I2C_CHARDEV
^1da177e Linus Torvalds   2005-04-16  51  	tristate "I2C device interface"
^1da177e Linus Torvalds   2005-04-16  52  	help
^1da177e Linus Torvalds   2005-04-16  53  	  Say Y here to use i2c-* device files, usually found in the /dev
^1da177e Linus Torvalds   2005-04-16  54  	  directory on your system.  They make it possible to have user-space
^1da177e Linus Torvalds   2005-04-16  55  	  programs use the I2C bus.  Information on how to do this is
^1da177e Linus Torvalds   2005-04-16  56  	  contained in the file <file:Documentation/i2c/dev-interface>.
^1da177e Linus Torvalds   2005-04-16  57  
^1da177e Linus Torvalds   2005-04-16  58  	  This support is also available as a module.  If so, the module 
^1da177e Linus Torvalds   2005-04-16  59  	  will be called i2c-dev.
^1da177e Linus Torvalds   2005-04-16  60  
0826374b Michael Lawnick  2010-08-11 @61  config I2C_MUX
0826374b Michael Lawnick  2010-08-11  62  	tristate "I2C bus multiplexing support"
0826374b Michael Lawnick  2010-08-11  63  	help
0826374b Michael Lawnick  2010-08-11  64  	  Say Y here if you want the I2C core to support the ability to
0826374b Michael Lawnick  2010-08-11  65  	  handle multiplexed I2C bus topologies, by presenting each
0826374b Michael Lawnick  2010-08-11  66  	  multiplexed segment as a I2C adapter.
0826374b Michael Lawnick  2010-08-11  67  
0826374b Michael Lawnick  2010-08-11  68  	  This support is also available as a module.  If so, the module
0826374b Michael Lawnick  2010-08-11  69  	  will be called i2c-mux.
0826374b Michael Lawnick  2010-08-11  70  

:::::: The code at line 61 was first introduced by commit
:::::: 0826374bff57411d239f2fcb15da3c35af0a93cd i2c: Multiplexed I2C bus core support

:::::: TO: Michael Lawnick <ml.lawnick@gmx.de>
:::::: CC: Jean Delvare <khali@linux-fr.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/drivers/media/usb/cx231xx/Kconfig b/drivers/media/usb/cx231xx/Kconfig
index 8a6acc2..98890a3 100644
--- a/drivers/media/usb/cx231xx/Kconfig
+++ b/drivers/media/usb/cx231xx/Kconfig
@@ -1,6 +1,6 @@ 
 config VIDEO_CX231XX
 	tristate "Conexant cx231xx USB video capture support"
-	depends on VIDEO_DEV && I2C
+	depends on VIDEO_DEV && I2C && I2C_MUX
 	select VIDEO_TUNER
 	select VIDEO_TVEEPROM
 	select VIDEOBUF_VMALLOC